[GitHub] [spark] rdblue commented on issue #24686: [SPARK-27813][SQL] DataSourceV2: Add DropTable logical operation

[GitBox <gi...@apache.org>]

rdblue commented on issue #24686: [SPARK-27813][SQL] DataSourceV2: Add DropTable logical operation
URL: https://github.com/apache/spark/pull/24686#issuecomment-497059525
 
 
   +1 overall, just one minor style problem with boolean args to fix.
   
   I think this is ready to go. You might also mention a couple of things in the PR description:
   * This moves parsing of `DROP TABLE` into Catalyst and adds parsed plans, like #24029 did for create
   * Like #24029, parsing tests for `DROP TABLE` have been moved to `PlanResolutionSuite` to validate existing behavior, and new tests for the catalyst parser have been added to Catalyst's `DDLParserSuite`
   
   @cloud-fan, @dongjoon-hyun, could you review this DSv2 PR? I think it is ready to merge.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org