[jira] [Commented] (IGNITE-9659) NonCollocatedRetryMessageSelfTest is flaky

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-9659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16651816#comment-16651816 ] 

ASF GitHub Bot commented on IGNITE-9659:
----------------------------------------

GitHub user NSAmelchev opened a pull request:

    https://github.com/apache/ignite/pull/5005

    IGNITE-9659

    Fix the _NonCollocatedRetryMessageSelfTest.testNonCollocatedRetryMessage_ test.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/NSAmelchev/ignite ignite-9659

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/5005.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5005
    
----
commit dc5a776ea3d1634533bcae3f09931d0beb23cfab
Author: NSAmelchev <ns...@...>
Date:   2018-10-16T13:54:06Z

    Fix the testNonCollocatedRetryMessage test.

commit dfa7d661d14899d3a31f71fd70c589bc9d254272
Author: NSAmelchev <ns...@...>
Date:   2018-10-16T14:34:16Z

    Code style fix.

----


> NonCollocatedRetryMessageSelfTest is flaky
> ------------------------------------------
>
>                 Key: IGNITE-9659
>                 URL: https://issues.apache.org/jira/browse/IGNITE-9659
>             Project: Ignite
>          Issue Type: Test
>            Reporter: Alexey Goncharuk
>            Assignee: Amelchev Nikita
>            Priority: Major
>              Labels: MakeTeamcityGreenAgain
>
> https://ci.ignite.apache.org/viewLog.html?buildId=1881869&tab=buildResultsDiv&buildTypeId=IgniteTests24Java8_Queries2#testNameId-2853122976880171731
> A few concerns on the test code:
> 1) What is the point of setting an anonymous discovery SPI? The overridden method is identical to super(), but the new discovery SPI looses test VM IP finder which is set by default
> 2) Looks like there is a race in test communication SPI code - there is an if - assign block for a volatile variable
> 3) The test fails with "Node left during query execution" - since the node is stopped, this should be either an allowed exception, or the test communication SPI should be crafted more carefully.
> (FYI: Locally I have this test failing with No CacheException emitted. Collection size=10)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)