You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/03/05 23:14:18 UTC
[GitHub] [mynewt-core] vrahane opened a new pull request #2229:
da1469x/hal_flash: Fix write boundaries
vrahane opened a new pull request #2229: da1469x/hal_flash: Fix write boundaries
URL: https://github.com/apache/mynewt-core/pull/2229
- Write boundaries in the hal flash write callback were partially
correct, 0->0x80000 address remap also needs to be considered as per the datasheet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2229:
da1469x/hal_flash: Fix write boundaries
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on issue #2229: da1469x/hal_flash: Fix write boundaries
URL: https://github.com/apache/mynewt-core/pull/2229#issuecomment-595502539
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### hw/mcu/dialog/da1469x/src/hal_flash.c
<details>
```diff
@@ -330,9 +330,9 @@
* Due to the remap specified in the datasheet, 0->0x80000 (8 MBytes) are
* remapped, hence that needs to be considered as well.
*/
- if ((((uint32_t)src < MCU_MEM_QSPIF_M_START_ADDRESS) &&
+ if ((((uint32_t)src < MCU_MEM_QSPIF_M_START_ADDRESS) &&
((uint32_t)src >= MCU_MEM_QSPIF_M_END_REMAP_ADDRESS)) ||
- ((uint32_t)src >= MCU_MEM_QSPIF_M_END_ADDRESS)) {
+ ((uint32_t)src >= MCU_MEM_QSPIF_M_END_ADDRESS)) {
return false;
}
```
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-core] vrahane merged pull request #2229: da1469x/hal_flash:
Fix write boundaries
Posted by GitBox <gi...@apache.org>.
vrahane merged pull request #2229: da1469x/hal_flash: Fix write boundaries
URL: https://github.com/apache/mynewt-core/pull/2229
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-core] andrzej-kaczmarek commented on issue #2229:
da1469x/hal_flash: Fix write boundaries
Posted by GitBox <gi...@apache.org>.
andrzej-kaczmarek commented on issue #2229: da1469x/hal_flash: Fix write boundaries
URL: https://github.com/apache/mynewt-core/pull/2229#issuecomment-595724785
@ccollins476ad we need to check native QSPIF address space as well because app is linked there while bootloader is linked at remapped address space. This is because QSPI is remapped at 0 by ROM bootloader with an offset depending on product headers so our bootloader always starts at the same address, but at the same time this makes app base address change in remapped address space so it's easier to use native address space there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services