You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2019/10/31 15:05:03 UTC

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #280: Remove the 2GB limit when unparsing BLOBs

mbeckerle commented on a change in pull request #280: Remove the 2GB limit when unparsing BLOBs
URL: https://github.com/apache/incubator-daffodil/pull/280#discussion_r341186861
 
 

 ##########
 File path: daffodil-io/src/main/scala/org/apache/daffodil/io/DirectOrBufferedDataOutputStream.scala
 ##########
 @@ -734,6 +906,8 @@ class BitOrderChangeException(directDOS: DirectOrBufferedDataOutputStream, finfo
   }
 }
 
+class BlobIOException(message: String) extends Exception(message) with ThinThrowable
 
 Review comment:
   This is always an unexpected error I think; hence, does not need to be ThinThrowable, as we never expect to get this and  mask it for any reason. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services