You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2016/11/04 21:05:42 UTC
[kudu-CR] cmake: search for all required Kerberos binaries
Hello Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4954
to review the following change.
Change subject: cmake: search for all required Kerberos binaries
......................................................................
cmake: search for all required Kerberos binaries
Change-Id: Ic680409088f487ee9fa28cbd7e8f2a95a034b4b2
---
M CMakeLists.txt
D cmake_modules/FindKdc.cmake
A cmake_modules/FindKerberos.cmake
3 files changed, 41 insertions(+), 38 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/4954/1
--
To view, visit http://gerrit.cloudera.org:8080/4954
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic680409088f487ee9fa28cbd7e8f2a95a034b4b2
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
[kudu-CR] cmake: search for all required Kerberos binaries
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: cmake: search for all required Kerberos binaries
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4954/1/cmake_modules/FindKerberos.cmake
File cmake_modules/FindKerberos.cmake:
PS1, Line 36: find_package_handle_standard_args(${binary} REQUIRED_VARS "${binary}_BIN"
: FAIL_MESSAGE "Kerberos ${binary} not found: security tests will fail")
This means we may see a series of "Kerberos ... not found" messages, right? How about maintaining a list of binaries that weren't found, then emitting just one message with it?
--
To view, visit http://gerrit.cloudera.org:8080/4954
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic680409088f487ee9fa28cbd7e8f2a95a034b4b2
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] cmake: search for all required Kerberos binaries
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.
Change subject: cmake: search for all required Kerberos binaries
......................................................................
cmake: search for all required Kerberos binaries
If one or more binaries are not found, CMake will issue a warning like:
-- Kerberos binary not found: security tests will fail (missing: kdb5_util krb5kdc)
Change-Id: Ic680409088f487ee9fa28cbd7e8f2a95a034b4b2
Reviewed-on: http://gerrit.cloudera.org:8080/4954
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M CMakeLists.txt
D cmake_modules/FindKdc.cmake
A cmake_modules/FindKerberos.cmake
3 files changed, 40 insertions(+), 38 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4954
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic680409088f487ee9fa28cbd7e8f2a95a034b4b2
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] cmake: search for all required Kerberos binaries
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: cmake: search for all required Kerberos binaries
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4954
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic680409088f487ee9fa28cbd7e8f2a95a034b4b2
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] cmake: search for all required Kerberos binaries
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4954
to look at the new patch set (#2).
Change subject: cmake: search for all required Kerberos binaries
......................................................................
cmake: search for all required Kerberos binaries
If one or more binaries are not found, CMake will issue a warning like:
-- Kerberos binary not found: security tests will fail (missing: kdb5_util krb5kdc)
Change-Id: Ic680409088f487ee9fa28cbd7e8f2a95a034b4b2
---
M CMakeLists.txt
D cmake_modules/FindKdc.cmake
A cmake_modules/FindKerberos.cmake
3 files changed, 40 insertions(+), 38 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/4954/2
--
To view, visit http://gerrit.cloudera.org:8080/4954
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic680409088f487ee9fa28cbd7e8f2a95a034b4b2
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins