[GitHub] [nifi-minifi-cpp] szaszm commented on issue #754: MINIFICPP-1151 fix most 1st party compiler warnings

[GitBox <gi...@apache.org>]

szaszm commented on issue #754: MINIFICPP-1151 fix most 1st party compiler warnings
URL: https://github.com/apache/nifi-minifi-cpp/pull/754#issuecomment-614058197
 
 
   > This introduced some strange failures:
   > 
   > ```
   > /home/travis/build/apache/nifi-minifi-cpp/nanofi/tests/CAPITests.cpp:417: FAILED:
   >   REQUIRE( ffr != nullptr )
   > with expansion:
   >   NULL != nullptr
   > ```
   
   Yes, I forgot to run the test suite before submitting. The issue was that my newly introduced check for `fread` failure assumed that it returns the number of bytes read, but in fact it returns the number of objects read, which is in this case, 1, instead of `filelen`.
   
   I'm checking tests now.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services