You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2016/01/28 00:53:59 UTC

Review Request 42880: Add test for LogrotateContainerLogger's FD management.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42880/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Artem Harutyunyan.


Bugs: MESOS-4535
    https://issues.apache.org/jira/browse/MESOS-4535


Repository: mesos


Description
-------

Adds a test which checks for erroneous calls to `os::close` by the LogrotateContainerLogger.  This may happen by accident if the container logger module uses `Subprocess::PIPE` when launching child processes; as libprocess will track these FDs and close them (possibly even if they've already been closed) when the child processes exit.


Diffs
-----

  src/tests/container_logger_tests.cpp 5fe9cce97ee83d6a9e272879ec0395b5ace4a491 

Diff: https://reviews.apache.org/r/42880/diff/


Testing
-------

make check

Test failed (expected) when I reverted the previous patch and ran `make check`


Thanks,

Joseph Wu

Re: Review Request 42880: Add test for LogrotateContainerLogger's FD management.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42880/#review116654
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/container_logger_tests.cpp (line 555)
<https://reviews.apache.org/r/42880/#comment177724>

    s/open_fds/fds/


- Benjamin Hindman


On Jan. 27, 2016, 11:53 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42880/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2016, 11:53 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
> 
> 
> Bugs: MESOS-4535
>     https://issues.apache.org/jira/browse/MESOS-4535
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adds a test which checks for erroneous calls to `os::close` by the LogrotateContainerLogger.  This may happen by accident if the container logger module uses `Subprocess::PIPE` when launching child processes; as libprocess will track these FDs and close them (possibly even if they've already been closed) when the child processes exit.
> 
> 
> Diffs
> -----
> 
>   src/tests/container_logger_tests.cpp 5fe9cce97ee83d6a9e272879ec0395b5ace4a491 
> 
> Diff: https://reviews.apache.org/r/42880/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> Test failed (expected) when I reverted the previous patch and ran `make check`
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 42880: Add test for LogrotateContainerLogger's FD management.

Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42880/
-----------------------------------------------------------

(Updated Jan. 27, 2016, 4:09 p.m.)


Review request for mesos, Benjamin Hindman and Artem Harutyunyan.


Changes
-------

Renamed variable.


Bugs: MESOS-4535
    https://issues.apache.org/jira/browse/MESOS-4535


Repository: mesos


Description
-------

Adds a test which checks for erroneous calls to `os::close` by the LogrotateContainerLogger.  This may happen by accident if the container logger module uses `Subprocess::PIPE` when launching child processes; as libprocess will track these FDs and close them (possibly even if they've already been closed) when the child processes exit.


Diffs (updated)
-----

  src/tests/container_logger_tests.cpp 5fe9cce97ee83d6a9e272879ec0395b5ace4a491 

Diff: https://reviews.apache.org/r/42880/diff/


Testing
-------

make check

Test failed (expected) when I reverted the previous patch and ran `make check`


Thanks,

Joseph Wu