You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/14 08:50:35 UTC
[GitHub] [airflow] potiuk opened a new pull request #13056: Additional info about Snowflake provider breaking amazon one
potiuk opened a new pull request #13056:
URL: https://github.com/apache/airflow/pull/13056
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #13056: Additional info about Snowflake provider breaking amazon one
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #13056:
URL: https://github.com/apache/airflow/pull/13056#discussion_r542303173
##########
File path: airflow/providers/amazon/ADDITIONAL_INFO.md
##########
@@ -0,0 +1,32 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+ -->
+
+## Additional limitations
+
+The amazon provider might not work correctly with when it is installed together with the
Review comment:
```suggestion
The amazon provider might not work correctly when it is installed together with the
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #13056: Additional info about Snowflake provider breaking amazon one
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #13056:
URL: https://github.com/apache/airflow/pull/13056
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13056: Additional info about Snowflake provider breaking amazon one
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13056:
URL: https://github.com/apache/airflow/pull/13056#issuecomment-744520160
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13056: Additional info about Snowflake provider breaking amazon one
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13056:
URL: https://github.com/apache/airflow/pull/13056#issuecomment-744523272
It looks like I would have to add this information to almost all the providers, so I am holding of with this one - we discussed with @ashb that we will immediately yank the snowflake provider to mark it as "bad" release and we are informing Snowflake to fix their client. They seem to realize that already that this is VERY bad thing they'e done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13056: Additional info about Snowflake provider breaking amazon one
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13056:
URL: https://github.com/apache/airflow/pull/13056#issuecomment-744285908
I've added extra info to both Amazon and Snowflake providers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #13056: Additional info about Snowflake provider breaking amazon one
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #13056:
URL: https://github.com/apache/airflow/pull/13056#discussion_r542303421
##########
File path: airflow/providers/amazon/ADDITIONAL_INFO.md
##########
@@ -0,0 +1,32 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+ -->
+
+## Additional limitations
+
+The amazon provider might not work correctly with when it is installed together with the
+Snowflake provider. It's because of Snowflake monkeypatching the urllib3
+library as described in [this issue](https://github.com/snowflakedb/snowflake-connector-python/issues/324)
Review comment:
```suggestion
library as described in [this issue](https://github.com/snowflakedb/snowflake-connector-python/issues/324),
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #13056: Additional info about Snowflake provider breaking amazon one
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #13056:
URL: https://github.com/apache/airflow/pull/13056#discussion_r542316893
##########
File path: airflow/providers/snowflake/ADDITIONAL_INFO.md
##########
@@ -17,10 +17,16 @@
under the License.
-->
-## Change in import paths
+## Known incompatibilities with other providers
-If you are upgrading from 2020.10.5 note the following changes in import paths
+The Snowflake provider when installed might break other providers. As of 14 December 2020 we know that Presto with
+Kerberos + SSL and Amazon providers are broken.
-| Old path | New path |
-| --------------------------------------------------------------- | ----------------------------------------------------------- |
-| airflow.providers.amazon.aws.hooks.aws_dynamodb.AwsDynamoDBHook | airflow.providers.amazon.aws.hooks.dynamodb.AwsDynamoDBHook |
+It's because of Snowflake monkeypatching the urllib3library as described in
Review comment:
```suggestion
It's because of Snowflake monkeypatching the `urllib3` library as described in
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13056: Additional info about Snowflake provider breaking amazon one
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13056:
URL: https://github.com/apache/airflow/pull/13056#issuecomment-744470477
Committed all of those
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13056: Additional info about Snowflake provider breaking amazon one
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13056:
URL: https://github.com/apache/airflow/pull/13056#issuecomment-744284473
Turns out snowflake provider also breaks Amazon provider :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org