[GitHub] [calcite] NobiGo commented on a change in pull request #2692: [CALCITE-4980] Babel parser support MySQL NULL-safe equal operator '<=>' (xurenhe&&DuanXiong)

[GitBox <gi...@apache.org>]

NobiGo commented on a change in pull request #2692:
URL: https://github.com/apache/calcite/pull/2692#discussion_r791339162



##########
File path: site/_docs/reference.md
##########
@@ -1203,13 +1203,13 @@ The operator precedence and associativity, highest to lowest.
 | * / % ||                                | left
 | + -                                               | left
 | BETWEEN, IN, LIKE, SIMILAR, OVERLAPS, CONTAINS etc. | -
-| < > = <= >= <> !=                                 | left
+| < > = <= >= <> != <=>                                | left

Review comment:
       Please trims extra spaces？ The left value has translation.

##########
File path: site/_docs/reference.md
##########
@@ -2513,6 +2515,7 @@ semantics.
 | C | Operator syntax                                | Description
 |:- |:-----------------------------------------------|:-----------
 | p | expr :: type                                   | Casts *expr* to *type*
+| m | expr1 <=> expr2                                | Whether *expr1* equal to *expr2*, but returns true if both operands are `NULL`, and false if one operand is `NULL` (similar to `IS NOT DISTINCT FROM`)

Review comment:
       equals to ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org