[jira] [Commented] (FLINK-8159) Pattern(Flat)SelectFunctions should support RichFunction interface

["Dian Fu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656534#comment-16656534 ] 

Dian Fu commented on FLINK-8159:
--------------------------------

Hi [~dawidwys], 
For the concern #1 you described:
my init thoughts was to add an abstract class RichPattern(Flat)SelectFunction and leave Pattern(Flat)SelectFunction as it is (follow the same way as Function/RichFunction). So I think there will be no backwards compatibility issues.


For the concern#2:
I'm still trying to understand the problem. In my mind, there are two kinds of functions to consider: IterativeCondition and the PatternSelectFunction.
When new pattern(which contains IterativeCondition) comes (may be PatternSelectFunction will also be dynamically changed?):
For IterativeCondition, we need to recompile the NFA and call the open method of the IterativeConditions which contained in the NFA. 
For PatternSelectFunction, if it's updated, we just call the open method of the newly come PatternSelectFunction and set it as the currently used function. If not, we don't need do anything.

Thoughts?

> Pattern(Flat)SelectFunctions should support RichFunction interface
> ------------------------------------------------------------------
>
>                 Key: FLINK-8159
>                 URL: https://issues.apache.org/jira/browse/FLINK-8159
>             Project: Flink
>          Issue Type: Sub-task
>          Components: CEP
>            Reporter: Dian Fu
>            Assignee: Dian Fu
>            Priority: Major
>
> {{SelectWrapper}} and {{FlatSelectWrapper}} should extends {{AbstractRichFucntion}} and process properly if the underlying functions extend RichFunction.
> Things to be very careful about:
> * backwards compatibility (we previously serialized conditions) - changes to those interfaces have to be done carefully
> * we want to be able to add dynamic patterns in the future, so at some point we have to open also on control message arrival



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)