[GitHub] [arrow-rs] tustvold commented on a diff in pull request #1589: Fix ListArray and StructArray equality (#626)

[GitBox <gi...@apache.org>]

tustvold commented on code in PR #1589:
URL: https://github.com/apache/arrow-rs/pull/1589#discussion_r853510330


##########
arrow/src/array/equal/utils.rs:
##########
@@ -183,10 +178,8 @@ pub(super) fn child_logical_null_buffer(
             let array_offset = parent_data.offset();
             let mut buffer = MutableBuffer::new_null(parent_len);
             let null_slice = buffer.as_slice_mut();
-            (0..parent_len).for_each(|index| {
-                if parent_bitmap.is_set(index + array_offset)
-                    && self_null_bitmap.is_set(index + array_offset)
-                {
+            (array_offset..parent_len + array_offset).for_each(|index| {

Review Comment:
   As the Buffer is interchangeable with the buffer from ArrayData it needs to be created with the array offset, see FixedSizeList above



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org