You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/11/06 04:10:00 UTC
[jira] [Work logged] (HIVE-22347) Break up DDLSemanticAnalyzer -
extract Other analyzers
[ https://issues.apache.org/jira/browse/HIVE-22347?focusedWorklogId=339136&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-339136 ]
ASF GitHub Bot logged work on HIVE-22347:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Nov/19 04:09
Start Date: 06/Nov/19 04:09
Worklog Time Spent: 10m
Work Description: jcamachor commented on pull request #817: HIVE-22347 Break up DDLSemanticAnalyzer - extract Other analyzers
URL: https://github.com/apache/hive/pull/817#discussion_r342908720
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/ddl/misc/insert/commit/hook/InsertCommitHookOperation.java
##########
@@ -16,7 +16,7 @@
* limitations under the License.
*/
-package org.apache.hadoop.hive.ql.ddl.misc;
+package org.apache.hadoop.hive.ql.ddl.misc.insert.commit.hook;
Review comment:
Maybe all these could stay under misc package. I am not sure we need so many individual packages with single classes at this level. Or at least we could have more general packages, e.g., hooks, metadata. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 339136)
Time Spent: 20m (was: 10m)
> Break up DDLSemanticAnalyzer - extract Other analyzers
> ------------------------------------------------------
>
> Key: HIVE-22347
> URL: https://issues.apache.org/jira/browse/HIVE-22347
> Project: Hive
> Issue Type: Sub-task
> Reporter: Miklos Gergely
> Assignee: Miklos Gergely
> Priority: Major
> Labels: pull-request-available, refactor-ddl
> Attachments: HIVE-22347.01.patch, HIVE-22347.02.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> DDLSemanticAnalyzer is a huge class, more than 4000 lines long. The goal is to refactor it in order to have everything cut into more handleable classes under the package org.apache.hadoop.hive.ql.exec.ddl:
> * have a separate class for each analyzers
> * have a package for each operation, containing an analyzer, a description, and an operation, so the amount of classes under a package is more manageable
> Step #8: extract all the rest of the analyzers from DDLSemanticAnalyzer, which can not be classified otherwise, and move them under the new package.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)