You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/05/10 13:26:20 UTC

[GitHub] [spark] cloud-fan commented on a diff in pull request #36488: [SPARK-39112][SQL] UnsupportedOperationException if spark.sql.ui.explainMode is set to cost

cloud-fan commented on code in PR #36488:
URL: https://github.com/apache/spark/pull/36488#discussion_r869233995


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/v2ResolutionPlans.scala:
##########
@@ -140,11 +141,19 @@ case class UnresolvedDBObjectName(nameParts: Seq[String], isNamespace: Boolean)
   override def output: Seq[Attribute] = Nil
 }
 
+/**
+ * A resolved leaf like node that its statistics is no meaning.
+ */
+trait ResolvedLeafObject extends LogicalPlan with LeafLike[LogicalPlan] {

Review Comment:
   nit: `LeafNodeWithoutStats` seems better



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org