You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/08/25 13:51:01 UTC

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #990: IGNITE-17434 Fix partially correct previous implementation of sql implicit transactions.

korlov42 commented on code in PR #990:
URL: https://github.com/apache/ignite-3/pull/990#discussion_r954995735


##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDmlTest.java:
##########
@@ -86,6 +88,56 @@ public void mergeOpChangePrimaryKey() {
                 .check();
     }
 
+    @Test
+    public void batchWithConflictShouldBeRejectedEntirely() {
+        sql("CREATE TABLE test (id int primary key, val int)");
+
+        sql("INSERT INTO test values (1, 1)");
+
+        assertQuery("SELECT count(*) FROM test")
+                .returns(1L)
+                .check();
+
+        assertThrows(

Review Comment:
   fixed 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org