You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/03/30 14:31:17 UTC

[GitHub] [tvm] MuchToMyDelight commented on pull request #7763: [vm] add support for customized allocator

MuchToMyDelight commented on pull request #7763:
URL: https://github.com/apache/tvm/pull/7763#issuecomment-810310258


   > Hey @MuchToMyDelight the patch looks overall good, I wonder if we should allow users to instead register by name or some other key to support multiple allocators to be loaded?
   
   Hello jroesch, I'm not sure what do you mean by 'some other key'. Do you mean add a C++ api like Set/GetAllocator, instead of by name? I chose register by name because: 1. it make code clean & neat. 2. There are other places using the same pattern in TVM, e.g. DeviceApiManger uses keys like "device_api.gpu"/"device_api.cpu". So I suppose this is the 'TVM way' of doing this kind of thing.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org