You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Berenguer Blasi (Jira)" <ji...@apache.org> on 2022/01/10 09:05:00 UTC
[jira] [Comment Edited] (CASSANDRA-16956) Remove windows-specific classes
[ https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17471776#comment-17471776 ]
Berenguer Blasi edited comment on CASSANDRA-16956 at 1/10/22, 9:04 AM:
-----------------------------------------------------------------------
Hi [~stefan.miklosovic],
I see you posted CI results for 4.0 and trunk but I have trouble connecting all the dots. I.e. circle 4.0 run is on SHA 31f5b7e but I can't find that SHA either on the PR or the branch mentioned (I might have also missed sthg). Would you be so kind to post PR/CI pairs links for 4.0 and trunk please?
Also given this is touching shell and python I would suggest running all circle tests like the upgrade ones and also including a jenkins dev-branch run.
Makes sense?
was (Author: bereng):
Hi [~stefan.miklosovic],
I see you posted CI results for 4.0 and trunk but I have trouble connecting all the dots. I.e. circle 4.0 run is on SHA 31f5b7e but I can't find that SHA either on the PR or the branch mentioned (I might have also missed sthg). Would you be so kind to post PR/CI pairs links for 4.0 and trunk please?
Also given this is touching shell and python I would suggest running all circle tests like the update ones and also including a jenkins dev-branch run.
Makes sense?
> Remove windows-specific classes
> -------------------------------
>
> Key: CASSANDRA-16956
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16956
> Project: Cassandra
> Issue Type: Task
> Components: Build
> Reporter: Brandon Williams
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> To continue the work CASSANDRA-16171 began, now that Windows support is no more there are some source files that can be removed.
> Just doing a naive grep on the source directory I see:
> {noformat}
> src/java/org/apache/cassandra/db/WindowsFailedSnapshotTracker.java
> src/java/org/apache/cassandra/utils/NativeLibraryWindows.java
> src/java/org/apache/cassandra/utils/WindowsTimer.java
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org