[GitHub] [dolphinscheduler-website] zhongjiajie commented on a change in pull request #637: solved conflicts

[GitBox <gi...@apache.org>]

zhongjiajie commented on a change in pull request #637:
URL: https://github.com/apache/dolphinscheduler-website/pull/637#discussion_r785668230



##########
File path: site_config/community.jsx
##########
@@ -58,6 +58,10 @@ export default {
             title: 'Code of Conduct',
             link: '/en-us/community/development/code-conduct.html',
           },
+          {
+            title: 'Contributor Guide',
+            link: '/en-us/community/contributor-guide.html',
+          },

Review comment:
       Why we should add this section?

##########
File path: src/components/md2html/index.jsx
##########
@@ -50,6 +50,8 @@ const Md2Html = ComposeComponent => class extends ComposeComponent {
     const splitPart = window.location.pathname.replace(`${window.rootPath}/${language}`, '').split('/').slice(0, -1);
     const filePath = splitPart.join('/');
     const alinks = Array.from(this.markdownContainer.querySelectorAll('a'));
+    console.log(this.markdownContainer);
+    console.log(alinks);

Review comment:
       we should remove the console log.
   ```suggestion
   ```

##########
File path: docs/zh-cn/1.3.6/user_doc/cluster-deployment.md
##########
@@ -2,11 +2,11 @@
 
 # 1、基础软件安装(必装项请自行安装)
 
- * PostgreSQL (8.2.15+) or MySQL (5.7系列)：两者任选其一即可，如 MySQL 则需要 JDBC Driver 5.1.47+
- * [JDK](https://www.oracle.com/technetwork/java/javase/downloads/index.html) (1.8+)：必装，请安装好后在 /etc/profile 下配置 JAVA_HOME 及 PATH 变量
- * ZooKeeper (3.4.6+)：必装 
- * pstree or psmisc：Mac OS必装pstree，Fedora/Red/Hat/CentOS/Ubuntu/Debian必装psmisc
- * Hadoop (2.6+) or MinIO：选装，如果需要用到资源上传功能，可以选择上传到 Hadoop or MinIO 上
+* [PostgreSQL](https://www.postgresql.org/download/) (8.2.15+) or [MySQL](https://dev.mysql.com/downloads/mysql/) (5.7系列)：两者任选其一即可，如 MySQL 则需要 JDBC Driver 5.1.47+

Review comment:
       Thanks for picking the outdated PR @linjicong , it seems that we have already release versions 1.3.8, 1.3.9, 2.X.X above, could you please also change the content in those versions?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org