You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/02/14 00:23:17 UTC
[GitHub] [incubator-superset] robdiciuccio opened a new pull request #9139:
Catch TypeError on PyArrow array instantiation
robdiciuccio opened a new pull request #9139: Catch TypeError on PyArrow array instantiation
URL: https://github.com/apache/incubator-superset/pull/9139
### CATEGORY
Choose one
- [x] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
The following (Postgres) query fails with `TypeError: an integer is required (got type str)`:
```
SELECT json_build_object('test', json_build_array(123456, 'test')) AS data;
```
This is also raised when columnar data from Presto is in the following format (mixed array data types):
```
{'TestKey': [123456, 'foo']}
```
See also: https://github.com/apache/incubator-superset/pull/9096#issuecomment-584449351
*NOTE: this is meant to be a temporary fix until the [Arrow ticket](https://issues.apache.org/jira/browse/ARROW-7855) is resolved.*
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
Ensure the following query against Postgres succeeds:
```
SELECT json_build_object('test', json_build_array(123456, 'test')) AS data;
```
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
@john-bodley @serenajiang @nytai @willbarrett @dpgaspar @suddjian
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] serenajiang commented on issue #9139: Catch
TypeError on PyArrow array instantiation
Posted by GitBox <gi...@apache.org>.
serenajiang commented on issue #9139: Catch TypeError on PyArrow array instantiation
URL: https://github.com/apache/incubator-superset/pull/9139#issuecomment-586056792
Does this result in `123456` being returned as a string?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #9139: Catch
TypeError on PyArrow array instantiation
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9139: Catch TypeError on PyArrow array instantiation
URL: https://github.com/apache/incubator-superset/pull/9139#issuecomment-586040639
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9139?src=pr&el=h1) Report
> Merging [#9139](https://codecov.io/gh/apache/incubator-superset/pull/9139?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/30b7064e309c8f6d080e1c81ab3684b4a949a496?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9139?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9139 +/- ##
======================================
Coverage 59.1% 59.1%
======================================
Files 372 372
Lines 11922 11922
Branches 2919 2919
======================================
Hits 7046 7046
Misses 4694 4694
Partials 182 182
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9139?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9139?src=pr&el=footer). Last update [30b7064...a6c7892](https://codecov.io/gh/apache/incubator-superset/pull/9139?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch merged pull request #9139: Catch
TypeError on PyArrow array instantiation
Posted by GitBox <gi...@apache.org>.
mistercrunch merged pull request #9139: Catch TypeError on PyArrow array instantiation
URL: https://github.com/apache/incubator-superset/pull/9139
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] robdiciuccio commented on issue #9139: Catch
TypeError on PyArrow array instantiation
Posted by GitBox <gi...@apache.org>.
robdiciuccio commented on issue #9139: Catch TypeError on PyArrow array instantiation
URL: https://github.com/apache/incubator-superset/pull/9139#issuecomment-586096352
@serenajiang it results in the entire column value being returned as a JSON string: `{"TestKey": [123456, "foo"]}`. `123456` is an integer when the JSON is parsed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org