You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2023/01/18 21:45:09 UTC

[GitHub] [gobblin] umustafi commented on a diff in pull request #3625: [GOBBLIN-1766] Define metric to measure lag from producing to consume…

umustafi commented on code in PR #3625:
URL: https://github.com/apache/gobblin/pull/3625#discussion_r1080587369


##########
gobblin-metrics-libs/gobblin-metrics-base/src/main/avro/GenericStoreChangeEvent.avsc:
##########
@@ -9,9 +9,14 @@
     "doc" : "Primary key for the store",
     "compliance" : "NONE"
   }, {
-    "name" : "timestamp",
+    "name" : "txId",

Review Comment:
   I want to rename this field to be more clear, this timestamp will be produceTimestamp specifically. I will update depending code in other places before deploying, is there still an issue with  incompatible schema change?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org