You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Valentin Kulichenko (JIRA)" <ji...@apache.org> on 2017/04/01 04:19:42 UTC

[jira] [Commented] (IGNITE-4896) OptimizedMarshaller should not failed on GridClientNodeBean serialization

    [ https://issues.apache.org/jira/browse/IGNITE-4896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952001#comment-15952001 ] 

Valentin Kulichenko commented on IGNITE-4896:
---------------------------------------------

[~kuaw26], I don't like that the change is made on the class descriptor level. It implements the protocol and writing some dummy strings there looks completely wrong. It's correct for the protocol to throw an exception if something can't be serialized, and it's up to upper-level code to catch is and write these strings or do whatever else is needed.

If there is something wrong with {{GridClientNodeBean}} in particular, let's fix it in its {{write/readExternal}} methods.

> OptimizedMarshaller should not failed on GridClientNodeBean serialization
> -------------------------------------------------------------------------
>
>                 Key: IGNITE-4896
>                 URL: https://issues.apache.org/jira/browse/IGNITE-4896
>             Project: Ignite
>          Issue Type: Bug
>          Components: clients
>    Affects Versions: 1.9
>            Reporter: Alexey Kuznetsov
>            Assignee: Valentin Kulichenko
>             Fix For: 2.0
>
>
> If node attributes contain some unknown for Optimized marshaller classes (not present in classnames.properties) it will failed to serialize them.
> I think it is better to skip such objects and print warning in node log and GridClient log.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)