You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/09 10:07:05 UTC
[GitHub] [arrow-datafusion] Dandandan opened a new pull request #301: Return error on OVER clause
Dandandan opened a new pull request #301:
URL: https://github.com/apache/arrow-datafusion/pull/301
# Which issue does this PR close?
Closes #300
# Rationale for this change
Currently we ignore OVER clauses, giving incorrect results (using normal aggregates).
```
select 1, SUM(x) OVER (PARTITION by x) from (select 1 as x union all select 2 as x) t;
+----------+--------+
| Int64(1) | SUM(x) |
+----------+--------+
| 1 | 3 |
+----------+--------+
```
# What changes are included in this PR?
Return an error.
# Are there any user-facing changes?
Return error on not supported over clause.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Dandandan merged pull request #301: Return error on OVER clause
Posted by GitBox <gi...@apache.org>.
Dandandan merged pull request #301:
URL: https://github.com/apache/arrow-datafusion/pull/301
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #301: Return error on OVER clause
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #301:
URL: https://github.com/apache/arrow-datafusion/pull/301#issuecomment-836648741
Thanks @Dandandan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #301: Return error on OVER clause
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #301:
URL: https://github.com/apache/arrow-datafusion/pull/301#issuecomment-835775310
# [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/301?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#301](https://codecov.io/gh/apache/arrow-datafusion/pull/301?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (404629f) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/d0a4552dcf07316acaa8ade7feabe5c9165f3a48?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d0a4552) will **increase** coverage by `0.00%`.
> The diff coverage is `88.88%`.
[](https://codecov.io/gh/apache/arrow-datafusion/pull/301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #301 +/- ##
=======================================
Coverage 76.07% 76.08%
=======================================
Files 140 140
Lines 23632 23646 +14
=======================================
+ Hits 17978 17990 +12
- Misses 5654 5656 +2
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-datafusion/pull/301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [datafusion/src/sql/planner.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9zcmMvc3FsL3BsYW5uZXIucnM=) | `83.64% <88.88%> (+0.02%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/301?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/301?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d0a4552...404629f](https://codecov.io/gh/apache/arrow-datafusion/pull/301?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org