You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/29 18:31:36 UTC

[GitHub] [spark] grundprinzip commented on pull request #38801: [SPARK-41317][CONNECT][PYTHON] Add basic support for DataFrameWriter

grundprinzip commented on PR #38801:
URL: https://github.com/apache/spark/pull/38801#issuecomment-1331114227

   > Overall look good to me.
   > 
   > 
   > 
   > This is based on the past scala and proto side writer API work so no big concerns. 
   > 
   > 
   > 
   > IIRC there were still some proto API level design comments that worth to take a look. I probably could re-visit that later after expression work.
   
   These comments were independent of this patch though? Because this patch was only Python. Just want to make sure if we missed something. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org