You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by yvsubhash <gi...@git.apache.org> on 2015/10/06 18:18:04 UTC
[GitHub] cloudstack pull request: BUG-ID CLOUDSTACK-8939
GitHub user yvsubhash opened a pull request:
https://github.com/apache/cloudstack/pull/914
BUG-ID CLOUDSTACK-8939
Fixing the error with snapshot size calculation in a vm with memory
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yvsubhash/cloudstack CLOUDSTACK-8939
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/914.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #914
----
commit 5fecae08d167727437b82c92e26a550ef29bd0b2
Author: subhash yedugundla <ve...@citrix.com>
Date: 2015-10-06T13:58:13Z
BUG-ID CLOUDSTACK-8939
Fixing the error with snapshot size calculation in a vm with memory
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: BUG-ID CLOUDSTACK-8939
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/914#issuecomment-216195564
@yvsubhash please rebase against latest master and push -f, update on status of your PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #914: BUG-ID CLOUDSTACK-8939
Posted by bvbharatk <gi...@git.apache.org>.
Github user bvbharatk commented on the issue:
https://github.com/apache/cloudstack/pull/914
### ACS CI BVT Run
**Sumarry:**
Build Number 167
Hypervisor xenserver
NetworkType Advanced
Passed=73
Failed=0
Skipped=3
_Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
**Failed tests:**
**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_deploy_vgpu_enabled_vm
**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_vpc_vpn.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_routers.py
test_reset_vm_on_reboot.py
test_snapshots.py
test_deploy_vms_with_varied_deploymentplanners.py
test_login.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #914: BUG-ID CLOUDSTACK-8939 VM Snapshot size with m...
Posted by sudhansu7 <gi...@git.apache.org>.
Github user sudhansu7 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/914#discussion_r90809764
--- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java ---
@@ -3206,25 +3206,33 @@ public long getVMSnapshotChainSize(final Connection conn, final VolumeObjectTO v
}
}
if (volumeTo.getVolumeType() == Volume.Type.ROOT) {
- final Map<VM, VM.Record> allVMs = VM.getAllRecords(conn);
- // add size of memory snapshot vdi
- if (allVMs != null && allVMs.size() > 0) {
- for (final VM vmr : allVMs.keySet()) {
- try {
- final String vName = vmr.getNameLabel(conn);
- if (vName != null && vName.contains(vmName) && vmr.getIsASnapshot(conn)) {
- final VDI memoryVDI = vmr.getSuspendVDI(conn);
- if (!isRefNull(memoryVDI)) {
- size = size + memoryVDI.getPhysicalUtilisation(conn);
- final VDI pMemoryVDI = memoryVDI.getParent(conn);
- if (!isRefNull(pMemoryVDI)) {
- size = size + pMemoryVDI.getPhysicalUtilisation(conn);
+ VM vm = getVM(conn, vmName);
--- End diff --
@yvsubhash getVm() raises CloudRuntimeException if Vm is not found.
Scenario:
Deploy a vm and ensure its in running state.
Take a VM snapshot ( either disk or disk + memory ) for VM.
After snapshot operation is sucessful , destroy the VM.
Observation :
VM destroy Fails with reason VM with name: i-2-7-VM does not exist.
SNapshot moves to Expunging state , and VM moves to stopped state.
Solution : Place your changes within a try.. catch block
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #914: BUG-ID CLOUDSTACK-8939 VM Snapshot size with m...
Posted by sudhansu7 <gi...@git.apache.org>.
Github user sudhansu7 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/914#discussion_r111375928
--- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java ---
@@ -3206,25 +3206,33 @@ public long getVMSnapshotChainSize(final Connection conn, final VolumeObjectTO v
}
}
if (volumeTo.getVolumeType() == Volume.Type.ROOT) {
- final Map<VM, VM.Record> allVMs = VM.getAllRecords(conn);
- // add size of memory snapshot vdi
- if (allVMs != null && allVMs.size() > 0) {
- for (final VM vmr : allVMs.keySet()) {
- try {
- final String vName = vmr.getNameLabel(conn);
- if (vName != null && vName.contains(vmName) && vmr.getIsASnapshot(conn)) {
- final VDI memoryVDI = vmr.getSuspendVDI(conn);
- if (!isRefNull(memoryVDI)) {
- size = size + memoryVDI.getPhysicalUtilisation(conn);
- final VDI pMemoryVDI = memoryVDI.getParent(conn);
- if (!isRefNull(pMemoryVDI)) {
- size = size + pMemoryVDI.getPhysicalUtilisation(conn);
+ VM vm = getVM(conn, vmName);
--- End diff --
LGTM for code change
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #914: BUG-ID CLOUDSTACK-8939 VM Snapshot size with memory i...
Posted by niteshsarda <gi...@git.apache.org>.
Github user niteshsarda commented on the issue:
https://github.com/apache/cloudstack/pull/914
I have tested this and **LGTM** for test.
Following are the test results :
**Before applying fix :**
[root@xenserver-jay ~]# xe vbd-list vm-name-label=i-2-120-VM empty=false params=vdi-uuid
vdi-uuid ( RO) : 674c2c07-954e-4fa0-943a-979a71748727
[root@xenserver-jay ~]# xe vdi-list params=physical-utilisation,sm-config,is-a-snapshot uuid=674c2c07-954e-4fa0-943a-979a71748727
is-a-snapshot ( RO) : false
physical-utilisation ( RO): 81256448
sm-config (MRO): host_OpaqueRef:a3c1c534-b5e3-6cb5-10af-b56dead63fc0: RW; vhd-parent: 1aac168d-22d2-4796-8669-48a3f4361dfc
[root@xenserver-jay ~]# xe vdi-list params=physical-utilisation,sm-config,is-a-snapshot uuid=1aac168d-22d2-4796-8669-48a3f4361dfc
is-a-snapshot ( RO) : false
physical-utilisation ( RO): 233251328
sm-config (MRO): vhd-blocks: eJxjYEAB7AykARFGPc1cN4UVJGqDAUYG5tZJF0ymbpi4bYUCAxPJ+nn2sDQLMGwTYzzI0OvAQob1AgIBip6BrAIrG0jWDAEAQmQNjA==; vhd-parent: 55943089-24fa-4fbe-a44e-e57fe9a080ed
[root@xenserver-jay ~]# xe vdi-list name-label=Suspend\ image params=all
uuid ( RO) : 105fbe1d-973b-4d8d-82e7-96246669a769
name-label ( RW): Suspend image
name-description ( RW): Suspend image
is-a-snapshot ( RO): true
snapshot-of ( RO): <not in database>
snapshots ( RO):
snapshot-time ( RO): 20170401T07:49:50Z
allowed-operations (SRO): forget; generate_config; update; resize; destroy; clone; copy; snapshot
current-operations (SRO):
sr-uuid ( RO): 99b84794-d0d6-46c6-fa42-07af5b423b8c
sr-name-label ( RO): d2fecabd-61cf-3458-a120-ea01a4f91c29
vbd-uuids (SRO):
crashdump-uuids (SRO):
virtual-size ( RO): 782237696
physical-utilisation ( RO): 6144
location ( RO): 105fbe1d-973b-4d8d-82e7-96246669a769
type ( RO): Suspend
sharable ( RO): false
read-only ( RO): false
storage-lock ( RO): false
managed ( RO): true
parent ( RO): <not in database>
missing ( RO): false
other-config (MRW): content_id: 842a46b4-bffd-70fb-b00a-47c39de8959b
xenstore-data (MRO):
sm-config (MRO): vhd-parent: 638118a6-5f85-4c35-9aa8-d19793a144a8
on-boot ( RW): persist
allow-caching ( RW): false
metadata-latest ( RO): false
metadata-of-pool ( RO): <not in database>
tags (SRW):
[root@xenserver-jay ~]# xe vdi-list uuid=638118a6-5f85-4c35-9aa8-d19793a144a8 params=all
uuid ( RO) : 638118a6-5f85-4c35-9aa8-d19793a144a8
name-label ( RW): base copy
name-description ( RW):
is-a-snapshot ( RO): false
snapshot-of ( RO): <not in database>
snapshots ( RO):
snapshot-time ( RO): 19700101T00:00:00Z
allowed-operations (SRO): forget; generate_config; update; resize; destroy; clone; copy; snapshot
current-operations (SRO):
sr-uuid ( RO): 99b84794-d0d6-46c6-fa42-07af5b423b8c
sr-name-label ( RO): d2fecabd-61cf-3458-a120-ea01a4f91c29
vbd-uuids (SRO):
crashdump-uuids (SRO):
virtual-size ( RO): 782237696
physical-utilisation ( RO): 548430336
location ( RO): 638118a6-5f85-4c35-9aa8-d19793a144a8
type ( RO): User
sharable ( RO): false
read-only ( RO): true
storage-lock ( RO): false
managed ( RO): false
parent ( RO): <not in database>
missing ( RO): false
other-config (MRW):
xenstore-data (MRO):
sm-config (MRO): vhd-blocks: eJz7/x8/+MGAAgD69CDZ
on-boot ( RW): persist
allow-caching ( RW): false
metadata-latest ( RO): false
metadata-of-pool ( RO): <not in database>
tags (SRW):
mysql> select * from cloud.usage_event where resource_name like "i-2-120-VM%" \G
*************************** 1. row ***************************
id: 84
type: VMSNAPSHOT.CREATE
account_id: 2
created: 2017-04-01 07:50:42
zone_id: 2
resource_id: 120
resource_name: i-2-120-VM_VS_20170401074841
offering_id: NULL
template_id: 120
size: 233272320
resource_type: NULL
processed: 0
virtual_size: NULL
**After applying fix :**
[root@xenserver-jay ~]# xe vbd-list vm-name-label=i-2-120-VM empty=false params=vdi-uuid
vdi-uuid ( RO) : 674c2c07-954e-4fa0-943a-979a71748727
[root@xenserver-jay ~]# xe vdi-list params=physical-utilisation,sm-config,is-a-snapshot uuid=674c2c07-954e-4fa0-943a-979a71748727
is-a-snapshot ( RO) : false
physical-utilisation ( RO): 4215296
sm-config (MRO): vhd-parent: 1aac168d-22d2-4796-8669-48a3f4361dfc; host_OpaqueRef:a3c1c534-b5e3-6cb5-10af-b56dead63fc0: RW
[root@xenserver-jay ~]# xe vdi-list params=physical-utilisation,sm-config,is-a-snapshot uuid=1aac168d-22d2-4796-8669-48a3f4361dfc
is-a-snapshot ( RO) : false
physical-utilisation ( RO): 258466304
sm-config (MRO): vhd-blocks: eJxjYEAB7AykARHFfZa5bgqrSNQGA4wMzK2TLphM3TBx2wqFBcwk65fZw9oswLBNjPEgQ68DCxnWCwhcUPQMZBVYOYFkzRAAAKErD5A=; vhd-parent: 55943089-24fa-4fbe-a44e-e57fe9a080ed
[root@xenserver-jay ~]# xe vdi-list name-label=Suspend\ image params=all
uuid ( RO) : e186191b-e3a6-40d8-9086-2cbca2f2f6c5
name-label ( RW): Suspend image
name-description ( RW): Suspend image
is-a-snapshot ( RO): true
snapshot-of ( RO): <not in database>
snapshots ( RO):
snapshot-time ( RO): 20170401T09:03:24Z
allowed-operations (SRO): forget; generate_config; update; resize; destroy; clone; copy; snapshot
current-operations (SRO):
sr-uuid ( RO): 99b84794-d0d6-46c6-fa42-07af5b423b8c
sr-name-label ( RO): d2fecabd-61cf-3458-a120-ea01a4f91c29
vbd-uuids (SRO):
crashdump-uuids (SRO):
virtual-size ( RO): 782237696
physical-utilisation ( RO): 6144
location ( RO): e186191b-e3a6-40d8-9086-2cbca2f2f6c5
type ( RO): Suspend
sharable ( RO): false
read-only ( RO): false
storage-lock ( RO): false
managed ( RO): true
parent ( RO): <not in database>
missing ( RO): false
other-config (MRW): content_id: 5dd927ff-af42-776e-5ba4-652344aaec84
xenstore-data (MRO):
sm-config (MRO): vhd-parent: 14b415ba-95bf-4fc0-b584-d6a8b0a97c6b
on-boot ( RW): persist
allow-caching ( RW): false
metadata-latest ( RO): false
metadata-of-pool ( RO): <not in database>
tags (SRW):
[root@xenserver-jay ~]# xe vdi-list uuid=14b415ba-95bf-4fc0-b584-d6a8b0a97c6b params=all
uuid ( RO) : 14b415ba-95bf-4fc0-b584-d6a8b0a97c6b
name-label ( RW): base copy
name-description ( RW):
is-a-snapshot ( RO): false
snapshot-of ( RO): <not in database>
snapshots ( RO):
snapshot-time ( RO): 19700101T00:00:00Z
allowed-operations (SRO): forget; generate_config; update; resize; destroy; clone; copy; snapshot
current-operations (SRO):
sr-uuid ( RO): 99b84794-d0d6-46c6-fa42-07af5b423b8c
sr-name-label ( RO): d2fecabd-61cf-3458-a120-ea01a4f91c29
vbd-uuids (SRO):
crashdump-uuids (SRO):
virtual-size ( RO): 782237696
physical-utilisation ( RO): 548430336
location ( RO): 14b415ba-95bf-4fc0-b584-d6a8b0a97c6b
type ( RO): User
sharable ( RO): false
read-only ( RO): true
storage-lock ( RO): false
managed ( RO): false
parent ( RO): <not in database>
missing ( RO): false
other-config (MRW):
xenstore-data (MRO):
sm-config (MRO): vhd-blocks: eJz7/x8/+MGAAgD69CDZ
on-boot ( RW): persist
allow-caching ( RW): false
metadata-latest ( RO): false
metadata-of-pool ( RO): <not in database>
tags (SRW):
select * from cloud.usage_event where resource_name like "i-2-120-VM%" \G
*************************** 1. row ***************************
id: 87
type: VMSNAPSHOT.CREATE
account_id: 2
created: 2017-04-01 09:04:52
zone_id: 2
resource_id: 120
resource_name: i-2-120-VM_VS_20170401090220
offering_id: NULL
template_id: 120
size: 775463895
resource_type: NULL
processed: 0
virtual_size: NULL
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: BUG-ID CLOUDSTACK-8939
Posted by bvbharatk <gi...@git.apache.org>.
Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/914
### ACS CI BVT Run
**Sumarry:**
Build Number 97
Hypervisor xenserver
NetworkType Advanced
Passed=73
Failed=0
Skipped=3
_Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
**Failed tests:**
**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_deploy_vgpu_enabled_vm
**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_vpc_vpn.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_routers.py
test_reset_vm_on_reboot.py
test_snapshots.py
test_deploy_vms_with_varied_deploymentplanners.py
test_login.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #914: BUG-ID CLOUDSTACK-8939 VM Snapshot size with memory i...
Posted by cloudmonger <gi...@git.apache.org>.
Github user cloudmonger commented on the issue:
https://github.com/apache/cloudstack/pull/914
### ACS CI BVT Run
**Sumarry:**
Build Number 433
Hypervisor xenserver
NetworkType Advanced
Passed=103
Failed=2
Skipped=7
_Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
**Failed tests:**
* test_non_contigiousvlan.py
* test_extendPhysicalNetworkVlan Failed
* test_routers_network_ops.py
* test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failed
**Skipped tests:**
test_01_test_vm_volume_snapshot
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm
**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #914: BUG-ID CLOUDSTACK-8939 VM Snapshot size with memory i...
Posted by yvsubhash <gi...@git.apache.org>.
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/914
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: BUG-ID CLOUDSTACK-8939
Posted by rodrigo93 <gi...@git.apache.org>.
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/914#issuecomment-172391340
@remibergsma The author seems to be inactive in github. His last public activity was on Oct 20, 2015...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: BUG-ID CLOUDSTACK-8939
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/914#issuecomment-145924406
@yvsubhash Thanks for the PR. Can you please change the title to be more descriptive?
Like: CLOUDSTACK-8939 Fixing snapshot size calculation
Or something like that.
Any tests for this (unit / integration)?
How was this tested?
How can we test it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #914: BUG-ID CLOUDSTACK-8939 VM Snapshot size with m...
Posted by yvsubhash <gi...@git.apache.org>.
Github user yvsubhash commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/914#discussion_r109123538
--- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java ---
@@ -3206,25 +3206,33 @@ public long getVMSnapshotChainSize(final Connection conn, final VolumeObjectTO v
}
}
if (volumeTo.getVolumeType() == Volume.Type.ROOT) {
- final Map<VM, VM.Record> allVMs = VM.getAllRecords(conn);
- // add size of memory snapshot vdi
- if (allVMs != null && allVMs.size() > 0) {
- for (final VM vmr : allVMs.keySet()) {
- try {
- final String vName = vmr.getNameLabel(conn);
- if (vName != null && vName.contains(vmName) && vmr.getIsASnapshot(conn)) {
- final VDI memoryVDI = vmr.getSuspendVDI(conn);
- if (!isRefNull(memoryVDI)) {
- size = size + memoryVDI.getPhysicalUtilisation(conn);
- final VDI pMemoryVDI = memoryVDI.getParent(conn);
- if (!isRefNull(pMemoryVDI)) {
- size = size + pMemoryVDI.getPhysicalUtilisation(conn);
+ VM vm = getVM(conn, vmName);
--- End diff --
@sudhansu7 exception needs to be caught at the callers otherwise it would end up setting zero size
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: BUG-ID CLOUDSTACK-8939
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/914#issuecomment-148940941
@yvsubhash Any update on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---