You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2023/11/02 09:44:25 UTC
(tomcat) branch main updated: Update BND to 7.0.0
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new aadc08fc0a Update BND to 7.0.0
aadc08fc0a is described below
commit aadc08fc0a5b607af85d3433af68ea64d913eb99
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Thu Nov 2 09:44:13 2023 +0000
Update BND to 7.0.0
---
build.properties.default | 4 ++--
webapps/docs/changelog.xml | 3 +++
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/build.properties.default b/build.properties.default
index c352c41151..11f2966815 100644
--- a/build.properties.default
+++ b/build.properties.default
@@ -281,12 +281,12 @@ spotbugs.loc=${base-maven.loc}/com/github/spotbugs/spotbugs/${spotbugs.version}/
# ----- bnd, version 6.3.0 or later -----
# ----- provides OSGI metadata for JARs -----
-bnd.version=6.4.1
+bnd.version=7.0.0
# checksums for biz.aQute.bnd-6.4.1.jar
bnd.checksum.enabled=true
bnd.checksum.algorithm=MD5|SHA-1
-bnd.checksum.value=78a21ab586850832a78342b8d0a99f64|91f28d145a1284f270a3d2cdc886863460c89833
+bnd.checksum.value=654776477ed942fc53f581fec66e253a|9937f6b7528628964a4ab8e50ba6b964d0310bce
bnd.home=${base.path}/bnd-${bnd.version}
bnd.jar=${bnd.home}/biz.aQute.bnd-${bnd.version}.jar
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index a3d79b6b3c..e1b965e700 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -202,6 +202,9 @@
<update>
Update SpotBugs to 4.8.0. (markt)
</update>
+ <update>
+ Update BDN to 7.0.0. (markt)
+ </update>
</changelog>
</subsection>
</section>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: (tomcat) branch main updated: Update BND to 7.0.0
Posted by Michael Osipov <mi...@apache.org>.
On 2023/11/05 10:10:20 Mark Thomas wrote:
> On 03/11/2023 15:07, Michael Osipov wrote:
> > On 2023/11/03 11:57:56 Mark Thomas wrote:
> >> On 03/11/2023 09:26, Michael Osipov wrote:
> >>> This change now completely missed to enfore Java 17 on < 11 and opt-in to skip the required during tests I have introduced last month.
> >>
> >> Tomcat 11.0.x has required Java 21 to build for around 6 months. The BND
> >> requirement for Java 17 has no impact on the build. Did you mean to
> >> reference one of the older branches?
> >
> > Yes, as written < Tomcat 11. Tomcat 9 failed for me with a cryptic "Java class version..." that is why I have introduced the ant target to have a clear message.
>
> Ah. You replied to the commit message for 11.0.x and the meaning of < 11
> was not clear. I thought it was somehow related to a Java version.
That was a general remark. True, it does not apply to 11, but to Tomcat 10 and below.
> It looks like < Tomcat 11 isn't correct anyway. I only see the option to
> skip the build version check in 9.0.x and 8.5.x.
>
> If we can skip the OSGi task (haven't tested this at all) if the
> skip.build.java.version is set then that should work. We should also add
> a fail the build with a useful error message if someone tries "ant
> release" with this property set.
Yes, please. The build should be as expressive as possible telling why it failed since we know upfront that specific configs will fail.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: (tomcat) branch main updated: Update BND to 7.0.0
Posted by Michael Osipov <mi...@apache.org>.
On 2023/11/05 14:50:11 Mark Thomas wrote:
> On 05/11/2023 10:10, Mark Thomas wrote:
> > On 03/11/2023 15:07, Michael Osipov wrote:
> >> On 2023/11/03 11:57:56 Mark Thomas wrote:
> >>> On 03/11/2023 09:26, Michael Osipov wrote:
> >>>> This change now completely missed to enfore Java 17 on < 11 and
> >>>> opt-in to skip the required during tests I have introduced last month.
> >>>
> >>> Tomcat 11.0.x has required Java 21 to build for around 6 months. The BND
> >>> requirement for Java 17 has no impact on the build. Did you mean to
> >>> reference one of the older branches?
> >>
> >> Yes, as written < Tomcat 11. Tomcat 9 failed for me with a cryptic
> >> "Java class version..." that is why I have introduced the ant target
> >> to have a clear message.
> >
> > Ah. You replied to the commit message for 11.0.x and the meaning of < 11
> > was not clear. I thought it was somehow related to a Java version.
> >
> > It looks like < Tomcat 11 isn't correct anyway. I only see the option to
> > skip the build version check in 9.0.x and 8.5.x.
> >
> > If we can skip the OSGi task (haven't tested this at all) if the
> > skip.build.java.version is set then that should work. We should also add
> > a fail the build with a useful error message if someone tries "ant
> > release" with this property set.
>
> Hmm. You still have to build with Java 17 but it is possible to add a
> few further hacks to build.xml so the tests will still run with Java 8.
>
> As the number of hacks increases, I become less convinced that it is
> worth maintaining the ability to test with Java 8. I know that is the
> minimum version but is the only reason to test on Java 8 that we don't
> trust javac to honor the release target correctly? At this point, I see
> no reason not to trust javac.
It is not the the output of javac, but the runtime behavior of Java 8/11/17 might be different. If you cannot test with 8, but you claim to run on 8+ then it is a lie.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: (tomcat) branch main updated: Update BND to 7.0.0
Posted by Mark Thomas <ma...@apache.org>.
On 05/11/2023 10:10, Mark Thomas wrote:
> On 03/11/2023 15:07, Michael Osipov wrote:
>> On 2023/11/03 11:57:56 Mark Thomas wrote:
>>> On 03/11/2023 09:26, Michael Osipov wrote:
>>>> This change now completely missed to enfore Java 17 on < 11 and
>>>> opt-in to skip the required during tests I have introduced last month.
>>>
>>> Tomcat 11.0.x has required Java 21 to build for around 6 months. The BND
>>> requirement for Java 17 has no impact on the build. Did you mean to
>>> reference one of the older branches?
>>
>> Yes, as written < Tomcat 11. Tomcat 9 failed for me with a cryptic
>> "Java class version..." that is why I have introduced the ant target
>> to have a clear message.
>
> Ah. You replied to the commit message for 11.0.x and the meaning of < 11
> was not clear. I thought it was somehow related to a Java version.
>
> It looks like < Tomcat 11 isn't correct anyway. I only see the option to
> skip the build version check in 9.0.x and 8.5.x.
>
> If we can skip the OSGi task (haven't tested this at all) if the
> skip.build.java.version is set then that should work. We should also add
> a fail the build with a useful error message if someone tries "ant
> release" with this property set.
Hmm. You still have to build with Java 17 but it is possible to add a
few further hacks to build.xml so the tests will still run with Java 8.
As the number of hacks increases, I become less convinced that it is
worth maintaining the ability to test with Java 8. I know that is the
minimum version but is the only reason to test on Java 8 that we don't
trust javac to honor the release target correctly? At this point, I see
no reason not to trust javac.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: (tomcat) branch main updated: Update BND to 7.0.0
Posted by Mark Thomas <ma...@apache.org>.
On 03/11/2023 15:07, Michael Osipov wrote:
> On 2023/11/03 11:57:56 Mark Thomas wrote:
>> On 03/11/2023 09:26, Michael Osipov wrote:
>>> This change now completely missed to enfore Java 17 on < 11 and opt-in to skip the required during tests I have introduced last month.
>>
>> Tomcat 11.0.x has required Java 21 to build for around 6 months. The BND
>> requirement for Java 17 has no impact on the build. Did you mean to
>> reference one of the older branches?
>
> Yes, as written < Tomcat 11. Tomcat 9 failed for me with a cryptic "Java class version..." that is why I have introduced the ant target to have a clear message.
Ah. You replied to the commit message for 11.0.x and the meaning of < 11
was not clear. I thought it was somehow related to a Java version.
It looks like < Tomcat 11 isn't correct anyway. I only see the option to
skip the build version check in 9.0.x and 8.5.x.
If we can skip the OSGi task (haven't tested this at all) if the
skip.build.java.version is set then that should work. We should also add
a fail the build with a useful error message if someone tries "ant
release" with this property set.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: (tomcat) branch main updated: Update BND to 7.0.0
Posted by Michael Osipov <mi...@apache.org>.
On 2023/11/03 11:57:56 Mark Thomas wrote:
> On 03/11/2023 09:26, Michael Osipov wrote:
> > This change now completely missed to enfore Java 17 on < 11 and opt-in to skip the required during tests I have introduced last month.
>
> Tomcat 11.0.x has required Java 21 to build for around 6 months. The BND
> requirement for Java 17 has no impact on the build. Did you mean to
> reference one of the older branches?
Yes, as written < Tomcat 11. Tomcat 9 failed for me with a cryptic "Java class version..." that is why I have introduced the ant target to have a clear message.
M
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: (tomcat) branch main updated: Update BND to 7.0.0
Posted by Mark Thomas <ma...@apache.org>.
On 03/11/2023 09:26, Michael Osipov wrote:
> This change now completely missed to enfore Java 17 on < 11 and opt-in to skip the required during tests I have introduced last month.
Tomcat 11.0.x has required Java 21 to build for around 6 months. The BND
requirement for Java 17 has no impact on the build. Did you mean to
reference one of the older branches?
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: (tomcat) branch main updated: Update BND to 7.0.0
Posted by Michael Osipov <mi...@apache.org>.
This change now completely missed to enfore Java 17 on < 11 and opt-in to skip the required during tests I have introduced last month.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org