You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kudu.apache.org by "David Ribeiro Alves (Code Review)" <ge...@ip-10-146-233-104.ec2.internal> on 2016/02/04 07:51:38 UTC

[kudu-CR](branch-0.7.0) [c++ client] - Expose the schema being scanned in KuduScanBatch

Hello Adar Dembo, Kudu Jenkins,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/2037

to review the following change.

Change subject: [c++ client] - Expose the schema being scanned in KuduScanBatch
......................................................................

[c++ client] - Expose the schema being scanned in KuduScanBatch

This exposes the schema being scanned in the KuduScanBatch and KuduScanBatch::RowPtr
allowing to pass pointer/references to these around when in use without an accompanying
schema, which was hard to infer in any case since the scanner projection is set with
just column names.

Note that this is just exposing the schema information that was already there, just
in KuduSchema form (vs. the internal Schema) which is more suited for user consumption.

Change-Id: I79dde3ece27c5122fba9c69c70ef9e25d641c1e1
Reviewed-on: http://gerrit.cloudera.org:8080/2020
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/client/client.cc
M src/kudu/client/scan_batch.cc
M src/kudu/client/scan_batch.h
M src/kudu/client/scanner-internal.cc
M src/kudu/client/scanner-internal.h
M src/kudu/client/schema.h
M src/kudu/tools/ts-cli.cc
7 files changed, 57 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/2037/1
-- 
To view, visit http://gerrit.cloudera.org:8080/2037
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I79dde3ece27c5122fba9c69c70ef9e25d641c1e1
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-0.7.0
Gerrit-Owner: David Ribeiro Alves <da...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins