[GitHub] clintropolis edited a comment on issue #6125: Fix appenderator_realtime creating shards bigger by 1 than maxRowsPerSegment

[GitBox <gi...@apache.org>]

clintropolis edited a comment on issue #6125: Fix appenderator_realtime creating shards bigger by 1 than maxRowsPerSegment
URL: https://github.com/apache/incubator-druid/pull/6125#issuecomment-411539025
 
 
   Neat, I also noticed this while working on #6129, but then noticed [this comment in a kafka indexing task test](https://github.com/apache/incubator-druid/blob/master/extensions-core/kafka-indexing-service/src/test/java/io/druid/indexing/kafka/KafkaIndexTaskTest.java#L478) suggesting it's the expected behavior, at least for kafka indexing. We probably should clarify if the intention of `maxRowsPerSegment`, i.e. should reaching it handoff immediately as one might expect, or should it continue accumulating rows in other segments until one goes over the threshold, as matching the behavior of this patch in the kafka indexing task would cause that test to fail. I don't feel strongly either way, but I do think the current behavior is probably surprising to most people.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org