You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shenyu.apache.org by hutaishi <hu...@qq.com.INVALID> on 2022/03/22 00:40:42 UTC
回复： Proper handling of the shenyu-agent module.
Hi Willem Jiang:
There is a logging plugin under the agent module. Since we consider removing the agent module, we reconstruct the logging plugin under the agent module into Shenyu plugins.
The metrics under the agent module are handled the same way.
About tracing, Encourage developers to provide plugins to upstream like SkyWalking, ZipKin and OpenTelemetry to implement the tracing features.
metrics and logs belong to refactoring. No other functional changes have been made, but an implementation method has been changed.
The community will improve observability step by step.
Thank you very much.
------------------ 原始邮件 ------------------
发件人: "dev" <willem.jiang@gmail.com>;
发送时间: 2022年3月22日(星期二) 上午8:11
收件人: "dev"<dev@shenyu.apache.org>;
主题: Re: Proper handling of the shenyu-agent module.
It is hard for me to understand the whole story just by going through
the github issue and this mail.
Could you add more context about it?
BTW, if we just want to send the message to the RocketMQ cluster, I
think we can provide a more general way to send messages through JMS
API.
Willem Jiang
Twitter: willemjiang
Weibo: 姜宁willem
On Mon, Mar 21, 2022 at 11:41 AM hutaishi <hutaishi@qq.com.invalid> wrote:
>
> Hi Community:
> &nbsp;&nbsp;&nbsp;&nbsp; At the last meeting, we discussed the proper handling of agent modules.
> I removed the agent login module and added a logging rocketmq plug-in module.
> It belongs to refactoring type. Access logs（Include error log） can be recorded and sent asynchronously to the rocketmq cluster.
>
>
> pr:https://github.com/apache/incubator-shenyu/pull/3073
> Please review the code so that I can improve it.
>
> think.
回复： Proper handling of the shenyu-agent module.
Posted by hutaishi <hu...@qq.com.INVALID>.
Hi Willem，xiaoyu
Thank you for your reply and attention.
I have placed a meeting email link in issue and pr. everyone can view the email content and learn more about it. If there is anything unclear, you are welcome to communicate at any time.
issue: https://github.com/apache/incubator-shenyu/issues/3064
pr:https://github.com/apache/incubator-shenyu/pull/3073
mail link: https://lists.apache.org/thread/ow8o0hkym6p72gsoxxk0pyk895yk4wzv
think you.
------------------ 原始邮件 ------------------
发件人: "dev" <xiaoyu@apache.org>;
发送时间: 2022年3月22日(星期二) 上午10:54
收件人: "dev"<dev@shenyu.apache.org>;
主题: Re: Proper handling of the shenyu-agent module.
Hi Willem
Thank you for your enthusiastic reply and help.
His name wu ming participated in the conference[1].
as a participant in contributing agent logging rocketMQ[2]，
Because of the discussion at the meeting to remove the agent module.
So regarding logging rocketMQ in agent,
We decided to use shenyu's plugin ecosystem to refactor.
hi, hutaishi, Can you add a note in the pr with a link to the
conference so more people can learn about the backstory?
[1]: https://lists.apache.org/thread/ow8o0hkym6p72gsoxxk0pyk895yk4wzv
[2] https://github.com/apache/incubator-shenyu/pull/2887
Willem Jiang <willem.jiang@gmail.com> 于2022年3月22日周二 09:48写道：
>
> Please add this background information and meeting minis link into the
> github issue which lead to the PR，
> it can save us lots of time for the average person who doesn't know
> the background story.
>
>
> Willem Jiang
>
> Twitter: willemjiang
> Weibo: 姜宁willem
>
> On Tue, Mar 22, 2022 at 8:41 AM hutaishi <hutaishi@qq.com.invalid> wrote:
> >
> > Hi Willem Jiang:
> > &nbsp;&nbsp;&nbsp; There is a logging plugin under the agent module. Since we consider removing the agent module, we reconstruct the logging plugin under the agent module into Shenyu plugins.
> > &nbsp;&nbsp;&nbsp; The metrics under the agent module are handled the same way.
> > &nbsp;&nbsp;&nbsp; About tracing, Encourage developers to provide plugins to upstream like SkyWalking, ZipKin and OpenTelemetry to implement the tracing features.
> > &nbsp;&nbsp; metrics and logs belong to refactoring.&nbsp; No other functional changes have been made, but an implementation method has been changed.
> > &nbsp;&nbsp; The community will improve observability step by step.
> > &nbsp;&nbsp; Thank you very much.
> >
> >
> >
> > &nbsp;&nbsp;
> >
> >
> >
> >
> >
> > ------------------&nbsp;原始邮件&nbsp;------------------
> > 发件人: "dev" <willem.jiang@gmail.com&gt;;
> > 发送时间:&nbsp;2022年3月22日(星期二) 上午8:11
> > 收件人:&nbsp;"dev"<dev@shenyu.apache.org&gt;;
> >
> > 主题:&nbsp;Re: Proper handling of the shenyu-agent module.
> >
> >
> >
> > It is hard for me to understand the whole story just by going through
> > the github issue and this mail.
> > Could you add more context about it?
> > BTW, if we just want to send the message to the RocketMQ cluster, I
> > think we can provide a more general way to send messages through JMS
> > API.
> >
> > Willem Jiang
> >
> > Twitter: willemjiang
> > Weibo: 姜宁willem
> >
> > On Mon, Mar 21, 2022 at 11:41 AM hutaishi <hutaishi@qq.com.invalid&gt; wrote:
> > &gt;
> > &gt; Hi Community:
> > &gt; &amp;nbsp;&amp;nbsp;&amp;nbsp;&amp;nbsp; At the last meeting, we discussed the proper handling of agent modules.
> > &gt; I removed the agent login module and added a logging rocketmq plug-in module.
> > &gt; It belongs to refactoring type. Access logs（Include error log） can be recorded and sent asynchronously to the rocketmq cluster.
> > &gt;
> > &gt;
> > &gt; pr:https://github.com/apache/incubator-shenyu/pull/3073
> > &gt; Please review the code so that I can improve it.
> > &gt;
> > &gt; think.
Re: Proper handling of the shenyu-agent module.
Posted by XiaoYu <xi...@apache.org>.
Hi Willem
Thank you for your enthusiastic reply and help.
His name wu ming participated in the conference[1].
as a participant in contributing agent logging rocketMQ[2]，
Because of the discussion at the meeting to remove the agent module.
So regarding logging rocketMQ in agent,
We decided to use shenyu's plugin ecosystem to refactor.
hi, hutaishi, Can you add a note in the pr with a link to the
conference so more people can learn about the backstory?
[1]: https://lists.apache.org/thread/ow8o0hkym6p72gsoxxk0pyk895yk4wzv
[2] https://github.com/apache/incubator-shenyu/pull/2887
Willem Jiang <wi...@gmail.com> 于2022年3月22日周二 09:48写道：
>
> Please add this background information and meeting minis link into the
> github issue which lead to the PR，
> it can save us lots of time for the average person who doesn't know
> the background story.
>
>
> Willem Jiang
>
> Twitter: willemjiang
> Weibo: 姜宁willem
>
> On Tue, Mar 22, 2022 at 8:41 AM hutaishi <hu...@qq.com.invalid> wrote:
> >
> > Hi Willem Jiang:
> > There is a logging plugin under the agent module. Since we consider removing the agent module, we reconstruct the logging plugin under the agent module into Shenyu plugins.
> > The metrics under the agent module are handled the same way.
> > About tracing, Encourage developers to provide plugins to upstream like SkyWalking, ZipKin and OpenTelemetry to implement the tracing features.
> > metrics and logs belong to refactoring. No other functional changes have been made, but an implementation method has been changed.
> > The community will improve observability step by step.
> > Thank you very much.
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > ------------------ 原始邮件 ------------------
> > 发件人: "dev" <willem.jiang@gmail.com>;
> > 发送时间: 2022年3月22日(星期二) 上午8:11
> > 收件人: "dev"<dev@shenyu.apache.org>;
> >
> > 主题: Re: Proper handling of the shenyu-agent module.
> >
> >
> >
> > It is hard for me to understand the whole story just by going through
> > the github issue and this mail.
> > Could you add more context about it?
> > BTW, if we just want to send the message to the RocketMQ cluster, I
> > think we can provide a more general way to send messages through JMS
> > API.
> >
> > Willem Jiang
> >
> > Twitter: willemjiang
> > Weibo: 姜宁willem
> >
> > On Mon, Mar 21, 2022 at 11:41 AM hutaishi <hutaishi@qq.com.invalid> wrote:
> > >
> > > Hi Community:
> > > &nbsp;&nbsp;&nbsp;&nbsp; At the last meeting, we discussed the proper handling of agent modules.
> > > I removed the agent login module and added a logging rocketmq plug-in module.
> > > It belongs to refactoring type. Access logs（Include error log） can be recorded and sent asynchronously to the rocketmq cluster.
> > >
> > >
> > > pr:https://github.com/apache/incubator-shenyu/pull/3073
> > > Please review the code so that I can improve it.
> > >
> > > think.
Re: Proper handling of the shenyu-agent module.
Posted by Willem Jiang <wi...@gmail.com>.
Please add this background information and meeting minis link into the
github issue which lead to the PR，
it can save us lots of time for the average person who doesn't know
the background story.
Willem Jiang
Twitter: willemjiang
Weibo: 姜宁willem
On Tue, Mar 22, 2022 at 8:41 AM hutaishi <hu...@qq.com.invalid> wrote:
>
> Hi Willem Jiang:
> There is a logging plugin under the agent module. Since we consider removing the agent module, we reconstruct the logging plugin under the agent module into Shenyu plugins.
> The metrics under the agent module are handled the same way.
> About tracing, Encourage developers to provide plugins to upstream like SkyWalking, ZipKin and OpenTelemetry to implement the tracing features.
> metrics and logs belong to refactoring. No other functional changes have been made, but an implementation method has been changed.
> The community will improve observability step by step.
> Thank you very much.
>
>
>
>
>
>
>
>
>
> ------------------ 原始邮件 ------------------
> 发件人: "dev" <willem.jiang@gmail.com>;
> 发送时间: 2022年3月22日(星期二) 上午8:11
> 收件人: "dev"<dev@shenyu.apache.org>;
>
> 主题: Re: Proper handling of the shenyu-agent module.
>
>
>
> It is hard for me to understand the whole story just by going through
> the github issue and this mail.
> Could you add more context about it?
> BTW, if we just want to send the message to the RocketMQ cluster, I
> think we can provide a more general way to send messages through JMS
> API.
>
> Willem Jiang
>
> Twitter: willemjiang
> Weibo: 姜宁willem
>
> On Mon, Mar 21, 2022 at 11:41 AM hutaishi <hutaishi@qq.com.invalid> wrote:
> >
> > Hi Community:
> > &nbsp;&nbsp;&nbsp;&nbsp; At the last meeting, we discussed the proper handling of agent modules.
> > I removed the agent login module and added a logging rocketmq plug-in module.
> > It belongs to refactoring type. Access logs（Include error log） can be recorded and sent asynchronously to the rocketmq cluster.
> >
> >
> > pr:https://github.com/apache/incubator-shenyu/pull/3073
> > Please review the code so that I can improve it.
> >
> > think.