You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "zfoobar (via GitHub)" <gi...@apache.org> on 2023/04/09 02:53:48 UTC
[GitHub] [arrow] zfoobar opened a new pull request, #34991: See issue: #34987 - user requests Truthy/Falsey for boolean scalars.
zfoobar opened a new pull request, #34991:
URL: https://github.com/apache/arrow/pull/34991
added __bool__ implementation to provide Truthy/Falsey for boolean scalars in pyarrow they were tested locally, waiting for ci
the user will be exposed to truthy/falsey for True/False inputs respectively
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
### What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
### Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
### Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please uncomment the line below and explain which changes are breaking.
-->
<!-- **This PR includes breaking changes to public APIs.** -->
<!--
Please uncomment the line below (and provide explanation) if the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld). We use this to highlight fixes to issues that may affect users without their knowledge. For this reason, fixing bugs that cause errors don't count, since those are usually obvious.
-->
<!-- **This PR contains a "Critical Fix".** -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34991: GH-34987: [PYTHON] Truthy/Falsy for boolean scalars.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34991:
URL: https://github.com/apache/arrow/pull/34991#issuecomment-1501027436
:warning: GitHub issue #34987 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] randolf-scholz commented on pull request #34991: GH-34987: [PYTHON] Truthy/Falsy for boolean scalars.
Posted by "randolf-scholz (via GitHub)" <gi...@apache.org>.
randolf-scholz commented on PR #34991:
URL: https://github.com/apache/arrow/pull/34991#issuecomment-1501087874
Following my https://github.com/apache/arrow/issues/34987#issuecomment-1501083185, I think it should be:
```python
def __bool__(self) -> bool:
if self.is_valid:
return self.as_py()
raise TypeError("Boolean value of null is ambiguous.")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34991: See issue: #34987 - user requests Truthy/Falsey for boolean scalars.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34991:
URL: https://github.com/apache/arrow/pull/34991#issuecomment-1501025903
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zfoobar commented on pull request #34991: GH-34987: [PYTHON] Truthy/Falsy for boolean scalars.
Posted by "zfoobar (via GitHub)" <gi...@apache.org>.
zfoobar commented on PR #34991:
URL: https://github.com/apache/arrow/pull/34991#issuecomment-1501120274
Good move. I have to see why it’s failing the macos runner as wellSent from my iPhoneOn Apr 9, 2023, at 2:40 AM, Randolf Scholz ***@***.***> wrote:
Following my #34987 (comment), I think it should be:
def __bool__(self) -> bool:
if self.is_valid:
return self.as_py()
raise TypeError("Boolean value of null is ambiguous.")
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zfoobar commented on pull request #34991: GH-34987: [PYTHON] Truthy/Falsy for boolean scalars.
Posted by "zfoobar (via GitHub)" <gi...@apache.org>.
zfoobar commented on PR #34991:
URL: https://github.com/apache/arrow/pull/34991#issuecomment-1501195370
Got some great insight from Randolf. I wrote up a unit test for this, currently testing in fork.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zfoobar closed pull request #34991: GH-34987: [PYTHON] Truthy/Falsy for boolean scalars.
Posted by "zfoobar (via GitHub)" <gi...@apache.org>.
zfoobar closed pull request #34991: GH-34987: [PYTHON] Truthy/Falsy for boolean scalars.
URL: https://github.com/apache/arrow/pull/34991
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] randolf-scholz commented on pull request #34991: GH-34987: [PYTHON] Truthy/Falsy for boolean scalars.
Posted by "randolf-scholz (via GitHub)" <gi...@apache.org>.
randolf-scholz commented on PR #34991:
URL: https://github.com/apache/arrow/pull/34991#issuecomment-1501125624
Possible Unit-Test:
```python
import pyarrow as pa
import pytest
def test_BooleanScalar__bool__():
t = pa.scalar(True, type=pa.bool_())
f = pa.scalar(False, type=pa.bool_())
m = pa.scalar(None, type=pa.bool_())
assert bool(t) is True
assert bool(f) is False
with pytest.raises(TypeError):
bool(m)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34991: GH-34987: [PYTHON] Truthy/Falsy for boolean scalars.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34991:
URL: https://github.com/apache/arrow/pull/34991#issuecomment-1501027433
* Closes: #34987
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] randolf-scholz commented on pull request #34991: GH-34987: [PYTHON] Truthy/Falsy for boolean scalars.
Posted by "randolf-scholz (via GitHub)" <gi...@apache.org>.
randolf-scholz commented on PR #34991:
URL: https://github.com/apache/arrow/pull/34991#issuecomment-1501081332
I think it should just be `return self.as_py()`, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org