You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by "Hyrum K. Wright" <hy...@mail.utexas.edu> on 2008/01/14 23:09:32 UTC
Re: svn commit: r28908 - trunk/subversion/bindings/javahl/native
hwright@tigris.org wrote:
> Author: hwright
> Date: Mon Jan 14 15:08:22 2008
> New Revision: 28908
>
> Log:
> Followup to r28902: Get JavaHL building again.
>
> * subversion/bindings/javahl/native/SVNClient.cpp
> (doSwitch, update): Use FALSE for the depth_is_sticky parameter of the
> underlying C API.
This fixes the build, but would it be useful to expose this to the Java API?
> Modified:
> trunk/subversion/bindings/javahl/native/SVNClient.cpp
>
> Modified: trunk/subversion/bindings/javahl/native/SVNClient.cpp
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/bindings/javahl/native/SVNClient.cpp?pathrev=28908&r1=28907&r2=28908
> ==============================================================================
> --- trunk/subversion/bindings/javahl/native/SVNClient.cpp (original)
> +++ trunk/subversion/bindings/javahl/native/SVNClient.cpp Mon Jan 14 15:08:22 2008
> @@ -353,6 +353,7 @@
> SVN_JNI_ERR(svn_client_update3(&revs, array,
> revision.revision(),
> depth,
> + FALSE /* depth_is_sticky */,
> ignoreExternals,
> allowUnverObstructions,
> ctx, requestPool.pool()),
> @@ -545,6 +546,7 @@
> pegRevision.revision(),
> revision.revision(),
> depth,
> + FALSE /* depth_is_sticky */,
> ignoreExternals,
> allowUnverObstructions,
> ctx,
Re: svn commit: r28908 - trunk/subversion/bindings/javahl/native
Posted by "C. Michael Pilato" <cm...@collab.net>.
Mark Phippard wrote:
> On Jan 15, 2008 9:24 AM, Hyrum K. Wright <hy...@mail.utexas.edu> wrote:
>>>> This fixes the build, but would it be useful to expose this to the
>>>> Java API?
>>> Only if you want to support the creation of sparse directories through
>>> the Java API. (That is to say, "yes pls omg!!")
>> Sounds reasonable. r28910.
>
> Thanks Hyrum.
>
> So how does this new feature manifest itself. If I am providing a UI
> for update, I have a dialog where they can specify the depth of the
> update. Then it sounds like I should provide a check box that says
> you want to set the WC to the specified depth? Except in 1.5 it
> sounds like this will only allow you to extend the depth of the WC
> right?
Correct.
> We are not going to add support for making the WC more shallow.
Not unless it comes super-cheap and in the next few days. I don't know of
anyone targeting this for 1.5.
So, your dialog could be smart enough to check the recorded depth of the
update target and unset-and-grey-out that checkbox whenever the user has
selected an update operational depth > that recorded depth.
--
C. Michael Pilato <cm...@collab.net>
CollabNet <> www.collab.net <> Distributed Development On Demand
Re: svn commit: r28908 - trunk/subversion/bindings/javahl/native
Posted by Mark Phippard <ma...@gmail.com>.
On Jan 15, 2008 9:24 AM, Hyrum K. Wright <hy...@mail.utexas.edu> wrote:
> >> This fixes the build, but would it be useful to expose this to the
> >> Java API?
> >
> > Only if you want to support the creation of sparse directories through
> > the Java API. (That is to say, "yes pls omg!!")
>
> Sounds reasonable. r28910.
Thanks Hyrum.
So how does this new feature manifest itself. If I am providing a UI
for update, I have a dialog where they can specify the depth of the
update. Then it sounds like I should provide a check box that says
you want to set the WC to the specified depth? Except in 1.5 it
sounds like this will only allow you to extend the depth of the WC
right? We are not going to add support for making the WC more
shallow.
--
Thanks
Mark Phippard
http://markphip.blogspot.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r28908 - trunk/subversion/bindings/javahl/native
Posted by "Hyrum K. Wright" <hy...@mail.utexas.edu>.
C. Michael Pilato wrote:
> Hyrum K. Wright wrote:
>> hwright@tigris.org wrote:
>>> Author: hwright
>>> Date: Mon Jan 14 15:08:22 2008
>>> New Revision: 28908
>>>
>>> Log:
>>> Followup to r28902: Get JavaHL building again.
>>>
>>> * subversion/bindings/javahl/native/SVNClient.cpp
>>> (doSwitch, update): Use FALSE for the depth_is_sticky parameter of the
>>> underlying C API.
>>
>> This fixes the build, but would it be useful to expose this to the
>> Java API?
>
> Only if you want to support the creation of sparse directories through
> the Java API. (That is to say, "yes pls omg!!")
Sounds reasonable. r28910.
-Hyrum
Re: svn commit: r28908 - trunk/subversion/bindings/javahl/native
Posted by "C. Michael Pilato" <cm...@collab.net>.
Hyrum K. Wright wrote:
> hwright@tigris.org wrote:
>> Author: hwright
>> Date: Mon Jan 14 15:08:22 2008
>> New Revision: 28908
>>
>> Log:
>> Followup to r28902: Get JavaHL building again.
>>
>> * subversion/bindings/javahl/native/SVNClient.cpp
>> (doSwitch, update): Use FALSE for the depth_is_sticky parameter of the
>> underlying C API.
>
> This fixes the build, but would it be useful to expose this to the Java API?
Only if you want to support the creation of sparse directories through the
Java API. (That is to say, "yes pls omg!!")
--
C. Michael Pilato <cm...@collab.net>
CollabNet <> www.collab.net <> Distributed Development On Demand