You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@whimsical.apache.org by ru...@apache.org on 2017/09/20 00:01:51 UTC
[whimsy] branch agenda_on_vue updated: eliminate warnings
This is an automated email from the ASF dual-hosted git repository.
rubys pushed a commit to branch agenda_on_vue
in repository https://gitbox.apache.org/repos/asf/whimsy.git
The following commit(s) were added to refs/heads/agenda_on_vue by this push:
new f556856 eliminate warnings
f556856 is described below
commit f556856cb744e994cd5cc6f4e26804efbcb02b91
Author: Sam Ruby <ru...@intertwingly.net>
AuthorDate: Tue Sep 19 20:01:41 2017 -0400
eliminate warnings
---
www/board/agenda/views/buttons/post.js.rb | 4 ++--
www/board/agenda/views/buttons/publish-minutes.js.rb | 6 +++---
www/board/agenda/views/pages/comments.js.rb | 4 ----
3 files changed, 5 insertions(+), 9 deletions(-)
diff --git a/www/board/agenda/views/buttons/post.js.rb b/www/board/agenda/views/buttons/post.js.rb
index 22824f4..c484af5 100644
--- a/www/board/agenda/views/buttons/post.js.rb
+++ b/www/board/agenda/views/buttons/post.js.rb
@@ -42,7 +42,7 @@ class Post < Vue
_div.form_group do
_label 'financial spreadsheet from virtual', for: 'upload'
_input.upload! type: 'file', value: @upload
- _button.btn.btn_primary 'Upload', onClick: self.upload,
+ _button.btn.btn_primary 'Upload', onClick: upload_spreadsheet,
disabled: @disabled || !@upload
end
end
@@ -179,7 +179,7 @@ class Post < Vue
end
# upload contents of spreadsheet in base64; append extracted table to report
- def upload(event)
+ def upload_spreadsheet(event)
@disabled = true
event.preventDefault()
diff --git a/www/board/agenda/views/buttons/publish-minutes.js.rb b/www/board/agenda/views/buttons/publish-minutes.js.rb
index c4f446b..3e23590 100644
--- a/www/board/agenda/views/buttons/publish-minutes.js.rb
+++ b/www/board/agenda/views/buttons/publish-minutes.js.rb
@@ -40,14 +40,14 @@ class PublishMinutes < Vue
if @@item.title != @previous_title
if not @@item.attach
# Index page for a path month's agenda
- self.summary Agenda.index, Agenda.title.gsub('-', '_')
+ self.summarize Agenda.index, Agenda.title.gsub('-', '_')
elsif defined? XMLHttpRequest
# Minutes from previous meetings section of the agenda
date = @@item.text[/board_minutes_(\d+_\d+_\d+)\.txt/, 1]
url = document.baseURI.sub(/[-\d]+\/$/, date.gsub('_', '-')) + '.json'
retrieve url, :json do |agenda|
- self.summary agenda, date
+ self.summarize agenda, date
end
end
@@ -63,7 +63,7 @@ class PublishMinutes < Vue
end
# compute default summary for web site and commit message
- def summary(agenda, date)
+ def summarize(agenda, date)
summary = "- [#{self.formatDate(date)}]" +
"(../records/minutes/#{date[0..3]}/board_minutes_#{date}.txt)\n"
diff --git a/www/board/agenda/views/pages/comments.js.rb b/www/board/agenda/views/pages/comments.js.rb
index a7a2411..282932d 100644
--- a/www/board/agenda/views/pages/comments.js.rb
+++ b/www/board/agenda/views/pages/comments.js.rb
@@ -29,10 +29,6 @@ class Comments < Vue
@showseen = ! @showseen
end
- def showseen
- return @showseen
- end
-
def render
found = false
--
To stop receiving notification emails like this one, please contact
['"commits@whimsical.apache.org" <co...@whimsical.apache.org>'].