You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by ma...@apache.org on 2013/10/14 00:59:41 UTC
[1/4] git commit: [flex-sdk] [refs/heads/develop] - FIX
https://issues.apache.org/jira/browse/FLEX-33813 (DataGrid goes blank when
scrolled and dataProvider is changed )
Updated Branches:
refs/heads/develop 1d5fa798d -> 0234ed54f
FIX https://issues.apache.org/jira/browse/FLEX-33813 (DataGrid goes blank when scrolled and dataProvider is changed )
Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/fc91d4b9
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/fc91d4b9
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/fc91d4b9
Branch: refs/heads/develop
Commit: fc91d4b94f6027a7de781c9b00986f56941b4fce
Parents: 5ae5a84
Author: mamsellem <ma...@systar.com>
Authored: Fri Oct 11 15:54:01 2013 +0200
Committer: mamsellem <ma...@systar.com>
Committed: Fri Oct 11 15:54:01 2013 +0200
----------------------------------------------------------------------
frameworks/projects/spark/src/spark/components/Grid.as | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/fc91d4b9/frameworks/projects/spark/src/spark/components/Grid.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/spark/src/spark/components/Grid.as b/frameworks/projects/spark/src/spark/components/Grid.as
index c31e781..7deb6eb 100644
--- a/frameworks/projects/spark/src/spark/components/Grid.as
+++ b/frameworks/projects/spark/src/spark/components/Grid.as
@@ -5445,8 +5445,9 @@ public class Grid extends Group implements IDataGridElement, IDataProviderEnhanc
// No caret item so reset caret and vsp.
else
{
- caretRowIndex = _dataProvider.length > 0 ? 0 : -1;
- verticalScrollPosition = 0;
+ caretRowIndex = _dataProvider.length > 0 ? 0 : -1;
+ validateNow();
+ verticalScrollPosition = 0;
}
break;
[2/4] git commit: [flex-sdk] [refs/heads/develop] - Merge branch
'develop' of https://git-wip-us.apache.org/repos/asf/flex-sdk into develop
Posted by ma...@apache.org.
Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/flex-sdk into develop
Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/e16d783e
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/e16d783e
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/e16d783e
Branch: refs/heads/develop
Commit: e16d783ec618bea94772a7c377a5d3b1930771bd
Parents: fc91d4b 09c4e92
Author: mamsellem <ma...@systar.com>
Authored: Sun Oct 13 00:45:59 2013 +0200
Committer: mamsellem <ma...@systar.com>
Committed: Sun Oct 13 00:45:59 2013 +0200
----------------------------------------------------------------------
README | 24 ++++++++++++------------
RELEASE_NOTES | 8 ++++++--
ide/addAIRtoSDK.sh | 5 -----
ide/checkAllPlayerGlobals.sh | 2 +-
ide/flashbuilder/makeApacheFlexForIDE.sh | 4 ++--
jenkins.xml | 2 +-
6 files changed, 22 insertions(+), 23 deletions(-)
----------------------------------------------------------------------
RE: [1/4] git commit: [flex-sdk] [refs/heads/develop] - FIX
https://issues.apache.org/jira/browse/FLEX-33813 (DataGrid goes blank when
scrolled and dataProvider is changed )
Posted by Maurice Amsellem <ma...@systar.com>.
Fixed and pushed to develop
-----Message d'origine-----
De : Maurice Amsellem [mailto:maurice.amsellem@systar.com]
Envoyé : lundi 14 octobre 2013 01:49
À : dev@flex.apache.org
Objet : RE: [1/4] git commit: [flex-sdk] [refs/heads/develop] - FIX https://issues.apache.org/jira/browse/FLEX-33813 (DataGrid goes blank when scrolled and dataProvider is changed )
Ok
-----Message d'origine-----
De : Justin Mclean [mailto:justin@classsoftware.com] Envoyé : lundi 14 octobre 2013 01:46 À : dev@flex.apache.org Objet : Re: [1/4] git commit: [flex-sdk] [refs/heads/develop] - FIX https://issues.apache.org/jira/browse/FLEX-33813 (DataGrid goes blank when scrolled and dataProvider is changed )
Hi,
> So should I discard the temp fix until it's done ?
Only if you can't fix it in time for the next RC.
Justin
RE: [1/4] git commit: [flex-sdk] [refs/heads/develop] - FIX
https://issues.apache.org/jira/browse/FLEX-33813 (DataGrid goes blank when
scrolled and dataProvider is changed )
Posted by Maurice Amsellem <ma...@systar.com>.
Ok
-----Message d'origine-----
De : Justin Mclean [mailto:justin@classsoftware.com]
Envoyé : lundi 14 octobre 2013 01:46
À : dev@flex.apache.org
Objet : Re: [1/4] git commit: [flex-sdk] [refs/heads/develop] - FIX https://issues.apache.org/jira/browse/FLEX-33813 (DataGrid goes blank when scrolled and dataProvider is changed )
Hi,
> So should I discard the temp fix until it's done ?
Only if you can't fix it in time for the next RC.
Justin
Re: [1/4] git commit: [flex-sdk] [refs/heads/develop] - FIX https://issues.apache.org/jira/browse/FLEX-33813 (DataGrid goes blank when scrolled and dataProvider is changed )
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> So should I discard the temp fix until it's done ?
Only if you can't fix it in time for the next RC.
Justin
RE: [1/4] git commit: [flex-sdk] [refs/heads/develop] - FIX
https://issues.apache.org/jira/browse/FLEX-33813 (DataGrid goes blank when
scrolled and dataProvider is changed )
Posted by Maurice Amsellem <ma...@systar.com>.
Hi,
This is a temp fix I let by mistake and was working on it now.
The fix is OK, but not optimal,because it's using validateNow().
According to Alex, it should be fixed using flags and invalidateDisplayList().
(cf. email on 10/11@18:46 CET Re: Need help on https://issues.apache.org/jira/browse/FLEX-33813 (DataGrid goes blank) ),
I am currently investigating Alex's approach.
So should I discard the temp fix until it's done ?
Maurice
-----Message d'origine-----
De : Justin Mclean [mailto:justin@classsoftware.com]
Envoyé : lundi 14 octobre 2013 01:34
À : dev@flex.apache.org
Objet : Re: [1/4] git commit: [flex-sdk] [refs/heads/develop] - FIX https://issues.apache.org/jira/browse/FLEX-33813 (DataGrid goes blank when scrolled and dataProvider is changed )
Hi,
Is the validateNow() required?
Justin
Re: [1/4] git commit: [flex-sdk] [refs/heads/develop] - FIX https://issues.apache.org/jira/browse/FLEX-33813 (DataGrid goes blank when scrolled and dataProvider is changed )
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
Is the validateNow() required?
Justin
[4/4] git commit: [flex-sdk] [refs/heads/develop] - Merge branch
'develop' of https://git-wip-us.apache.org/repos/asf/flex-sdk into develop
Posted by ma...@apache.org.
Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/flex-sdk into develop
Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/0234ed54
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/0234ed54
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/0234ed54
Branch: refs/heads/develop
Commit: 0234ed54f9533791508d29b9baa229e24747472a
Parents: 3aef395 1d5fa79
Author: mamsellem <ma...@systar.com>
Authored: Mon Oct 14 00:55:23 2013 +0200
Committer: mamsellem <ma...@systar.com>
Committed: Mon Oct 14 00:55:23 2013 +0200
----------------------------------------------------------------------
.gitignore | 1 -
RELEASE_NOTES | 2 +-
flex-sdk-description.xml | 2 +-
ide/flashbuilder/config/air-config.xml | 443 ++++++++++++++++++
ide/flashbuilder/config/airmobile-config.xml | 365 +++++++++++++++
ide/flashbuilder/config/flex-config.xml | 447 +++++++++++++++++++
ide/flashbuilder/makeApacheFlexForIDE.bat | 4 +-
.../Styles/RadioButton_Mirroring_Styles.mxml | 1 +
.../RadioButton/swfs/RadioButton_Basic2.mxml | 2 +-
9 files changed, 1261 insertions(+), 6 deletions(-)
----------------------------------------------------------------------
[3/4] git commit: [flex-sdk] [refs/heads/develop] - Fix
https://issues.apache.org/jira/browse/FLEX-33818 (Spark Datagrid column
resize and sort bug when releasing mouse outside of headers)
Posted by ma...@apache.org.
Fix https://issues.apache.org/jira/browse/FLEX-33818 (Spark Datagrid column resize and sort bug when releasing mouse outside of headers)
Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/3aef3953
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/3aef3953
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/3aef3953
Branch: refs/heads/develop
Commit: 3aef395307dc6ce3fa825c6838df21e310938d5b
Parents: e16d783
Author: mamsellem <ma...@systar.com>
Authored: Mon Oct 14 00:32:31 2013 +0200
Committer: mamsellem <ma...@systar.com>
Committed: Mon Oct 14 00:32:31 2013 +0200
----------------------------------------------------------------------
.../spark/src/spark/components/GridColumnHeaderGroup.as | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/3aef3953/frameworks/projects/spark/src/spark/components/GridColumnHeaderGroup.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/spark/src/spark/components/GridColumnHeaderGroup.as b/frameworks/projects/spark/src/spark/components/GridColumnHeaderGroup.as
index 43d5951..bd62162 100644
--- a/frameworks/projects/spark/src/spark/components/GridColumnHeaderGroup.as
+++ b/frameworks/projects/spark/src/spark/components/GridColumnHeaderGroup.as
@@ -1064,8 +1064,10 @@ public class GridColumnHeaderGroup extends Group implements IDataGridElement
{
const eventHeaderCP:CellPosition = new CellPosition();
const eventHeaderXY:Point = new Point();
- if (!eventToHeaderLocations(event, eventHeaderCP, eventHeaderXY))
- return;
+ // mouse can be released outside of header , so don't check cf. https://issues.apache.org/jira/browse/FLEX-33818
+ if (event.type != MouseEvent.MOUSE_UP && !eventToHeaderLocations(event, eventHeaderCP, eventHeaderXY))
+ return;
+
const eventSeparatorIndex:int = eventHeaderCP.rowIndex;
const eventColumnIndex:int = (eventSeparatorIndex == -1) ? eventHeaderCP.columnIndex : -1;