You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by "Alex Harui (JIRA)" <ji...@apache.org> on 2013/02/16 07:37:12 UTC

[jira] [Commented] (FLEX-33398) ComboBox loses selectedItem when dataProvider dispatch reset event

    [ https://issues.apache.org/jira/browse/FLEX-33398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13579733#comment-13579733 ] 

Alex Harui commented on FLEX-33398:
-----------------------------------

Hmm.  I'd be afraid to build in a call to contains.  I think it does linear search on some collections which will be slow if large or complex.
                
> ComboBox loses selectedItem when dataProvider dispatch reset event
> ------------------------------------------------------------------
>
>                 Key: FLEX-33398
>                 URL: https://issues.apache.org/jira/browse/FLEX-33398
>             Project: Apache Flex
>          Issue Type: Bug
>          Components: mx: ComboBox
>            Reporter: João Fernandes
>   Original Estimate: 1m
>  Remaining Estimate: 1m
>
> During a reset Event, combobox does reset the selectedItem but doesn't respect the fact the current selectedItem might be included in the new source.
> What I propose is to change
>  else if (ce.kind == CollectionEventKind.RESET)
>             {
>                 collectionChanged = true;
>                 if (!selectedIndexChanged && !selectedItemChanged)
>                     selectedIndex = prompt ? -1 : 0;
>                 invalidateProperties();
>             }
> to 
>  else if (ce.kind == CollectionEventKind.RESET)
>             {
>                 collectionChanged = true;
>                 if (!selectedIndexChanged && !selectedItemChanged && !collection.contains(selectedItem))
>                     selectedIndex = prompt ? -1 : 0;
>                 invalidateProperties();
>             }

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira