You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Gabriel39 (via GitHub)" <gi...@apache.org> on 2025/04/09 07:14:26 UTC
[PR] [refactor](minor) Delete unused RuntimeFilterDependency [doris]
Gabriel39 opened a new pull request, #49902:
URL: https://github.com/apache/doris/pull/49902
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](minor) Delete unused RuntimeFilterDependency [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #49902:
URL: https://github.com/apache/doris/pull/49902#issuecomment-2791357929
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](minor) Delete unused RuntimeFilterDependency [doris]
Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 commented on PR #49902:
URL: https://github.com/apache/doris/pull/49902#issuecomment-2788679739
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](minor) Delete unused RuntimeFilterDependency [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #49902:
URL: https://github.com/apache/doris/pull/49902#issuecomment-2788578714
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](minor) Delete unused RuntimeFilterDependency [doris]
Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 merged PR #49902:
URL: https://github.com/apache/doris/pull/49902
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](minor) Delete unused RuntimeFilterDependency [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #49902:
URL: https://github.com/apache/doris/pull/49902#issuecomment-2791357975
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](minor) Delete unused RuntimeFilterDependency [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #49902:
URL: https://github.com/apache/doris/pull/49902#issuecomment-2789384604
<details>
<summary>ClickBench: <b>Total hot run time: 30.85 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f2838acf280199e8df00e9afd5031e52f898e0e8, data reload: false
query1 0.04 0.04 0.04
query2 0.11 0.11 0.10
query3 0.24 0.20 0.20
query4 1.59 0.19 0.19
query5 0.60 0.58 0.59
query6 1.18 0.72 0.72
query7 0.02 0.02 0.01
query8 0.05 0.03 0.04
query9 0.57 0.52 0.51
query10 0.60 0.58 0.57
query11 0.16 0.11 0.10
query12 0.16 0.11 0.11
query13 0.62 0.60 0.61
query14 2.65 2.68 2.73
query15 0.93 0.86 0.82
query16 0.38 0.38 0.39
query17 1.02 1.02 1.01
query18 0.21 0.19 0.20
query19 1.92 1.88 1.91
query20 0.01 0.01 0.01
query21 15.40 0.91 0.53
query22 0.74 1.13 0.74
query23 14.91 1.40 0.66
query24 7.64 1.46 0.45
query25 0.49 0.06 0.24
query26 0.68 0.18 0.13
query27 0.05 0.04 0.05
query28 9.27 0.92 0.42
query29 12.55 3.97 3.30
query30 0.26 0.10 0.06
query31 2.82 0.57 0.39
query32 3.23 0.54 0.47
query33 3.00 3.11 3.09
query34 15.86 5.08 4.48
query35 4.46 4.48 4.50
query36 0.68 0.50 0.49
query37 0.09 0.06 0.06
query38 0.04 0.04 0.04
query39 0.03 0.03 0.02
query40 0.17 0.14 0.13
query41 0.08 0.04 0.03
query42 0.04 0.02 0.02
query43 0.04 0.03 0.03
Total cold run time: 105.59 s
Total hot run time: 30.85 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](minor) Delete unused RuntimeFilterDependency [doris]
Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 commented on PR #49902:
URL: https://github.com/apache/doris/pull/49902#issuecomment-2788833696
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](minor) Delete unused RuntimeFilterDependency [doris]
Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 commented on PR #49902:
URL: https://github.com/apache/doris/pull/49902#issuecomment-2789262787
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](minor) Delete unused RuntimeFilterDependency [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #49902:
URL: https://github.com/apache/doris/pull/49902#issuecomment-2789344408
<details>
<summary>TPC-H: <b>Total hot run time: 34689 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f2838acf280199e8df00e9afd5031e52f898e0e8, data reload: false
------ Round 1 ----------------------------------
q1 25948 5073 5075 5073
q2 2063 273 185 185
q3 10397 1231 716 716
q4 10230 991 537 537
q5 7528 2416 2293 2293
q6 187 165 135 135
q7 920 759 623 623
q8 9324 1326 1130 1130
q9 6942 5137 5123 5123
q10 6818 2304 1911 1911
q11 484 300 279 279
q12 346 354 221 221
q13 17768 3713 3138 3138
q14 229 223 214 214
q15 526 488 488 488
q16 643 638 580 580
q17 612 865 398 398
q18 7674 7171 7180 7171
q19 1224 951 580 580
q20 345 334 233 233
q21 4483 3545 2701 2701
q22 1078 960 968 960
Total cold run time: 115769 ms
Total hot run time: 34689 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5135 5103 5080 5080
q2 238 320 225 225
q3 2137 2652 2301 2301
q4 1457 1808 1518 1518
q5 4563 4459 4369 4369
q6 209 165 125 125
q7 1982 1900 1730 1730
q8 2631 2547 2500 2500
q9 7178 7186 7153 7153
q10 3059 3186 2738 2738
q11 557 509 499 499
q12 709 777 613 613
q13 3518 3888 3254 3254
q14 285 301 267 267
q15 515 471 480 471
q16 666 676 637 637
q17 1149 1579 1356 1356
q18 7620 7485 7413 7413
q19 820 817 863 817
q20 1955 2018 1848 1848
q21 5142 4632 4603 4603
q22 1054 1018 977 977
Total cold run time: 52579 ms
Total hot run time: 50494 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](minor) Delete unused RuntimeFilterDependency [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #49902:
URL: https://github.com/apache/doris/pull/49902#issuecomment-2789689702
# BE UT Coverage Report
Increment line coverage `75.00% (3/4)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/f2838acf280199e8df00e9afd5031e52f898e0e8_f2838acf280199e8df00e9afd5031e52f898e0e8/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/f2838acf280199e8df00e9afd5031e52f898e0e8_f2838acf280199e8df00e9afd5031e52f898e0e8/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.34% (14069/26879) |
| Line Coverage | 41.12% (121513/295505) |
| Region Coverage | 39.86% (61836/155150) |
| Branch Coverage | 34.51% (30955/89694) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](minor) Delete unused RuntimeFilterDependency [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #49902:
URL: https://github.com/apache/doris/pull/49902#issuecomment-2789371394
<details>
<summary>TPC-DS: <b>Total hot run time: 186380 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f2838acf280199e8df00e9afd5031e52f898e0e8, data reload: false
query1 995 478 476 476
query2 6551 1935 1936 1935
query3 6740 225 222 222
query4 26168 23322 23031 23031
query5 4353 636 486 486
query6 307 206 201 201
query7 4626 498 280 280
query8 296 248 242 242
query9 8612 2596 2591 2591
query10 493 326 278 278
query11 15757 15188 14793 14793
query12 162 112 111 111
query13 1661 529 405 405
query14 8839 6228 6335 6228
query15 217 188 168 168
query16 7210 619 484 484
query17 1231 752 601 601
query18 1968 407 314 314
query19 190 191 166 166
query20 125 118 119 118
query21 208 129 109 109
query22 4177 4087 4312 4087
query23 33940 32911 32806 32806
query24 8537 2404 2383 2383
query25 563 450 392 392
query26 1241 263 147 147
query27 2742 500 331 331
query28 4295 2439 2436 2436
query29 764 565 437 437
query30 288 215 200 200
query31 947 881 782 782
query32 74 91 63 63
query33 579 352 307 307
query34 797 833 513 513
query35 810 817 757 757
query36 954 967 889 889
query37 122 106 78 78
query38 4041 4147 4030 4030
query39 1471 1399 1413 1399
query40 212 120 103 103
query41 57 56 52 52
query42 127 113 102 102
query43 493 516 482 482
query44 1329 800 805 800
query45 175 175 168 168
query46 849 1017 617 617
query47 1745 1795 1708 1708
query48 374 404 302 302
query49 779 502 427 427
query50 667 675 403 403
query51 4197 4134 4188 4134
query52 110 111 95 95
query53 227 250 183 183
query54 571 589 502 502
query55 79 80 83 80
query56 296 299 305 299
query57 1141 1172 1080 1080
query58 275 257 264 257
query59 2739 2723 2818 2723
query60 339 316 301 301
query61 139 134 128 128
query62 820 725 654 654
query63 231 186 183 183
query64 4356 1035 697 697
query65 4390 4252 4267 4252
query66 1164 420 312 312
query67 15680 15587 15475 15475
query68 8191 887 509 509
query69 458 354 274 274
query70 1218 1155 1083 1083
query71 462 319 313 313
query72 5922 4789 4875 4789
query73 749 664 342 342
query74 9026 9057 8610 8610
query75 3865 3198 2712 2712
query76 3710 1215 754 754
query77 780 380 295 295
query78 9940 10032 9299 9299
query79 2906 808 566 566
query80 623 511 447 447
query81 495 258 220 220
query82 487 128 97 97
query83 286 254 237 237
query84 296 105 91 91
query85 795 368 326 326
query86 387 297 284 284
query87 4600 4578 4347 4347
query88 3692 2209 2214 2209
query89 401 327 286 286
query90 1892 214 216 214
query91 140 144 116 116
query92 86 62 56 56
query93 2165 988 582 582
query94 675 444 298 298
query95 375 292 287 287
query96 496 563 272 272
query97 3164 3297 3180 3180
query98 248 213 211 211
query99 1450 1388 1279 1279
Total cold run time: 276592 ms
Total hot run time: 186380 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org