You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2016/04/18 14:42:42 UTC
Review Request 46321: Renamed a variable in command executors for
clarity.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46321/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Repository: mesos
Description
-------
When we kill (with SIGTERM) the underlying task, it does not
necessarily mean it complies immediately, hence the name `killed`
is misleading.
Diffs
-----
src/launcher/executor.cpp bec9cba091df2d1b340e68e67966ec322558c315
src/launcher/http_command_executor.cpp ad484e0e6f5067b6c166111c91b1ff1e8c05d9ac
Diff: https://reviews.apache.org/r/46321/diff/
Testing
-------
The whole chain is tested in https://reviews.apache.org/r/46325/
Thanks,
Alexander Rukletsov
Re: Review Request 46321: Renamed a variable in command executors for
clarity.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46321/
-----------------------------------------------------------
(Updated April 22, 2016, 2:35 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
+ Docker executor; introduced `terminated` state flag in command executors.
Repository: mesos
Description
-------
When we kill (with SIGTERM) the underlying task, it does not
necessarily mean it complies immediately, hence the name `killed`
is misleading.
Diffs (updated)
-----
src/docker/executor.cpp 579905f6c2ece7db9c853abf481541fdbc3116b7
src/launcher/executor.cpp 9f1d2168bc4ddbce1bcd25ff38dc1c34714eb28b
src/launcher/http_command_executor.cpp 2ce296740abac096aa85ad11dd4d191e42c1aa06
Diff: https://reviews.apache.org/r/46321/diff/
Testing
-------
The whole chain is tested in https://reviews.apache.org/r/46325/
Thanks,
Alexander Rukletsov
Re: Review Request 46321: Renamed a variable in command executors for
clarity.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46321/
-----------------------------------------------------------
(Updated April 21, 2016, 2:27 p.m.)
Review request for mesos and Ben Mahler.
Repository: mesos
Description
-------
When we kill (with SIGTERM) the underlying task, it does not
necessarily mean it complies immediately, hence the name `killed`
is misleading.
Diffs (updated)
-----
src/launcher/executor.cpp bec9cba091df2d1b340e68e67966ec322558c315
src/launcher/http_command_executor.cpp 9dfe48108cababeb2d4a6af74434880d79245c21
Diff: https://reviews.apache.org/r/46321/diff/
Testing
-------
The whole chain is tested in https://reviews.apache.org/r/46325/
Thanks,
Alexander Rukletsov
Re: Review Request 46321: Renamed a variable in command executors for
clarity.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46321/
-----------------------------------------------------------
(Updated April 21, 2016, 2:01 p.m.)
Review request for mesos and Ben Mahler.
Repository: mesos
Description
-------
When we kill (with SIGTERM) the underlying task, it does not
necessarily mean it complies immediately, hence the name `killed`
is misleading.
Diffs (updated)
-----
src/launcher/executor.cpp bec9cba091df2d1b340e68e67966ec322558c315
src/launcher/http_command_executor.cpp ad484e0e6f5067b6c166111c91b1ff1e8c05d9ac
Diff: https://reviews.apache.org/r/46321/diff/
Testing
-------
The whole chain is tested in https://reviews.apache.org/r/46325/
Thanks,
Alexander Rukletsov