You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2017/11/02 16:12:05 UTC

Review Request 63516: [Preview] Remove properties.json And Switch To Adding Properties to ResourceProviders Dynamically

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63516/
-----------------------------------------------------------

Review request for Ambari, Jonathan Hurley and Nate Cole.


Bugs: AMBARI-22353
    https://issues.apache.org/jira/browse/AMBARI-22353


Repository: ambari


Description
-------

Legacy/ancient ResourceProviders use the {{properties.json}} file to govern which properties can be used with the provider. This seems like excessive decoupling without any benefit and usually leads to runtime errors when new or removed properties are forgotten.

This file should be removed and the providers should be registering the known properties on their own.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java 711ae10f7e 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java 1dc0841d19 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractDRResourceProvider.java 953a2a7c77 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActionResourceProvider.java 4e618e7ff6 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java 73d24908ea 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java a2a49d7cb5 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java 737bfa4d46 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java c3758b3f5e 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionLinkResourceProvider.java db904bf714 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionResourceProvider.java 53e44e1888 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionVersionResourceProvider.java 4aa357c0e3 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/FeedResourceProvider.java f9d75fd353 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java f051651e12 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentProcessResourceProvider.java 2a25bc4d02 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java 6708560969 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java 5373ffe31c 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/InstanceResourceProvider.java d3a695ba08 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/JobResourceProvider.java e70c3674b4 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/KerberosDescriptorResourceProvider.java 93013415b4 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/LoggingResourceProvider.java d6afe7b22b 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/MemberResourceProvider.java d9d56eee8c 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RecommendationResourceProvider.java 70ed3dc09f 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java 81f283c55b 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestScheduleResourceProvider.java 4e25369a6e 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceComponentResourceProvider.java 3925aebdae 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceHostComponentResourceProvider.java c37bb2efe7 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceResourceProvider.java b24a94aee0 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackConfigurationDependencyResourceProvider.java 366b3ef052 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackConfigurationResourceProvider.java 6f5b0f8c02 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDependencyResourceProvider.java 8b69c6a312 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackLevelConfigurationResourceProvider.java 819507bffd 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackResourceProvider.java ead4f6df2b 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceComponentResourceProvider.java b9661bb409 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java 8727741d37 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackVersionResourceProvider.java 094c75bbb8 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TargetClusterResourceProvider.java d0c37f5a9e 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TaskAttemptResourceProvider.java 3af7bb15e5 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TaskResourceProvider.java 0b4fcd9633 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserResourceProvider.java c5c36e9942 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ValidationResourceProvider.java b78c64af53 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/WorkflowResourceProvider.java 13cb8a4768 
  ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/PropertyHelper.java 893978047c 
  ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java 5c5801d451 
  ambari-server/src/main/resources/key_properties.json 5d76062d87 
  ambari-server/src/main/resources/properties.json 1d12f83b3f 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProviderTest.java a127de6539 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractDRResourceProviderTest.java 38e6d366a1 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractResourceProviderTest.java 7165e48d70 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ActionResourceProviderTest.java ef56f9d3e7 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProviderTest.java 5221ecf16b 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java f53441182b 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java 833be5d117 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterKerberosDescriptorResourceProviderTest.java ac2847590d 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java 4a808931ac 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java 984010650c 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProviderTest.java 78f79ead9c 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ConfigurationResourceProviderTest.java 785ea2388b 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CredentialResourceProviderTest.java 89ed022da0 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ExtensionResourceProviderTest.java 5b6e830d6e 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/FeedResourceProviderTest.java 5cf9b056ea 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/GroupResourceProviderTest.java bbfa2d8503 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentProcessResourceProviderTest.java 5a7460d4c1 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java 7e32c15991 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java fd28081944 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProviderTest.java 6c95c53e5b 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/InstanceResourceProviderTest.java ba6793989e 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java e19ad29453 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JobResourceProviderTest.java 6fd1a238ae 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/KerberosDescriptorResourceProviderTest.java ca8127e42f 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/MemberResourceProviderTest.java 39ba4b9fe3 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java c0695b12d6 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestScheduleResourceProviderTest.java 6d4f72d9ad 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceComponentResourceProviderTest.java 222340b4e7 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceHostComponentResourceProviderTest.java ce3656c4ab 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceResourceProviderTest.java 96bc7c9674 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProviderTest.java 05232eac49 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackArtifactResourceProviderTest.java 21df88d545 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackConfigurationDependencyResourceProviderTest.java 7c88852f48 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackConfigurationResourceProviderTest.java 9c48ad0d23 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDependencyResourceProviderTest.java f35015348f 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackLevelConfigurationResourceProviderTest.java e9742bdfb1 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackResourceProviderTest.java 4281e3372e 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackServiceResourceProviderTest.java 2a2ef0b0b7 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TargetClusterResourceProviderTest.java 492c012c7e 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TaskResourceProviderTest.java 365d408ff6 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TestIvoryProviderModule.java 90f10118d4 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java d6b1ab3766 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderDBTest.java c4f0f349fb 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderTest.java 9efad8a54d 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ValidationResourceProviderTest.java c639d1fcdc 


Diff: https://reviews.apache.org/r/63516/diff/1/


Testing
-------

tests do not pass yet, also on deploy get errors in some places.
Fixing mistakes


Thanks,

Dmitro Lisnichenko

Re: Review Request 63516: [Preview] Remove properties.json And Switch To Adding Properties to ResourceProviders Dynamically

Posted by Nate Cole <nc...@hortonworks.com>.


> On Nov. 2, 2017, 7:42 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActionResourceProvider.java
> > Lines 69-72 (patched)
> > <https://reviews.apache.org/r/63516/diff/1/?file=1879216#file1879216line71>
> >
> >     I don't think we ever change this map do we?  Can use ImmutableMap.builder().put()...build()
> >     
> >     Or, simple ones like this can be Collections.singletonMap(key, value)
> 
> Dmitro Lisnichenko wrote:
>     these changes would require a big patch. Should I fix all providers, or only ones affected by a current patch?

Just affected by current patch.


> On Nov. 2, 2017, 7:42 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActionResourceProvider.java
> > Lines 77-87 (patched)
> > <https://reviews.apache.org/r/63516/diff/1/?file=1879216#file1879216line79>
> >
> >     Recommend Sets.newHashSet(String...) - it's much cleaner looking and avoids an added static{} block.
> 
> Dmitro Lisnichenko wrote:
>     these changes would require a big patch. Should I fix all providers, or only ones affected by a current patch?

Just affected by current patch.


- Nate


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63516/#review189988
-----------------------------------------------------------


On Nov. 9, 2017, 4:58 a.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63516/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2017, 4:58 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-22353
>     https://issues.apache.org/jira/browse/AMBARI-22353
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Legacy/ancient ResourceProviders use the {{properties.json}} file to govern which properties can be used with the provider. This seems like excessive decoupling without any benefit and usually leads to runtime errors when new or removed properties are forgotten.
> 
> This file should be removed and the providers should be registering the known properties on their own.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java 711ae10f7e 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractAuthorizedResourceProvider.java a24c6394ac 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java 1dc0841d19 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractDRResourceProvider.java 953a2a7c77 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActionResourceProvider.java 4e618e7ff6 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProvider.java 389f0b2bf2 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java 32f1fd8f4f 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProvider.java cf4e7475b3 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertHistoryResourceProvider.java 8d716eabe0 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertNoticeResourceProvider.java 8ffd596cfa 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java c71651e5ff 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java 43ee7fe7c7 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AmbariConfigurationResourceProvider.java 4f4cc7070d 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java 73d24908ea 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java a2a49d7cb5 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterKerberosDescriptorResourceProvider.java 2678d55975 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java 54c83600b7 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 1a755590b7 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java 737bfa4d46 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigurationResourceProvider.java 0f260854f8 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CredentialResourceProvider.java 79254c6d89 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java c3758b3f5e 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionLinkResourceProvider.java db904bf714 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionResourceProvider.java 53e44e1888 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionVersionResourceProvider.java 4aa357c0e3 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/FeedResourceProvider.java f9d75fd353 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupPrivilegeResourceProvider.java f9f838fe22 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java f051651e12 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentProcessResourceProvider.java 2a25bc4d02 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java 6708560969 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostKerberosIdentityResourceProvider.java bfaf7b4a4f 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java 5373ffe31c 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java ba5fccc1dc 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/InstanceResourceProvider.java d3a695ba08 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/JobResourceProvider.java e70c3674b4 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/KerberosDescriptorResourceProvider.java 93013415b4 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/LdapSyncEventResourceProvider.java 4badc9c472 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/LoggingResourceProvider.java d6afe7b22b 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/MemberResourceProvider.java d9d56eee8c 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/OperatingSystemResourceProvider.java 174fdf60a0 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PrivilegeResourceProvider.java fabce6b379 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/QuickLinkArtifactResourceProvider.java 073ec60b27 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ReadOnlyResourceProvider.java 505ec637ed 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RecommendationResourceProvider.java 70ed3dc09f 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RemoteClusterResourceProvider.java 0b2d2b3f52 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java 81f283c55b 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestScheduleResourceProvider.java 4e25369a6e 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RoleAuthorizationResourceProvider.java 78eb80e8d1 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceComponentResourceProvider.java 3925aebdae 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceHostComponentResourceProvider.java c37bb2efe7 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceResourceProvider.java b24a94aee0 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceConfigVersionResourceProvider.java e7dbbc0389 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/SettingResourceProvider.java 5235ef4fb1 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProvider.java 7035f0a148 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackArtifactResourceProvider.java 6bb421b67b 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackConfigurationDependencyResourceProvider.java 366b3ef052 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackConfigurationResourceProvider.java 6f5b0f8c02 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDependencyResourceProvider.java 8b69c6a312 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackLevelConfigurationResourceProvider.java 819507bffd 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackResourceProvider.java ead4f6df2b 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceComponentResourceProvider.java b9661bb409 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java 8727741d37 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackVersionResourceProvider.java 094c75bbb8 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StageResourceProvider.java 6a326b5338 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TargetClusterResourceProvider.java d0c37f5a9e 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TaskAttemptResourceProvider.java 3af7bb15e5 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TaskResourceProvider.java 0b4fcd9633 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ThemeArtifactResourceProvider.java fc7cfe7f91 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeGroupResourceProvider.java e6aafc1ec5 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeItemResourceProvider.java 36eb3bebf1 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java a1ec98afe7 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeSummaryResourceProvider.java 94b2b4a981 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserAuthorizationResourceProvider.java 95550f0299 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProvider.java 614f7abda1 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserResourceProvider.java c5c36e9942 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ValidationResourceProvider.java b78c64af53 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java f94ac32f17 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java 9562782b01 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewResourceProvider.java 7179b335c2 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewURLResourceProvider.java cb506be1bf 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/WidgetLayoutResourceProvider.java 8c39fc4057 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/WidgetResourceProvider.java 03fd5d2359 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/WorkflowResourceProvider.java 13cb8a4768 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/PropertyHelper.java 893978047c 
>   ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java 5c5801d451 
>   ambari-server/src/main/resources/key_properties.json 5d76062d87 
>   ambari-server/src/main/resources/properties.json 1d12f83b3f 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProviderTest.java a127de6539 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractDRResourceProviderTest.java 38e6d366a1 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractResourceProviderTest.java 7165e48d70 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ActionResourceProviderTest.java ef56f9d3e7 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProviderTest.java 5221ecf16b 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java f53441182b 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java 833be5d117 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterKerberosDescriptorResourceProviderTest.java ac2847590d 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java 4a808931ac 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java 984010650c 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProviderTest.java 78f79ead9c 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ConfigurationResourceProviderTest.java 785ea2388b 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CredentialResourceProviderTest.java 89ed022da0 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ExtensionResourceProviderTest.java 5b6e830d6e 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/FeedResourceProviderTest.java 5cf9b056ea 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/GroupResourceProviderTest.java bbfa2d8503 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentProcessResourceProviderTest.java 5a7460d4c1 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java 7e32c15991 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java fd28081944 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProviderTest.java 6c95c53e5b 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/InstanceResourceProviderTest.java ba6793989e 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java e19ad29453 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JobResourceProviderTest.java 6fd1a238ae 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/KerberosDescriptorResourceProviderTest.java ca8127e42f 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/MemberResourceProviderTest.java 39ba4b9fe3 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java c0695b12d6 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestScheduleResourceProviderTest.java 6d4f72d9ad 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceComponentResourceProviderTest.java 222340b4e7 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceHostComponentResourceProviderTest.java ce3656c4ab 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceResourceProviderTest.java 96bc7c9674 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProviderTest.java 05232eac49 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackArtifactResourceProviderTest.java 21df88d545 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackConfigurationDependencyResourceProviderTest.java 7c88852f48 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackConfigurationResourceProviderTest.java 9c48ad0d23 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDependencyResourceProviderTest.java f35015348f 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackLevelConfigurationResourceProviderTest.java e9742bdfb1 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackResourceProviderTest.java 4281e3372e 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackServiceResourceProviderTest.java 2a2ef0b0b7 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TargetClusterResourceProviderTest.java 492c012c7e 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TaskResourceProviderTest.java 365d408ff6 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TestIvoryProviderModule.java 90f10118d4 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java d6b1ab3766 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderDBTest.java c4f0f349fb 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderTest.java 9efad8a54d 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ValidationResourceProviderTest.java c639d1fcdc 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/WorkflowResourceProviderTest.java 337dc466da 
> 
> 
> Diff: https://reviews.apache.org/r/63516/diff/2/
> 
> 
> Testing
> -------
> 
> tests do not pass yet, also on deploy get errors in some places.
> Fixing mistakes
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 63516: [Preview] Remove properties.json And Switch To Adding Properties to ResourceProviders Dynamically

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.


> On Nov. 3, 2017, 1:42 a.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActionResourceProvider.java
> > Lines 69-72 (patched)
> > <https://reviews.apache.org/r/63516/diff/1/?file=1879216#file1879216line71>
> >
> >     I don't think we ever change this map do we?  Can use ImmutableMap.builder().put()...build()
> >     
> >     Or, simple ones like this can be Collections.singletonMap(key, value)

these changes would require a big patch. Should I fix all providers, or only ones affected by a current patch?


> On Nov. 3, 2017, 1:42 a.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActionResourceProvider.java
> > Lines 77-87 (patched)
> > <https://reviews.apache.org/r/63516/diff/1/?file=1879216#file1879216line79>
> >
> >     Recommend Sets.newHashSet(String...) - it's much cleaner looking and avoids an added static{} block.

these changes would require a big patch. Should I fix all providers, or only ones affected by a current patch?


- Dmitro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63516/#review189988
-----------------------------------------------------------


On Nov. 9, 2017, 11:58 a.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63516/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2017, 11:58 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-22353
>     https://issues.apache.org/jira/browse/AMBARI-22353
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Legacy/ancient ResourceProviders use the {{properties.json}} file to govern which properties can be used with the provider. This seems like excessive decoupling without any benefit and usually leads to runtime errors when new or removed properties are forgotten.
> 
> This file should be removed and the providers should be registering the known properties on their own.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java 711ae10f7e 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractAuthorizedResourceProvider.java a24c6394ac 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java 1dc0841d19 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractDRResourceProvider.java 953a2a7c77 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActionResourceProvider.java 4e618e7ff6 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProvider.java 389f0b2bf2 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java 32f1fd8f4f 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProvider.java cf4e7475b3 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertHistoryResourceProvider.java 8d716eabe0 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertNoticeResourceProvider.java 8ffd596cfa 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java c71651e5ff 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java 43ee7fe7c7 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AmbariConfigurationResourceProvider.java 4f4cc7070d 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java 73d24908ea 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java a2a49d7cb5 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterKerberosDescriptorResourceProvider.java 2678d55975 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java 54c83600b7 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 1a755590b7 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java 737bfa4d46 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigurationResourceProvider.java 0f260854f8 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CredentialResourceProvider.java 79254c6d89 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java c3758b3f5e 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionLinkResourceProvider.java db904bf714 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionResourceProvider.java 53e44e1888 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionVersionResourceProvider.java 4aa357c0e3 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/FeedResourceProvider.java f9d75fd353 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupPrivilegeResourceProvider.java f9f838fe22 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java f051651e12 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentProcessResourceProvider.java 2a25bc4d02 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java 6708560969 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostKerberosIdentityResourceProvider.java bfaf7b4a4f 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java 5373ffe31c 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java ba5fccc1dc 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/InstanceResourceProvider.java d3a695ba08 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/JobResourceProvider.java e70c3674b4 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/KerberosDescriptorResourceProvider.java 93013415b4 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/LdapSyncEventResourceProvider.java 4badc9c472 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/LoggingResourceProvider.java d6afe7b22b 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/MemberResourceProvider.java d9d56eee8c 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/OperatingSystemResourceProvider.java 174fdf60a0 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PrivilegeResourceProvider.java fabce6b379 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/QuickLinkArtifactResourceProvider.java 073ec60b27 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ReadOnlyResourceProvider.java 505ec637ed 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RecommendationResourceProvider.java 70ed3dc09f 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RemoteClusterResourceProvider.java 0b2d2b3f52 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java 81f283c55b 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestScheduleResourceProvider.java 4e25369a6e 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RoleAuthorizationResourceProvider.java 78eb80e8d1 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceComponentResourceProvider.java 3925aebdae 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceHostComponentResourceProvider.java c37bb2efe7 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceResourceProvider.java b24a94aee0 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceConfigVersionResourceProvider.java e7dbbc0389 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/SettingResourceProvider.java 5235ef4fb1 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProvider.java 7035f0a148 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackArtifactResourceProvider.java 6bb421b67b 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackConfigurationDependencyResourceProvider.java 366b3ef052 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackConfigurationResourceProvider.java 6f5b0f8c02 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDependencyResourceProvider.java 8b69c6a312 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackLevelConfigurationResourceProvider.java 819507bffd 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackResourceProvider.java ead4f6df2b 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceComponentResourceProvider.java b9661bb409 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java 8727741d37 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackVersionResourceProvider.java 094c75bbb8 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StageResourceProvider.java 6a326b5338 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TargetClusterResourceProvider.java d0c37f5a9e 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TaskAttemptResourceProvider.java 3af7bb15e5 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TaskResourceProvider.java 0b4fcd9633 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ThemeArtifactResourceProvider.java fc7cfe7f91 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeGroupResourceProvider.java e6aafc1ec5 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeItemResourceProvider.java 36eb3bebf1 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java a1ec98afe7 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeSummaryResourceProvider.java 94b2b4a981 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserAuthorizationResourceProvider.java 95550f0299 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProvider.java 614f7abda1 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserResourceProvider.java c5c36e9942 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ValidationResourceProvider.java b78c64af53 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java f94ac32f17 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java 9562782b01 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewResourceProvider.java 7179b335c2 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewURLResourceProvider.java cb506be1bf 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/WidgetLayoutResourceProvider.java 8c39fc4057 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/WidgetResourceProvider.java 03fd5d2359 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/WorkflowResourceProvider.java 13cb8a4768 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/PropertyHelper.java 893978047c 
>   ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java 5c5801d451 
>   ambari-server/src/main/resources/key_properties.json 5d76062d87 
>   ambari-server/src/main/resources/properties.json 1d12f83b3f 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProviderTest.java a127de6539 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractDRResourceProviderTest.java 38e6d366a1 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractResourceProviderTest.java 7165e48d70 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ActionResourceProviderTest.java ef56f9d3e7 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProviderTest.java 5221ecf16b 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java f53441182b 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java 833be5d117 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterKerberosDescriptorResourceProviderTest.java ac2847590d 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java 4a808931ac 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java 984010650c 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProviderTest.java 78f79ead9c 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ConfigurationResourceProviderTest.java 785ea2388b 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CredentialResourceProviderTest.java 89ed022da0 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ExtensionResourceProviderTest.java 5b6e830d6e 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/FeedResourceProviderTest.java 5cf9b056ea 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/GroupResourceProviderTest.java bbfa2d8503 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentProcessResourceProviderTest.java 5a7460d4c1 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java 7e32c15991 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java fd28081944 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProviderTest.java 6c95c53e5b 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/InstanceResourceProviderTest.java ba6793989e 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java e19ad29453 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JobResourceProviderTest.java 6fd1a238ae 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/KerberosDescriptorResourceProviderTest.java ca8127e42f 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/MemberResourceProviderTest.java 39ba4b9fe3 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java c0695b12d6 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestScheduleResourceProviderTest.java 6d4f72d9ad 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceComponentResourceProviderTest.java 222340b4e7 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceHostComponentResourceProviderTest.java ce3656c4ab 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceResourceProviderTest.java 96bc7c9674 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProviderTest.java 05232eac49 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackArtifactResourceProviderTest.java 21df88d545 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackConfigurationDependencyResourceProviderTest.java 7c88852f48 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackConfigurationResourceProviderTest.java 9c48ad0d23 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDependencyResourceProviderTest.java f35015348f 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackLevelConfigurationResourceProviderTest.java e9742bdfb1 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackResourceProviderTest.java 4281e3372e 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackServiceResourceProviderTest.java 2a2ef0b0b7 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TargetClusterResourceProviderTest.java 492c012c7e 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TaskResourceProviderTest.java 365d408ff6 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TestIvoryProviderModule.java 90f10118d4 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java d6b1ab3766 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderDBTest.java c4f0f349fb 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderTest.java 9efad8a54d 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ValidationResourceProviderTest.java c639d1fcdc 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/WorkflowResourceProviderTest.java 337dc466da 
> 
> 
> Diff: https://reviews.apache.org/r/63516/diff/2/
> 
> 
> Testing
> -------
> 
> tests do not pass yet, also on deploy get errors in some places.
> Fixing mistakes
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 63516: [Preview] Remove properties.json And Switch To Adding Properties to ResourceProviders Dynamically

Posted by Nate Cole <nc...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63516/#review189988
-----------------------------------------------------------




ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActionResourceProvider.java
Lines 69-72 (patched)
<https://reviews.apache.org/r/63516/#comment267242>

    I don't think we ever change this map do we?  Can use ImmutableMap.builder().put()...build()
    
    Or, simple ones like this can be Collections.singletonMap(key, value)



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActionResourceProvider.java
Lines 77-87 (patched)
<https://reviews.apache.org/r/63516/#comment267241>

    Recommend Sets.newHashSet(String...) - it's much cleaner looking and avoids an added static{} block.


- Nate Cole


On Nov. 2, 2017, 12:11 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63516/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2017, 12:11 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-22353
>     https://issues.apache.org/jira/browse/AMBARI-22353
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Legacy/ancient ResourceProviders use the {{properties.json}} file to govern which properties can be used with the provider. This seems like excessive decoupling without any benefit and usually leads to runtime errors when new or removed properties are forgotten.
> 
> This file should be removed and the providers should be registering the known properties on their own.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java 711ae10f7e 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java 1dc0841d19 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractDRResourceProvider.java 953a2a7c77 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActionResourceProvider.java 4e618e7ff6 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java 73d24908ea 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java a2a49d7cb5 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java 737bfa4d46 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java c3758b3f5e 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionLinkResourceProvider.java db904bf714 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionResourceProvider.java 53e44e1888 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionVersionResourceProvider.java 4aa357c0e3 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/FeedResourceProvider.java f9d75fd353 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java f051651e12 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentProcessResourceProvider.java 2a25bc4d02 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java 6708560969 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java 5373ffe31c 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/InstanceResourceProvider.java d3a695ba08 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/JobResourceProvider.java e70c3674b4 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/KerberosDescriptorResourceProvider.java 93013415b4 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/LoggingResourceProvider.java d6afe7b22b 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/MemberResourceProvider.java d9d56eee8c 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RecommendationResourceProvider.java 70ed3dc09f 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java 81f283c55b 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestScheduleResourceProvider.java 4e25369a6e 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceComponentResourceProvider.java 3925aebdae 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceHostComponentResourceProvider.java c37bb2efe7 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceResourceProvider.java b24a94aee0 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackConfigurationDependencyResourceProvider.java 366b3ef052 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackConfigurationResourceProvider.java 6f5b0f8c02 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDependencyResourceProvider.java 8b69c6a312 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackLevelConfigurationResourceProvider.java 819507bffd 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackResourceProvider.java ead4f6df2b 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceComponentResourceProvider.java b9661bb409 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java 8727741d37 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackVersionResourceProvider.java 094c75bbb8 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TargetClusterResourceProvider.java d0c37f5a9e 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TaskAttemptResourceProvider.java 3af7bb15e5 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TaskResourceProvider.java 0b4fcd9633 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserResourceProvider.java c5c36e9942 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ValidationResourceProvider.java b78c64af53 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/WorkflowResourceProvider.java 13cb8a4768 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/PropertyHelper.java 893978047c 
>   ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java 5c5801d451 
>   ambari-server/src/main/resources/key_properties.json 5d76062d87 
>   ambari-server/src/main/resources/properties.json 1d12f83b3f 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProviderTest.java a127de6539 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractDRResourceProviderTest.java 38e6d366a1 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractResourceProviderTest.java 7165e48d70 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ActionResourceProviderTest.java ef56f9d3e7 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProviderTest.java 5221ecf16b 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java f53441182b 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java 833be5d117 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterKerberosDescriptorResourceProviderTest.java ac2847590d 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java 4a808931ac 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java 984010650c 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProviderTest.java 78f79ead9c 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ConfigurationResourceProviderTest.java 785ea2388b 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CredentialResourceProviderTest.java 89ed022da0 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ExtensionResourceProviderTest.java 5b6e830d6e 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/FeedResourceProviderTest.java 5cf9b056ea 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/GroupResourceProviderTest.java bbfa2d8503 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentProcessResourceProviderTest.java 5a7460d4c1 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java 7e32c15991 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java fd28081944 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProviderTest.java 6c95c53e5b 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/InstanceResourceProviderTest.java ba6793989e 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java e19ad29453 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JobResourceProviderTest.java 6fd1a238ae 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/KerberosDescriptorResourceProviderTest.java ca8127e42f 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/MemberResourceProviderTest.java 39ba4b9fe3 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java c0695b12d6 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestScheduleResourceProviderTest.java 6d4f72d9ad 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceComponentResourceProviderTest.java 222340b4e7 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceHostComponentResourceProviderTest.java ce3656c4ab 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceResourceProviderTest.java 96bc7c9674 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProviderTest.java 05232eac49 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackArtifactResourceProviderTest.java 21df88d545 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackConfigurationDependencyResourceProviderTest.java 7c88852f48 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackConfigurationResourceProviderTest.java 9c48ad0d23 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDependencyResourceProviderTest.java f35015348f 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackLevelConfigurationResourceProviderTest.java e9742bdfb1 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackResourceProviderTest.java 4281e3372e 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackServiceResourceProviderTest.java 2a2ef0b0b7 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TargetClusterResourceProviderTest.java 492c012c7e 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TaskResourceProviderTest.java 365d408ff6 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TestIvoryProviderModule.java 90f10118d4 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java d6b1ab3766 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderDBTest.java c4f0f349fb 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderTest.java 9efad8a54d 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ValidationResourceProviderTest.java c639d1fcdc 
> 
> 
> Diff: https://reviews.apache.org/r/63516/diff/1/
> 
> 
> Testing
> -------
> 
> tests do not pass yet, also on deploy get errors in some places.
> Fixing mistakes
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 63516: [Preview] Remove properties.json And Switch To Adding Properties to ResourceProviders Dynamically

Posted by Jonathan Hurley <jh...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63516/#review189926
-----------------------------------------------------------




ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java
Line 127 (original), 147 (patched)
<https://reviews.apache.org/r/63516/#comment267159>

    We need to make sure that all subclasses call the following method (which includes the type):
    
    ```
    AbstractAuthorizedResourceProvider(Resource.Type type, Set<String> propertyIds, Map<Resource.Type, String> keyPropertyIds) {
    ```
    
    See CompatibleRepositoryVersionResourceProvider as an example. 
    
    This is actually a bug if it doesn't pass the type since the default values are never associated with the resource type and the minimal values are never returned.
    
    In fact, we should probably just remove other constructures and force the use of this one so that subcllasses are forced to pass in the type.
    
    Same goes for subclasses of the ReadOnly provider ... it has this method too ...
    
    See AMBARI-20971 as an example...


- Jonathan Hurley


On Nov. 2, 2017, 12:11 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63516/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2017, 12:11 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-22353
>     https://issues.apache.org/jira/browse/AMBARI-22353
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Legacy/ancient ResourceProviders use the {{properties.json}} file to govern which properties can be used with the provider. This seems like excessive decoupling without any benefit and usually leads to runtime errors when new or removed properties are forgotten.
> 
> This file should be removed and the providers should be registering the known properties on their own.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java 711ae10f7e 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java 1dc0841d19 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractDRResourceProvider.java 953a2a7c77 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActionResourceProvider.java 4e618e7ff6 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java 73d24908ea 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java a2a49d7cb5 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java 737bfa4d46 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java c3758b3f5e 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionLinkResourceProvider.java db904bf714 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionResourceProvider.java 53e44e1888 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionVersionResourceProvider.java 4aa357c0e3 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/FeedResourceProvider.java f9d75fd353 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java f051651e12 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentProcessResourceProvider.java 2a25bc4d02 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java 6708560969 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java 5373ffe31c 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/InstanceResourceProvider.java d3a695ba08 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/JobResourceProvider.java e70c3674b4 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/KerberosDescriptorResourceProvider.java 93013415b4 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/LoggingResourceProvider.java d6afe7b22b 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/MemberResourceProvider.java d9d56eee8c 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RecommendationResourceProvider.java 70ed3dc09f 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java 81f283c55b 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestScheduleResourceProvider.java 4e25369a6e 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceComponentResourceProvider.java 3925aebdae 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceHostComponentResourceProvider.java c37bb2efe7 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceResourceProvider.java b24a94aee0 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackConfigurationDependencyResourceProvider.java 366b3ef052 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackConfigurationResourceProvider.java 6f5b0f8c02 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDependencyResourceProvider.java 8b69c6a312 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackLevelConfigurationResourceProvider.java 819507bffd 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackResourceProvider.java ead4f6df2b 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceComponentResourceProvider.java b9661bb409 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java 8727741d37 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackVersionResourceProvider.java 094c75bbb8 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TargetClusterResourceProvider.java d0c37f5a9e 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TaskAttemptResourceProvider.java 3af7bb15e5 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TaskResourceProvider.java 0b4fcd9633 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserResourceProvider.java c5c36e9942 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ValidationResourceProvider.java b78c64af53 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/WorkflowResourceProvider.java 13cb8a4768 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/PropertyHelper.java 893978047c 
>   ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java 5c5801d451 
>   ambari-server/src/main/resources/key_properties.json 5d76062d87 
>   ambari-server/src/main/resources/properties.json 1d12f83b3f 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProviderTest.java a127de6539 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractDRResourceProviderTest.java 38e6d366a1 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractResourceProviderTest.java 7165e48d70 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ActionResourceProviderTest.java ef56f9d3e7 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProviderTest.java 5221ecf16b 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java f53441182b 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java 833be5d117 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterKerberosDescriptorResourceProviderTest.java ac2847590d 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java 4a808931ac 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java 984010650c 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProviderTest.java 78f79ead9c 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ConfigurationResourceProviderTest.java 785ea2388b 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CredentialResourceProviderTest.java 89ed022da0 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ExtensionResourceProviderTest.java 5b6e830d6e 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/FeedResourceProviderTest.java 5cf9b056ea 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/GroupResourceProviderTest.java bbfa2d8503 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentProcessResourceProviderTest.java 5a7460d4c1 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java 7e32c15991 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java fd28081944 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProviderTest.java 6c95c53e5b 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/InstanceResourceProviderTest.java ba6793989e 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java e19ad29453 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JobResourceProviderTest.java 6fd1a238ae 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/KerberosDescriptorResourceProviderTest.java ca8127e42f 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/MemberResourceProviderTest.java 39ba4b9fe3 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java c0695b12d6 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestScheduleResourceProviderTest.java 6d4f72d9ad 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceComponentResourceProviderTest.java 222340b4e7 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceHostComponentResourceProviderTest.java ce3656c4ab 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceResourceProviderTest.java 96bc7c9674 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProviderTest.java 05232eac49 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackArtifactResourceProviderTest.java 21df88d545 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackConfigurationDependencyResourceProviderTest.java 7c88852f48 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackConfigurationResourceProviderTest.java 9c48ad0d23 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDependencyResourceProviderTest.java f35015348f 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackLevelConfigurationResourceProviderTest.java e9742bdfb1 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackResourceProviderTest.java 4281e3372e 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackServiceResourceProviderTest.java 2a2ef0b0b7 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TargetClusterResourceProviderTest.java 492c012c7e 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TaskResourceProviderTest.java 365d408ff6 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TestIvoryProviderModule.java 90f10118d4 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java d6b1ab3766 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderDBTest.java c4f0f349fb 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderTest.java 9efad8a54d 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ValidationResourceProviderTest.java c639d1fcdc 
> 
> 
> Diff: https://reviews.apache.org/r/63516/diff/1/
> 
> 
> Testing
> -------
> 
> tests do not pass yet, also on deploy get errors in some places.
> Fixing mistakes
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 63516: Remove properties.json And Switch To Adding Properties to ResourceProviders Dynamically

Posted by Nate Cole <nc...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63516/#review192704
-----------------------------------------------------------


Ship it!




Ship It!

- Nate Cole


On Dec. 4, 2017, 10:30 a.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63516/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2017, 10:30 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-22353
>     https://issues.apache.org/jira/browse/AMBARI-22353
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Legacy/ancient ResourceProviders use the {{properties.json}} file to govern which properties can be used with the provider. This seems like excessive decoupling without any benefit and usually leads to runtime errors when new or removed properties are forgotten.
> 
> This file should be removed and the providers should be registering the known properties on their own.
> 
> 
> Diffs
> -----
> 
>   ambari-logsearch/ambari-logsearch-server/src/test/java/org/apache/ambari/logsearch/web/security/LogsearchExternalServerAuthenticationProviderTest.java b6464c2d89 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java f6ca16bc69 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractAuthorizedResourceProvider.java a24c6394ac 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java cc2548cc61 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractDRResourceProvider.java 953a2a7c77 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActionResourceProvider.java 290931555e 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProvider.java 389f0b2bf2 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java 9579dca47d 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProvider.java 0898bc3bee 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertHistoryResourceProvider.java 8d716eabe0 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertNoticeResourceProvider.java 8ffd596cfa 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java 4ab78b7ba6 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java c1e9eb42a0 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProvider.java 0ffceca84f 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java 8f4d62e032 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java f0ede5ddea 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterKerberosDescriptorResourceProvider.java 2678d55975 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterPrivilegeResourceProvider.java 60cf783940 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java b9b3b5668c 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 1c36c96cc0 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java 737bfa4d46 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigurationResourceProvider.java 0f260854f8 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CredentialResourceProvider.java ebc7645828 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java c3758b3f5e 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionLinkResourceProvider.java db904bf714 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionResourceProvider.java 53e44e1888 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionVersionResourceProvider.java 4aa357c0e3 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/FeedResourceProvider.java f9d75fd353 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupPrivilegeResourceProvider.java f9f838fe22 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java 6cdd24e967 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentProcessResourceProvider.java 2a25bc4d02 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java 94766a5df6 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostKerberosIdentityResourceProvider.java 06725003bf 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java 5c740f1f17 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java 48e9f59601 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/InstanceResourceProvider.java d3a695ba08 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/JobResourceProvider.java e70c3674b4 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/KerberosDescriptorResourceProvider.java 93013415b4 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/LdapSyncEventResourceProvider.java fc409a3ed6 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/LoggingResourceProvider.java d6afe7b22b 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/MemberResourceProvider.java 3cecddb032 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/OperatingSystemResourceProvider.java 174fdf60a0 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PermissionResourceProvider.java 43cdf2b39b 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PrivilegeResourceProvider.java fabce6b379 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/QuickLinkArtifactResourceProvider.java f293941255 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ReadOnlyResourceProvider.java 505ec637ed 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RecommendationResourceProvider.java 9c6259cc92 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RemoteClusterResourceProvider.java 0b2d2b3f52 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java 26e3b86a2b 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestScheduleResourceProvider.java 4e25369a6e 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RoleAuthorizationResourceProvider.java 8dbe2bf712 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceComponentConfigurationResourceProvider.java b9e7d67aef 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceComponentResourceProvider.java dfca00e6aa 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceHostComponentResourceProvider.java c37bb2efe7 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceResourceProvider.java b24a94aee0 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceConfigVersionResourceProvider.java e7dbbc0389 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/SettingResourceProvider.java 5235ef4fb1 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProvider.java 67c177e65e 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackArtifactResourceProvider.java d042f8648e 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackConfigurationDependencyResourceProvider.java 366b3ef052 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackConfigurationResourceProvider.java 6f5b0f8c02 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDependencyResourceProvider.java 8b69c6a312 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackLevelConfigurationResourceProvider.java 819507bffd 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackResourceProvider.java ead4f6df2b 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceComponentResourceProvider.java b9661bb409 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java 8727741d37 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackVersionResourceProvider.java 094c75bbb8 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StageResourceProvider.java c4251c1b3b 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TargetClusterResourceProvider.java d0c37f5a9e 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TaskAttemptResourceProvider.java 3af7bb15e5 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TaskResourceProvider.java 39419ec1df 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ThemeArtifactResourceProvider.java affd969bcd 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeGroupResourceProvider.java e6aafc1ec5 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeItemResourceProvider.java 93b3e46094 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java bab5369845 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeSummaryResourceProvider.java 94b2b4a981 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserAuthorizationResourceProvider.java 95550f0299 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProvider.java 614f7abda1 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserResourceProvider.java 698f419c33 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ValidationResourceProvider.java 5448784ea8 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java c34c94d181 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java 9562782b01 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewPermissionResourceProvider.java c1846bbe91 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewPrivilegeResourceProvider.java eb57759108 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewResourceProvider.java 7179b335c2 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewURLResourceProvider.java cb506be1bf 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewVersionResourceProvider.java e0812fa4eb 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/WidgetLayoutResourceProvider.java 8c39fc4057 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/WidgetResourceProvider.java 03fd5d2359 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/WorkflowResourceProvider.java 13cb8a4768 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/PropertyHelper.java 893978047c 
>   ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java 5c5801d451 
>   ambari-server/src/main/resources/key_properties.json 5d76062d87 
>   ambari-server/src/main/resources/properties.json 1d12f83b3f 
>   ambari-server/src/test/java/org/apache/ambari/server/api/query/render/MinimalRendererTest.java 782f148c56 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProviderTest.java a127de6539 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractDRResourceProviderTest.java 38e6d366a1 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractResourceProviderTest.java 7165e48d70 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ActionResourceProviderTest.java ef56f9d3e7 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProviderTest.java 5221ecf16b 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java f53441182b 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java 6779e26f2d 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterControllerImplTest.java 7cbb4b74c1 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterKerberosDescriptorResourceProviderTest.java ac2847590d 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java 4a808931ac 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java a6fc919d91 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProviderTest.java 78f79ead9c 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ConfigurationResourceProviderTest.java 785ea2388b 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CredentialResourceProviderTest.java 89ed022da0 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ExtensionResourceProviderTest.java 5b6e830d6e 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/FeedResourceProviderTest.java 5cf9b056ea 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/GroupResourceProviderTest.java bbfa2d8503 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentProcessResourceProviderTest.java 5a7460d4c1 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java 7e32c15991 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java 5e6201bcd1 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProviderTest.java 6c95c53e5b 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/InstanceResourceProviderTest.java ba6793989e 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java e19ad29453 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JobResourceProviderTest.java 6fd1a238ae 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/KerberosDescriptorResourceProviderTest.java ca8127e42f 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/MemberResourceProviderTest.java 39ba4b9fe3 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java c0695b12d6 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestScheduleResourceProviderTest.java 6d4f72d9ad 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceComponentResourceProviderTest.java 4316647e8e 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceHostComponentResourceProviderTest.java ce3656c4ab 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceResourceProviderTest.java 96bc7c9674 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProviderTest.java 05232eac49 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackArtifactResourceProviderTest.java 21df88d545 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackConfigurationDependencyResourceProviderTest.java 7c88852f48 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackConfigurationResourceProviderTest.java 9c48ad0d23 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDependencyResourceProviderTest.java f35015348f 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackLevelConfigurationResourceProviderTest.java e9742bdfb1 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackResourceProviderTest.java 4281e3372e 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackServiceResourceProviderTest.java 2a2ef0b0b7 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TargetClusterResourceProviderTest.java 492c012c7e 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TaskAttemptResourceProviderTest.java 992bce0936 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TaskResourceProviderTest.java 365d408ff6 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TestIvoryProviderModule.java 90f10118d4 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java ec240df800 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderDBTest.java c4f0f349fb 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderTest.java 9efad8a54d 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ValidationResourceProviderTest.java 42d4770a25 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/WorkflowResourceProviderTest.java 337dc466da 
> 
> 
> Diff: https://reviews.apache.org/r/63516/diff/5/
> 
> 
> Testing
> -------
> 
> tests pass
> checked live cluster deploy and EU
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 63516: Remove properties.json And Switch To Adding Properties to ResourceProviders Dynamically

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63516/
-----------------------------------------------------------

(Updated Dec. 4, 2017, 5:30 p.m.)


Review request for Ambari, Jonathan Hurley and Nate Cole.


Changes
-------

Merged with trunk, fixed unit tests, checked deploy and EU


Summary (updated)
-----------------

Remove properties.json And Switch To Adding Properties to ResourceProviders Dynamically


Bugs: AMBARI-22353
    https://issues.apache.org/jira/browse/AMBARI-22353


Repository: ambari


Description
-------

Legacy/ancient ResourceProviders use the {{properties.json}} file to govern which properties can be used with the provider. This seems like excessive decoupling without any benefit and usually leads to runtime errors when new or removed properties are forgotten.

This file should be removed and the providers should be registering the known properties on their own.


Diffs (updated)
-----

  ambari-logsearch/ambari-logsearch-server/src/test/java/org/apache/ambari/logsearch/web/security/LogsearchExternalServerAuthenticationProviderTest.java b6464c2d89 
  ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java f6ca16bc69 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractAuthorizedResourceProvider.java a24c6394ac 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java cc2548cc61 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractDRResourceProvider.java 953a2a7c77 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActionResourceProvider.java 290931555e 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProvider.java 389f0b2bf2 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java 9579dca47d 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProvider.java 0898bc3bee 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertHistoryResourceProvider.java 8d716eabe0 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertNoticeResourceProvider.java 8ffd596cfa 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java 4ab78b7ba6 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java c1e9eb42a0 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProvider.java 0ffceca84f 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java 8f4d62e032 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java f0ede5ddea 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterKerberosDescriptorResourceProvider.java 2678d55975 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterPrivilegeResourceProvider.java 60cf783940 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java b9b3b5668c 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 1c36c96cc0 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java 737bfa4d46 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigurationResourceProvider.java 0f260854f8 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CredentialResourceProvider.java ebc7645828 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java c3758b3f5e 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionLinkResourceProvider.java db904bf714 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionResourceProvider.java 53e44e1888 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionVersionResourceProvider.java 4aa357c0e3 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/FeedResourceProvider.java f9d75fd353 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupPrivilegeResourceProvider.java f9f838fe22 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java 6cdd24e967 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentProcessResourceProvider.java 2a25bc4d02 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java 94766a5df6 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostKerberosIdentityResourceProvider.java 06725003bf 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java 5c740f1f17 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java 48e9f59601 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/InstanceResourceProvider.java d3a695ba08 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/JobResourceProvider.java e70c3674b4 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/KerberosDescriptorResourceProvider.java 93013415b4 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/LdapSyncEventResourceProvider.java fc409a3ed6 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/LoggingResourceProvider.java d6afe7b22b 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/MemberResourceProvider.java 3cecddb032 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/OperatingSystemResourceProvider.java 174fdf60a0 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PermissionResourceProvider.java 43cdf2b39b 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PrivilegeResourceProvider.java fabce6b379 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/QuickLinkArtifactResourceProvider.java f293941255 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ReadOnlyResourceProvider.java 505ec637ed 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RecommendationResourceProvider.java 9c6259cc92 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RemoteClusterResourceProvider.java 0b2d2b3f52 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java 26e3b86a2b 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestScheduleResourceProvider.java 4e25369a6e 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RoleAuthorizationResourceProvider.java 8dbe2bf712 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceComponentConfigurationResourceProvider.java b9e7d67aef 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceComponentResourceProvider.java dfca00e6aa 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceHostComponentResourceProvider.java c37bb2efe7 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceResourceProvider.java b24a94aee0 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceConfigVersionResourceProvider.java e7dbbc0389 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/SettingResourceProvider.java 5235ef4fb1 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProvider.java 67c177e65e 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackArtifactResourceProvider.java d042f8648e 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackConfigurationDependencyResourceProvider.java 366b3ef052 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackConfigurationResourceProvider.java 6f5b0f8c02 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDependencyResourceProvider.java 8b69c6a312 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackLevelConfigurationResourceProvider.java 819507bffd 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackResourceProvider.java ead4f6df2b 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceComponentResourceProvider.java b9661bb409 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java 8727741d37 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackVersionResourceProvider.java 094c75bbb8 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StageResourceProvider.java c4251c1b3b 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TargetClusterResourceProvider.java d0c37f5a9e 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TaskAttemptResourceProvider.java 3af7bb15e5 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TaskResourceProvider.java 39419ec1df 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ThemeArtifactResourceProvider.java affd969bcd 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeGroupResourceProvider.java e6aafc1ec5 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeItemResourceProvider.java 93b3e46094 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java bab5369845 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeSummaryResourceProvider.java 94b2b4a981 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserAuthorizationResourceProvider.java 95550f0299 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProvider.java 614f7abda1 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserResourceProvider.java 698f419c33 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ValidationResourceProvider.java 5448784ea8 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java c34c94d181 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java 9562782b01 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewPermissionResourceProvider.java c1846bbe91 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewPrivilegeResourceProvider.java eb57759108 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewResourceProvider.java 7179b335c2 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewURLResourceProvider.java cb506be1bf 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewVersionResourceProvider.java e0812fa4eb 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/WidgetLayoutResourceProvider.java 8c39fc4057 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/WidgetResourceProvider.java 03fd5d2359 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/WorkflowResourceProvider.java 13cb8a4768 
  ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/PropertyHelper.java 893978047c 
  ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java 5c5801d451 
  ambari-server/src/main/resources/key_properties.json 5d76062d87 
  ambari-server/src/main/resources/properties.json 1d12f83b3f 
  ambari-server/src/test/java/org/apache/ambari/server/api/query/render/MinimalRendererTest.java 782f148c56 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProviderTest.java a127de6539 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractDRResourceProviderTest.java 38e6d366a1 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractResourceProviderTest.java 7165e48d70 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ActionResourceProviderTest.java ef56f9d3e7 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProviderTest.java 5221ecf16b 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java f53441182b 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java 6779e26f2d 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterControllerImplTest.java 7cbb4b74c1 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterKerberosDescriptorResourceProviderTest.java ac2847590d 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java 4a808931ac 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java a6fc919d91 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProviderTest.java 78f79ead9c 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ConfigurationResourceProviderTest.java 785ea2388b 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CredentialResourceProviderTest.java 89ed022da0 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ExtensionResourceProviderTest.java 5b6e830d6e 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/FeedResourceProviderTest.java 5cf9b056ea 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/GroupResourceProviderTest.java bbfa2d8503 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentProcessResourceProviderTest.java 5a7460d4c1 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java 7e32c15991 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java 5e6201bcd1 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProviderTest.java 6c95c53e5b 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/InstanceResourceProviderTest.java ba6793989e 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java e19ad29453 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JobResourceProviderTest.java 6fd1a238ae 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/KerberosDescriptorResourceProviderTest.java ca8127e42f 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/MemberResourceProviderTest.java 39ba4b9fe3 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java c0695b12d6 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestScheduleResourceProviderTest.java 6d4f72d9ad 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceComponentResourceProviderTest.java 4316647e8e 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceHostComponentResourceProviderTest.java ce3656c4ab 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceResourceProviderTest.java 96bc7c9674 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProviderTest.java 05232eac49 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackArtifactResourceProviderTest.java 21df88d545 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackConfigurationDependencyResourceProviderTest.java 7c88852f48 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackConfigurationResourceProviderTest.java 9c48ad0d23 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDependencyResourceProviderTest.java f35015348f 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackLevelConfigurationResourceProviderTest.java e9742bdfb1 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackResourceProviderTest.java 4281e3372e 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackServiceResourceProviderTest.java 2a2ef0b0b7 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TargetClusterResourceProviderTest.java 492c012c7e 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TaskAttemptResourceProviderTest.java 992bce0936 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TaskResourceProviderTest.java 365d408ff6 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TestIvoryProviderModule.java 90f10118d4 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java ec240df800 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderDBTest.java c4f0f349fb 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderTest.java 9efad8a54d 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ValidationResourceProviderTest.java 42d4770a25 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/WorkflowResourceProviderTest.java 337dc466da 


Diff: https://reviews.apache.org/r/63516/diff/5/

Changes: https://reviews.apache.org/r/63516/diff/4-5/


Testing (updated)
-------

tests pass
checked live cluster deploy and EU


Thanks,

Dmitro Lisnichenko

Re: Review Request 63516: [Preview] Remove properties.json And Switch To Adding Properties to ResourceProviders Dynamically

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63516/
-----------------------------------------------------------

(Updated Dec. 1, 2017, 12:34 p.m.)


Review request for Ambari, Jonathan Hurley and Nate Cole.


Changes
-------

Current patch state. Deploy still does not pass, fixing


Bugs: AMBARI-22353
    https://issues.apache.org/jira/browse/AMBARI-22353


Repository: ambari


Description
-------

Legacy/ancient ResourceProviders use the {{properties.json}} file to govern which properties can be used with the provider. This seems like excessive decoupling without any benefit and usually leads to runtime errors when new or removed properties are forgotten.

This file should be removed and the providers should be registering the known properties on their own.


Diffs (updated)
-----

  ambari-logsearch/ambari-logsearch-server/src/test/java/org/apache/ambari/logsearch/web/security/LogsearchExternalServerAuthenticationProviderTest.java b6464c2d89 
  ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java f6ca16bc69 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractAuthorizedResourceProvider.java a24c6394ac 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java cc2548cc61 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractDRResourceProvider.java 953a2a7c77 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActionResourceProvider.java 290931555e 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProvider.java 389f0b2bf2 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java 9579dca47d 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProvider.java 0898bc3bee 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertHistoryResourceProvider.java 8d716eabe0 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertNoticeResourceProvider.java 8ffd596cfa 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java 4ab78b7ba6 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java c1e9eb42a0 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProvider.java 0ffceca84f 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java 67f5448826 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java f0ede5ddea 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterKerberosDescriptorResourceProvider.java 2678d55975 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterPrivilegeResourceProvider.java 60cf783940 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java b9b3b5668c 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 1c36c96cc0 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java 737bfa4d46 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigurationResourceProvider.java 0f260854f8 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CredentialResourceProvider.java ebc7645828 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java c3758b3f5e 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionLinkResourceProvider.java db904bf714 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionResourceProvider.java 53e44e1888 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionVersionResourceProvider.java 4aa357c0e3 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/FeedResourceProvider.java f9d75fd353 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupPrivilegeResourceProvider.java f9f838fe22 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java 6cdd24e967 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentProcessResourceProvider.java 2a25bc4d02 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java 94766a5df6 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostKerberosIdentityResourceProvider.java 06725003bf 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java 2b18eb289d 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java 48e9f59601 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/InstanceResourceProvider.java d3a695ba08 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/JobResourceProvider.java e70c3674b4 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/KerberosDescriptorResourceProvider.java 93013415b4 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/LdapSyncEventResourceProvider.java fc409a3ed6 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/LoggingResourceProvider.java d6afe7b22b 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/MemberResourceProvider.java 3cecddb032 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/OperatingSystemResourceProvider.java 174fdf60a0 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PermissionResourceProvider.java 43cdf2b39b 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PrivilegeResourceProvider.java fabce6b379 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/QuickLinkArtifactResourceProvider.java f293941255 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ReadOnlyResourceProvider.java 505ec637ed 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RecommendationResourceProvider.java 9c6259cc92 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RemoteClusterResourceProvider.java 0b2d2b3f52 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java 26e3b86a2b 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestScheduleResourceProvider.java 4e25369a6e 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RoleAuthorizationResourceProvider.java 8dbe2bf712 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceComponentConfigurationResourceProvider.java 78078652f0 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceComponentResourceProvider.java dfca00e6aa 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceHostComponentResourceProvider.java c37bb2efe7 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceResourceProvider.java b24a94aee0 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceConfigVersionResourceProvider.java e7dbbc0389 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/SettingResourceProvider.java 5235ef4fb1 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProvider.java 1ea664cbc8 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackArtifactResourceProvider.java d042f8648e 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackConfigurationDependencyResourceProvider.java 366b3ef052 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackConfigurationResourceProvider.java 6f5b0f8c02 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDependencyResourceProvider.java 8b69c6a312 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackLevelConfigurationResourceProvider.java 819507bffd 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackResourceProvider.java ead4f6df2b 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceComponentResourceProvider.java b9661bb409 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java 8727741d37 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackVersionResourceProvider.java 094c75bbb8 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StageResourceProvider.java c4251c1b3b 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TargetClusterResourceProvider.java d0c37f5a9e 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TaskAttemptResourceProvider.java 3af7bb15e5 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TaskResourceProvider.java 39419ec1df 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ThemeArtifactResourceProvider.java affd969bcd 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeGroupResourceProvider.java e6aafc1ec5 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeItemResourceProvider.java 93b3e46094 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java e4dd441ef5 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeSummaryResourceProvider.java 94b2b4a981 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserAuthorizationResourceProvider.java 95550f0299 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProvider.java 614f7abda1 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserResourceProvider.java 698f419c33 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ValidationResourceProvider.java 5448784ea8 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java c34c94d181 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java 9562782b01 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewPermissionResourceProvider.java c1846bbe91 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewPrivilegeResourceProvider.java eb57759108 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewResourceProvider.java 7179b335c2 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewURLResourceProvider.java cb506be1bf 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewVersionResourceProvider.java e0812fa4eb 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/WidgetLayoutResourceProvider.java 8c39fc4057 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/WidgetResourceProvider.java 03fd5d2359 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/WorkflowResourceProvider.java 13cb8a4768 
  ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/PropertyHelper.java 893978047c 
  ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java 5c5801d451 
  ambari-server/src/main/resources/key_properties.json 5d76062d87 
  ambari-server/src/main/resources/properties.json 1d12f83b3f 
  ambari-server/src/test/java/org/apache/ambari/server/api/query/render/MinimalRendererTest.java 782f148c56 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProviderTest.java a127de6539 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractDRResourceProviderTest.java 38e6d366a1 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractResourceProviderTest.java 7165e48d70 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ActionResourceProviderTest.java ef56f9d3e7 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProviderTest.java 5221ecf16b 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java f53441182b 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java 6779e26f2d 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterControllerImplTest.java 7cbb4b74c1 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterKerberosDescriptorResourceProviderTest.java ac2847590d 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java 4a808931ac 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java a6fc919d91 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProviderTest.java 78f79ead9c 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ConfigurationResourceProviderTest.java 785ea2388b 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CredentialResourceProviderTest.java 89ed022da0 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ExtensionResourceProviderTest.java 5b6e830d6e 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/FeedResourceProviderTest.java 5cf9b056ea 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/GroupResourceProviderTest.java bbfa2d8503 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentProcessResourceProviderTest.java 5a7460d4c1 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java 7e32c15991 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java fd28081944 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProviderTest.java 6c95c53e5b 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/InstanceResourceProviderTest.java ba6793989e 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java e19ad29453 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JobResourceProviderTest.java 6fd1a238ae 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/KerberosDescriptorResourceProviderTest.java ca8127e42f 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/MemberResourceProviderTest.java 39ba4b9fe3 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java c0695b12d6 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestScheduleResourceProviderTest.java 6d4f72d9ad 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceComponentResourceProviderTest.java 4316647e8e 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceHostComponentResourceProviderTest.java ce3656c4ab 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceResourceProviderTest.java 96bc7c9674 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProviderTest.java 05232eac49 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackArtifactResourceProviderTest.java 21df88d545 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackConfigurationDependencyResourceProviderTest.java 7c88852f48 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackConfigurationResourceProviderTest.java 9c48ad0d23 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDependencyResourceProviderTest.java f35015348f 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackLevelConfigurationResourceProviderTest.java e9742bdfb1 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackResourceProviderTest.java 4281e3372e 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackServiceResourceProviderTest.java 2a2ef0b0b7 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TargetClusterResourceProviderTest.java 492c012c7e 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TaskAttemptResourceProviderTest.java 992bce0936 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TaskResourceProviderTest.java 365d408ff6 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TestIvoryProviderModule.java 90f10118d4 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java ec240df800 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderDBTest.java c4f0f349fb 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderTest.java 9efad8a54d 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ValidationResourceProviderTest.java c639d1fcdc 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/WorkflowResourceProviderTest.java 337dc466da 


Diff: https://reviews.apache.org/r/63516/diff/4/

Changes: https://reviews.apache.org/r/63516/diff/3-4/


Testing
-------

tests do not pass yet, also on deploy get errors in some places.
Fixing mistakes


Thanks,

Dmitro Lisnichenko

Re: Review Request 63516: [Preview] Remove properties.json And Switch To Adding Properties to ResourceProviders Dynamically

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63516/
-----------------------------------------------------------

(Updated Nov. 21, 2017, 8:02 p.m.)


Review request for Ambari, Jonathan Hurley and Nate Cole.


Changes
-------

Current patch state. Still a preview


Bugs: AMBARI-22353
    https://issues.apache.org/jira/browse/AMBARI-22353


Repository: ambari


Description
-------

Legacy/ancient ResourceProviders use the {{properties.json}} file to govern which properties can be used with the provider. This seems like excessive decoupling without any benefit and usually leads to runtime errors when new or removed properties are forgotten.

This file should be removed and the providers should be registering the known properties on their own.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java 711ae10f7e 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractAuthorizedResourceProvider.java a24c6394ac 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java 1dc0841d19 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractDRResourceProvider.java 953a2a7c77 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActionResourceProvider.java 4e618e7ff6 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProvider.java 389f0b2bf2 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java 32f1fd8f4f 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProvider.java cf4e7475b3 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertHistoryResourceProvider.java 8d716eabe0 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertNoticeResourceProvider.java 8ffd596cfa 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java c71651e5ff 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java 43ee7fe7c7 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AmbariConfigurationResourceProvider.java 4f4cc7070d 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java 73d24908ea 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java a2a49d7cb5 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterKerberosDescriptorResourceProvider.java 2678d55975 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java 54c83600b7 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 98adcd112d 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java 737bfa4d46 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigurationResourceProvider.java 0f260854f8 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CredentialResourceProvider.java 79254c6d89 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java c3758b3f5e 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionLinkResourceProvider.java db904bf714 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionResourceProvider.java 53e44e1888 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionVersionResourceProvider.java 4aa357c0e3 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/FeedResourceProvider.java f9d75fd353 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupPrivilegeResourceProvider.java f9f838fe22 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java f051651e12 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentProcessResourceProvider.java 2a25bc4d02 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java 6708560969 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostKerberosIdentityResourceProvider.java 06725003bf 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java 5373ffe31c 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java b1062090e1 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/InstanceResourceProvider.java d3a695ba08 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/JobResourceProvider.java e70c3674b4 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/KerberosDescriptorResourceProvider.java 93013415b4 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/LdapSyncEventResourceProvider.java 4badc9c472 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/LoggingResourceProvider.java d6afe7b22b 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/MemberResourceProvider.java d9d56eee8c 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/OperatingSystemResourceProvider.java 174fdf60a0 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PrivilegeResourceProvider.java fabce6b379 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/QuickLinkArtifactResourceProvider.java 073ec60b27 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ReadOnlyResourceProvider.java 505ec637ed 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RecommendationResourceProvider.java 70ed3dc09f 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RemoteClusterResourceProvider.java 0b2d2b3f52 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java 81f283c55b 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestScheduleResourceProvider.java 4e25369a6e 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RoleAuthorizationResourceProvider.java 78eb80e8d1 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceComponentResourceProvider.java 3925aebdae 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceHostComponentResourceProvider.java c37bb2efe7 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceResourceProvider.java b24a94aee0 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceConfigVersionResourceProvider.java e7dbbc0389 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/SettingResourceProvider.java 5235ef4fb1 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProvider.java 7035f0a148 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackArtifactResourceProvider.java 6bb421b67b 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackConfigurationDependencyResourceProvider.java 366b3ef052 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackConfigurationResourceProvider.java 6f5b0f8c02 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDependencyResourceProvider.java 8b69c6a312 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackLevelConfigurationResourceProvider.java 819507bffd 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackResourceProvider.java ead4f6df2b 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceComponentResourceProvider.java b9661bb409 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java 8727741d37 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackVersionResourceProvider.java 094c75bbb8 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StageResourceProvider.java 6a326b5338 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TargetClusterResourceProvider.java d0c37f5a9e 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TaskAttemptResourceProvider.java 3af7bb15e5 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TaskResourceProvider.java 0b4fcd9633 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ThemeArtifactResourceProvider.java fc7cfe7f91 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeGroupResourceProvider.java e6aafc1ec5 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeItemResourceProvider.java 36eb3bebf1 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java d4111d63ac 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeSummaryResourceProvider.java 94b2b4a981 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserAuthorizationResourceProvider.java 95550f0299 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProvider.java 614f7abda1 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserResourceProvider.java c5c36e9942 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ValidationResourceProvider.java b78c64af53 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java f94ac32f17 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java 9562782b01 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewResourceProvider.java 7179b335c2 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewURLResourceProvider.java cb506be1bf 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/WidgetLayoutResourceProvider.java 8c39fc4057 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/WidgetResourceProvider.java 03fd5d2359 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/WorkflowResourceProvider.java 13cb8a4768 
  ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/PropertyHelper.java 893978047c 
  ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java 5c5801d451 
  ambari-server/src/main/resources/key_properties.json 5d76062d87 
  ambari-server/src/main/resources/properties.json 1d12f83b3f 
  ambari-server/src/test/java/org/apache/ambari/server/api/query/render/MinimalRendererTest.java 782f148c56 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProviderTest.java a127de6539 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractDRResourceProviderTest.java 38e6d366a1 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractResourceProviderTest.java 7165e48d70 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ActionResourceProviderTest.java ef56f9d3e7 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProviderTest.java 5221ecf16b 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java f53441182b 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java 833be5d117 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterControllerImplTest.java 7cbb4b74c1 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterKerberosDescriptorResourceProviderTest.java ac2847590d 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java 4a808931ac 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java f45ff75bb1 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProviderTest.java 78f79ead9c 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ConfigurationResourceProviderTest.java 785ea2388b 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CredentialResourceProviderTest.java 89ed022da0 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ExtensionResourceProviderTest.java 5b6e830d6e 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/FeedResourceProviderTest.java 5cf9b056ea 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/GroupResourceProviderTest.java bbfa2d8503 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentProcessResourceProviderTest.java 5a7460d4c1 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java 7e32c15991 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java fd28081944 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProviderTest.java 6c95c53e5b 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/InstanceResourceProviderTest.java ba6793989e 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java e19ad29453 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JobResourceProviderTest.java 6fd1a238ae 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/KerberosDescriptorResourceProviderTest.java ca8127e42f 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/MemberResourceProviderTest.java 39ba4b9fe3 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java c0695b12d6 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestScheduleResourceProviderTest.java 6d4f72d9ad 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceComponentResourceProviderTest.java 222340b4e7 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceHostComponentResourceProviderTest.java ce3656c4ab 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceResourceProviderTest.java 96bc7c9674 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProviderTest.java 05232eac49 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackArtifactResourceProviderTest.java 21df88d545 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackConfigurationDependencyResourceProviderTest.java 7c88852f48 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackConfigurationResourceProviderTest.java 9c48ad0d23 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDependencyResourceProviderTest.java f35015348f 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackLevelConfigurationResourceProviderTest.java e9742bdfb1 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackResourceProviderTest.java 4281e3372e 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackServiceResourceProviderTest.java 2a2ef0b0b7 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TargetClusterResourceProviderTest.java 492c012c7e 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TaskAttemptResourceProviderTest.java 992bce0936 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TaskResourceProviderTest.java 365d408ff6 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TestIvoryProviderModule.java 90f10118d4 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 64d416f252 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderDBTest.java c4f0f349fb 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderTest.java 9efad8a54d 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ValidationResourceProviderTest.java c639d1fcdc 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/WorkflowResourceProviderTest.java 337dc466da 


Diff: https://reviews.apache.org/r/63516/diff/3/

Changes: https://reviews.apache.org/r/63516/diff/2-3/


Testing
-------

tests do not pass yet, also on deploy get errors in some places.
Fixing mistakes


Thanks,

Dmitro Lisnichenko

Re: Review Request 63516: [Preview] Remove properties.json And Switch To Adding Properties to ResourceProviders Dynamically

Posted by Jonathan Hurley <jh...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63516/#review190668
-----------------------------------------------------------


Ship it!




Ship It!

- Jonathan Hurley


On Nov. 9, 2017, 4:58 a.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63516/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2017, 4:58 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-22353
>     https://issues.apache.org/jira/browse/AMBARI-22353
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Legacy/ancient ResourceProviders use the {{properties.json}} file to govern which properties can be used with the provider. This seems like excessive decoupling without any benefit and usually leads to runtime errors when new or removed properties are forgotten.
> 
> This file should be removed and the providers should be registering the known properties on their own.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java 711ae10f7e 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractAuthorizedResourceProvider.java a24c6394ac 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java 1dc0841d19 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractDRResourceProvider.java 953a2a7c77 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActionResourceProvider.java 4e618e7ff6 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProvider.java 389f0b2bf2 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java 32f1fd8f4f 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProvider.java cf4e7475b3 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertHistoryResourceProvider.java 8d716eabe0 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertNoticeResourceProvider.java 8ffd596cfa 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java c71651e5ff 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java 43ee7fe7c7 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AmbariConfigurationResourceProvider.java 4f4cc7070d 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java 73d24908ea 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java a2a49d7cb5 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterKerberosDescriptorResourceProvider.java 2678d55975 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java 54c83600b7 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 1a755590b7 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java 737bfa4d46 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigurationResourceProvider.java 0f260854f8 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CredentialResourceProvider.java 79254c6d89 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java c3758b3f5e 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionLinkResourceProvider.java db904bf714 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionResourceProvider.java 53e44e1888 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionVersionResourceProvider.java 4aa357c0e3 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/FeedResourceProvider.java f9d75fd353 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupPrivilegeResourceProvider.java f9f838fe22 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java f051651e12 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentProcessResourceProvider.java 2a25bc4d02 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java 6708560969 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostKerberosIdentityResourceProvider.java bfaf7b4a4f 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java 5373ffe31c 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java ba5fccc1dc 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/InstanceResourceProvider.java d3a695ba08 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/JobResourceProvider.java e70c3674b4 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/KerberosDescriptorResourceProvider.java 93013415b4 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/LdapSyncEventResourceProvider.java 4badc9c472 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/LoggingResourceProvider.java d6afe7b22b 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/MemberResourceProvider.java d9d56eee8c 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/OperatingSystemResourceProvider.java 174fdf60a0 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PrivilegeResourceProvider.java fabce6b379 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/QuickLinkArtifactResourceProvider.java 073ec60b27 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ReadOnlyResourceProvider.java 505ec637ed 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RecommendationResourceProvider.java 70ed3dc09f 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RemoteClusterResourceProvider.java 0b2d2b3f52 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java 81f283c55b 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestScheduleResourceProvider.java 4e25369a6e 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RoleAuthorizationResourceProvider.java 78eb80e8d1 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceComponentResourceProvider.java 3925aebdae 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceHostComponentResourceProvider.java c37bb2efe7 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceResourceProvider.java b24a94aee0 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceConfigVersionResourceProvider.java e7dbbc0389 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/SettingResourceProvider.java 5235ef4fb1 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProvider.java 7035f0a148 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackArtifactResourceProvider.java 6bb421b67b 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackConfigurationDependencyResourceProvider.java 366b3ef052 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackConfigurationResourceProvider.java 6f5b0f8c02 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDependencyResourceProvider.java 8b69c6a312 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackLevelConfigurationResourceProvider.java 819507bffd 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackResourceProvider.java ead4f6df2b 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceComponentResourceProvider.java b9661bb409 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java 8727741d37 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackVersionResourceProvider.java 094c75bbb8 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StageResourceProvider.java 6a326b5338 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TargetClusterResourceProvider.java d0c37f5a9e 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TaskAttemptResourceProvider.java 3af7bb15e5 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TaskResourceProvider.java 0b4fcd9633 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ThemeArtifactResourceProvider.java fc7cfe7f91 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeGroupResourceProvider.java e6aafc1ec5 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeItemResourceProvider.java 36eb3bebf1 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java a1ec98afe7 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeSummaryResourceProvider.java 94b2b4a981 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserAuthorizationResourceProvider.java 95550f0299 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProvider.java 614f7abda1 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserResourceProvider.java c5c36e9942 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ValidationResourceProvider.java b78c64af53 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java f94ac32f17 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java 9562782b01 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewResourceProvider.java 7179b335c2 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewURLResourceProvider.java cb506be1bf 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/WidgetLayoutResourceProvider.java 8c39fc4057 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/WidgetResourceProvider.java 03fd5d2359 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/WorkflowResourceProvider.java 13cb8a4768 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/PropertyHelper.java 893978047c 
>   ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java 5c5801d451 
>   ambari-server/src/main/resources/key_properties.json 5d76062d87 
>   ambari-server/src/main/resources/properties.json 1d12f83b3f 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProviderTest.java a127de6539 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractDRResourceProviderTest.java 38e6d366a1 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractResourceProviderTest.java 7165e48d70 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ActionResourceProviderTest.java ef56f9d3e7 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProviderTest.java 5221ecf16b 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java f53441182b 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java 833be5d117 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterKerberosDescriptorResourceProviderTest.java ac2847590d 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java 4a808931ac 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java 984010650c 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProviderTest.java 78f79ead9c 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ConfigurationResourceProviderTest.java 785ea2388b 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CredentialResourceProviderTest.java 89ed022da0 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ExtensionResourceProviderTest.java 5b6e830d6e 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/FeedResourceProviderTest.java 5cf9b056ea 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/GroupResourceProviderTest.java bbfa2d8503 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentProcessResourceProviderTest.java 5a7460d4c1 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java 7e32c15991 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java fd28081944 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProviderTest.java 6c95c53e5b 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/InstanceResourceProviderTest.java ba6793989e 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java e19ad29453 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JobResourceProviderTest.java 6fd1a238ae 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/KerberosDescriptorResourceProviderTest.java ca8127e42f 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/MemberResourceProviderTest.java 39ba4b9fe3 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java c0695b12d6 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestScheduleResourceProviderTest.java 6d4f72d9ad 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceComponentResourceProviderTest.java 222340b4e7 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceHostComponentResourceProviderTest.java ce3656c4ab 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceResourceProviderTest.java 96bc7c9674 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProviderTest.java 05232eac49 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackArtifactResourceProviderTest.java 21df88d545 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackConfigurationDependencyResourceProviderTest.java 7c88852f48 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackConfigurationResourceProviderTest.java 9c48ad0d23 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDependencyResourceProviderTest.java f35015348f 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackLevelConfigurationResourceProviderTest.java e9742bdfb1 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackResourceProviderTest.java 4281e3372e 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackServiceResourceProviderTest.java 2a2ef0b0b7 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TargetClusterResourceProviderTest.java 492c012c7e 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TaskResourceProviderTest.java 365d408ff6 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TestIvoryProviderModule.java 90f10118d4 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java d6b1ab3766 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderDBTest.java c4f0f349fb 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderTest.java 9efad8a54d 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ValidationResourceProviderTest.java c639d1fcdc 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/WorkflowResourceProviderTest.java 337dc466da 
> 
> 
> Diff: https://reviews.apache.org/r/63516/diff/2/
> 
> 
> Testing
> -------
> 
> tests do not pass yet, also on deploy get errors in some places.
> Fixing mistakes
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 63516: [Preview] Remove properties.json And Switch To Adding Properties to ResourceProviders Dynamically

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63516/
-----------------------------------------------------------

(Updated Nov. 9, 2017, 11:58 a.m.)


Review request for Ambari, Jonathan Hurley and Nate Cole.


Changes
-------

Current patch


Bugs: AMBARI-22353
    https://issues.apache.org/jira/browse/AMBARI-22353


Repository: ambari


Description
-------

Legacy/ancient ResourceProviders use the {{properties.json}} file to govern which properties can be used with the provider. This seems like excessive decoupling without any benefit and usually leads to runtime errors when new or removed properties are forgotten.

This file should be removed and the providers should be registering the known properties on their own.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java 711ae10f7e 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractAuthorizedResourceProvider.java a24c6394ac 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java 1dc0841d19 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractDRResourceProvider.java 953a2a7c77 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActionResourceProvider.java 4e618e7ff6 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProvider.java 389f0b2bf2 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java 32f1fd8f4f 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProvider.java cf4e7475b3 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertHistoryResourceProvider.java 8d716eabe0 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertNoticeResourceProvider.java 8ffd596cfa 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java c71651e5ff 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java 43ee7fe7c7 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AmbariConfigurationResourceProvider.java 4f4cc7070d 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java 73d24908ea 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java a2a49d7cb5 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterKerberosDescriptorResourceProvider.java 2678d55975 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java 54c83600b7 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 1a755590b7 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java 737bfa4d46 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigurationResourceProvider.java 0f260854f8 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CredentialResourceProvider.java 79254c6d89 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java c3758b3f5e 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionLinkResourceProvider.java db904bf714 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionResourceProvider.java 53e44e1888 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionVersionResourceProvider.java 4aa357c0e3 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/FeedResourceProvider.java f9d75fd353 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupPrivilegeResourceProvider.java f9f838fe22 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java f051651e12 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentProcessResourceProvider.java 2a25bc4d02 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java 6708560969 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostKerberosIdentityResourceProvider.java bfaf7b4a4f 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java 5373ffe31c 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java ba5fccc1dc 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/InstanceResourceProvider.java d3a695ba08 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/JobResourceProvider.java e70c3674b4 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/KerberosDescriptorResourceProvider.java 93013415b4 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/LdapSyncEventResourceProvider.java 4badc9c472 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/LoggingResourceProvider.java d6afe7b22b 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/MemberResourceProvider.java d9d56eee8c 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/OperatingSystemResourceProvider.java 174fdf60a0 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PrivilegeResourceProvider.java fabce6b379 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/QuickLinkArtifactResourceProvider.java 073ec60b27 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ReadOnlyResourceProvider.java 505ec637ed 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RecommendationResourceProvider.java 70ed3dc09f 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RemoteClusterResourceProvider.java 0b2d2b3f52 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java 81f283c55b 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestScheduleResourceProvider.java 4e25369a6e 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RoleAuthorizationResourceProvider.java 78eb80e8d1 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceComponentResourceProvider.java 3925aebdae 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceHostComponentResourceProvider.java c37bb2efe7 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceResourceProvider.java b24a94aee0 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceConfigVersionResourceProvider.java e7dbbc0389 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/SettingResourceProvider.java 5235ef4fb1 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProvider.java 7035f0a148 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackArtifactResourceProvider.java 6bb421b67b 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackConfigurationDependencyResourceProvider.java 366b3ef052 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackConfigurationResourceProvider.java 6f5b0f8c02 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDependencyResourceProvider.java 8b69c6a312 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackLevelConfigurationResourceProvider.java 819507bffd 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackResourceProvider.java ead4f6df2b 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceComponentResourceProvider.java b9661bb409 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java 8727741d37 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackVersionResourceProvider.java 094c75bbb8 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StageResourceProvider.java 6a326b5338 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TargetClusterResourceProvider.java d0c37f5a9e 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TaskAttemptResourceProvider.java 3af7bb15e5 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TaskResourceProvider.java 0b4fcd9633 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ThemeArtifactResourceProvider.java fc7cfe7f91 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeGroupResourceProvider.java e6aafc1ec5 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeItemResourceProvider.java 36eb3bebf1 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java a1ec98afe7 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeSummaryResourceProvider.java 94b2b4a981 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserAuthorizationResourceProvider.java 95550f0299 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProvider.java 614f7abda1 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserResourceProvider.java c5c36e9942 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ValidationResourceProvider.java b78c64af53 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java f94ac32f17 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java 9562782b01 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewResourceProvider.java 7179b335c2 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewURLResourceProvider.java cb506be1bf 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/WidgetLayoutResourceProvider.java 8c39fc4057 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/WidgetResourceProvider.java 03fd5d2359 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/WorkflowResourceProvider.java 13cb8a4768 
  ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/PropertyHelper.java 893978047c 
  ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java 5c5801d451 
  ambari-server/src/main/resources/key_properties.json 5d76062d87 
  ambari-server/src/main/resources/properties.json 1d12f83b3f 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProviderTest.java a127de6539 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractDRResourceProviderTest.java 38e6d366a1 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractResourceProviderTest.java 7165e48d70 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ActionResourceProviderTest.java ef56f9d3e7 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProviderTest.java 5221ecf16b 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java f53441182b 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java 833be5d117 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterKerberosDescriptorResourceProviderTest.java ac2847590d 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java 4a808931ac 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java 984010650c 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProviderTest.java 78f79ead9c 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ConfigurationResourceProviderTest.java 785ea2388b 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CredentialResourceProviderTest.java 89ed022da0 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ExtensionResourceProviderTest.java 5b6e830d6e 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/FeedResourceProviderTest.java 5cf9b056ea 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/GroupResourceProviderTest.java bbfa2d8503 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentProcessResourceProviderTest.java 5a7460d4c1 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java 7e32c15991 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java fd28081944 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProviderTest.java 6c95c53e5b 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/InstanceResourceProviderTest.java ba6793989e 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java e19ad29453 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JobResourceProviderTest.java 6fd1a238ae 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/KerberosDescriptorResourceProviderTest.java ca8127e42f 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/MemberResourceProviderTest.java 39ba4b9fe3 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java c0695b12d6 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestScheduleResourceProviderTest.java 6d4f72d9ad 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceComponentResourceProviderTest.java 222340b4e7 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceHostComponentResourceProviderTest.java ce3656c4ab 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceResourceProviderTest.java 96bc7c9674 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProviderTest.java 05232eac49 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackArtifactResourceProviderTest.java 21df88d545 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackConfigurationDependencyResourceProviderTest.java 7c88852f48 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackConfigurationResourceProviderTest.java 9c48ad0d23 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDependencyResourceProviderTest.java f35015348f 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackLevelConfigurationResourceProviderTest.java e9742bdfb1 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackResourceProviderTest.java 4281e3372e 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackServiceResourceProviderTest.java 2a2ef0b0b7 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TargetClusterResourceProviderTest.java 492c012c7e 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TaskResourceProviderTest.java 365d408ff6 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TestIvoryProviderModule.java 90f10118d4 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java d6b1ab3766 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderDBTest.java c4f0f349fb 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderTest.java 9efad8a54d 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ValidationResourceProviderTest.java c639d1fcdc 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/WorkflowResourceProviderTest.java 337dc466da 


Diff: https://reviews.apache.org/r/63516/diff/2/

Changes: https://reviews.apache.org/r/63516/diff/1-2/


Testing
-------

tests do not pass yet, also on deploy get errors in some places.
Fixing mistakes


Thanks,

Dmitro Lisnichenko