You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Steve Loughran (JIRA)" <ji...@apache.org> on 2017/04/25 17:39:04 UTC
[jira] [Commented] (HADOOP-13550) Azure threaded deleter logs too
much at info
[ https://issues.apache.org/jira/browse/HADOOP-13550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15983307#comment-15983307 ]
Steve Loughran commented on HADOOP-13550:
-----------------------------------------
syncing up and running this.
Three test cases fail.
{code}
Running org.apache.hadoop.fs.azure.TestFileSystemOperationsWithThreads
Tests run: 19, Failures: 3, Errors: 0, Skipped: 0, Time elapsed: 224.429 sec <<< FAILURE! - in org.apache.hadoop.fs.azure.TestFileSystemOperationsWithThreads
testRenameSingleRenameException(org.apache.hadoop.fs.azure.TestFileSystemOperationsWithThreads) Time elapsed: 3.683 sec <<< FAILURE!
java.lang.AssertionError: null
at org.junit.Assert.fail(Assert.java:86)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertTrue(Assert.java:52)
at org.apache.hadoop.fs.azure.TestFileSystemOperationsWithThreads.testRenameSingleRenameException(TestFileSystemOperationsWithThreads.java:712)
testDeleteSingleDeleteFailure(org.apache.hadoop.fs.azure.TestFileSystemOperationsWithThreads) Time elapsed: 3.844 sec <<< FAILURE!
java.lang.AssertionError: null
at org.junit.Assert.fail(Assert.java:86)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertTrue(Assert.java:52)
at org.apache.hadoop.fs.azure.TestFileSystemOperationsWithThreads.testDeleteSingleDeleteFailure(TestFileSystemOperationsWithThreads.java:501)
testDeleteSingleDeleteException(org.apache.hadoop.fs.azure.TestFileSystemOperationsWithThreads) Time elapsed: 3.851 sec <<< FAILURE!
java.lang.AssertionError: null
at org.junit.Assert.fail(Assert.java:86)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertTrue(Assert.java:52)
at org.apache.hadoop.fs.azure.TestFileSystemOperationsWithThreads.testDeleteSingleDeleteException(TestFileSystemOperationsWithThreads.java:533)
{code}
why? Using hard-coded strings in asserts about log contents. Change the logs, or even change the message: test failuire
{code}
// Validate from logs that threads are enabled and delete operation failed.
String content = logs.getOutput();
assertTrue(content.contains("Using thread pool for Rename operation with threads"));
assertTrue(content.contains("Encountered Exception for Rename operation for file " + path));
assertTrue(content.contains("Terminating execution of Rename operation now as some other thread already got exception or operation failed"));
{code}
> Azure threaded deleter logs too much at info
> --------------------------------------------
>
> Key: HADOOP-13550
> URL: https://issues.apache.org/jira/browse/HADOOP-13550
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs/azure
> Affects Versions: 2.9.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Trivial
> Attachments: HADOOP-13550-branch-2-001.patch
>
>
> The new azure parallel deleter shares too much information in the logs about what is going on
> {code}
> 2016-08-26 18:56:16,461 WARN azure.AzureFileSystemThreadPoolExecutor (AzureFileSystemThreadPoolExecutor.java:executeParallel(150)) - Disabling threads for Delete operation as thread count 0 is <= 1
> 2016-08-26 18:56:21,424 INFO azure.AzureFileSystemThreadPoolExecutor (AzureFileSystemThreadPoolExecutor.java:executeParallel(235)) - Time taken for Delete operation is: 4963 ms with threads: 0
> {code}
> # given that thread count of 0 is the default, warn is overkill and misleading
> # I (and presumably many other users) don't care about how long something took.
> These should both be downgraded to debug
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org