You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/06/12 12:59:35 UTC
[GitHub] [iotdb] noorall opened a new pull request, #6246: [IOTDB-3460] Python API: Add support for DBAPI
noorall opened a new pull request, #6246:
URL: https://github.com/apache/iotdb/pull/6246
I made the following changes in this PR:
1. Implement the methods specified in DBAPI2.0
2. Add test code for the DBAPI module
**JIAR:** https://issues.apache.org/jira/browse/IOTDB-3460
**DBAPI2.0:** https://peps.python.org/pep-0249/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] noorall commented on a diff in pull request #6246: [IOTDB-3460] Python API: Add support for DBAPI
Posted by GitBox <gi...@apache.org>.
noorall commented on code in PR #6246:
URL: https://github.com/apache/iotdb/pull/6246#discussion_r895288830
##########
client-py/README.md:
##########
@@ -353,6 +353,60 @@ class MyTestCase(unittest.TestCase):
by default it will load the image `apache/iotdb:latest`, if you want a specific version just pass it like e.g. `IoTDBContainer("apache/iotdb:0.12.0")` to get version `0.12.0` running.
+### IoTDB DBAPI
+
+IoTDB DBAPI implements the Python DB API 2.0 specification (https://peps.python.org/pep-0249/), which defines a common
+interface for accessing databases in Python.
Review Comment:
added. @HTHou
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] noorall commented on a diff in pull request #6246: [IOTDB-3460] Python API: Add support for DBAPI
Posted by GitBox <gi...@apache.org>.
noorall commented on code in PR #6246:
URL: https://github.com/apache/iotdb/pull/6246#discussion_r895288830
##########
client-py/README.md:
##########
@@ -353,6 +353,60 @@ class MyTestCase(unittest.TestCase):
by default it will load the image `apache/iotdb:latest`, if you want a specific version just pass it like e.g. `IoTDBContainer("apache/iotdb:0.12.0")` to get version `0.12.0` running.
+### IoTDB DBAPI
+
+IoTDB DBAPI implements the Python DB API 2.0 specification (https://peps.python.org/pep-0249/), which defines a common
+interface for accessing databases in Python.
Review Comment:
added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] noorall commented on pull request #6246: [IOTDB-3460] Python API: Add support for DBAPI
Posted by GitBox <gi...@apache.org>.
noorall commented on PR #6246:
URL: https://github.com/apache/iotdb/pull/6246#issuecomment-1153394114
> Good job! Would you like to add some user guide documents?
User guide documents has been added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] noorall commented on pull request #6246: [IOTDB-3460] Python API: Add support for DBAPI
Posted by GitBox <gi...@apache.org>.
noorall commented on PR #6246:
URL: https://github.com/apache/iotdb/pull/6246#issuecomment-1153362462
>
I will add some documents soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on pull request #6246: [IOTDB-3460] Python API: Add support for DBAPI
Posted by GitBox <gi...@apache.org>.
HTHou commented on PR #6246:
URL: https://github.com/apache/iotdb/pull/6246#issuecomment-1153353713
Good job!
Would you like to add some user guide documents?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on a diff in pull request #6246: [IOTDB-3460] Python API: Add support for DBAPI
Posted by GitBox <gi...@apache.org>.
HTHou commented on code in PR #6246:
URL: https://github.com/apache/iotdb/pull/6246#discussion_r895284872
##########
client-py/README.md:
##########
@@ -353,6 +353,60 @@ class MyTestCase(unittest.TestCase):
by default it will load the image `apache/iotdb:latest`, if you want a specific version just pass it like e.g. `IoTDBContainer("apache/iotdb:0.12.0")` to get version `0.12.0` running.
+### IoTDB DBAPI
+
+IoTDB DBAPI implements the Python DB API 2.0 specification (https://peps.python.org/pep-0249/), which defines a common
+interface for accessing databases in Python.
Review Comment:
And consider adding this to https://github.com/apache/iotdb/blob/master/docs/zh/UserGuide/API/Programming-Python-Native-API.md and https://github.com/apache/iotdb/blob/master/docs/UserGuide/API/Programming-Python-Native-API.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou merged pull request #6246: [IOTDB-3460] Python API: Add support for DBAPI
Posted by GitBox <gi...@apache.org>.
HTHou merged PR #6246:
URL: https://github.com/apache/iotdb/pull/6246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org