You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Sam Hough (JIRA)" <ji...@apache.org> on 2007/09/07 16:53:30 UTC
[jira] Created: (WICKET-940) AjaxFallbackLink.onClick be helpful if
not final
AjaxFallbackLink.onClick be helpful if not final
------------------------------------------------
Key: WICKET-940
URL: https://issues.apache.org/jira/browse/WICKET-940
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 1.3.0-beta3
Reporter: Sam Hough
Priority: Minor
I'd like to override AjaxFallbackLink.onClick and have application code live there rather than in the Ajax specific method. Obviously I could have onMyClick but this seems rather ugly and wouldn't look/feel the same as just using a Link object.
AjaxFallbackButton.onSubmit is not final so it also seems inconsistent.
Thanks
Sam
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-940) AjaxFallbackLink.onClick be helpful
if not final
Posted by "Sam Hough (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12526109 ]
Sam Hough commented on WICKET-940:
----------------------------------
Again in the spirit of further documenting one, minority, point of view:
AjaxTabbedPanel seems like a symptom of raising Ajax issues to such a high level. The TabbedPanel should be busy worrying about being a tabbed panel not how to behave for Ajax.
Presumably the non-fallback AjaxLink and AjaxButton are deprecated but it still means you have the Ajax and non-Ajax flavours of components. If buttons and links came from a factory and had the same signature you would only need one TabbedPanel and then any extensions via inheritance wouldn't need duplicating.
AjaxTabbedPanel also invents its own hook onAjaxUpdate which also seems ugly.
> AjaxFallbackLink.onClick be helpful if not final
> ------------------------------------------------
>
> Key: WICKET-940
> URL: https://issues.apache.org/jira/browse/WICKET-940
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta3
> Reporter: Sam Hough
> Assignee: Igor Vaynberg
> Priority: Minor
>
> I'd like to override AjaxFallbackLink.onClick and have application code live there rather than in the Ajax specific method. Obviously I could have onMyClick but this seems rather ugly and wouldn't look/feel the same as just using a Link object.
> AjaxFallbackButton.onSubmit is not final so it also seems inconsistent.
> Thanks
> Sam
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-940) AjaxFallbackLink.onClick be helpful
if not final
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12525854 ]
Igor Vaynberg commented on WICKET-940:
--------------------------------------
there is nothing low level about ajaxrequesttarget. further if your nice applicationcode does not call super by mistake, onclick(ajaxrequettarget) wont be called and then your ajax update wont work either.
> AjaxFallbackLink.onClick be helpful if not final
> ------------------------------------------------
>
> Key: WICKET-940
> URL: https://issues.apache.org/jira/browse/WICKET-940
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta3
> Reporter: Sam Hough
> Assignee: Igor Vaynberg
> Priority: Minor
>
> I'd like to override AjaxFallbackLink.onClick and have application code live there rather than in the Ajax specific method. Obviously I could have onMyClick but this seems rather ugly and wouldn't look/feel the same as just using a Link object.
> AjaxFallbackButton.onSubmit is not final so it also seems inconsistent.
> Thanks
> Sam
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-940) AjaxFallbackLink.onClick be helpful
if not final
Posted by "Sam Hough (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12525892 ]
Sam Hough commented on WICKET-940:
----------------------------------
I'm not really trying to change your mind just add a note about how at least one developer wanted to use Wicket.
Our application code uses OurButton which extends AjaxFallBackButton which removes the need to call super and hides AjaxRequestTarget.
As I've said before I'm new to Wicket world but AjaxRequestTarget does seem pretty low level to me. I'm really pleased to move away from thinking in just strings (as with JSP etc) and move higher up the abstraction food chain to components. Wicket does this really nicely. It may just be the drugs but I don't see the need to manage component updates by hand.
Anyway, might give me just enough of an excuse to have handler objects rather than re-implementing onClick etc. I've still not come up with a nice way to tell ListChoice etc that I want the server to be notified of events. Presumably be more familiar to people coming from Swing or GWT etc...
Cheers Igor ;)
> AjaxFallbackLink.onClick be helpful if not final
> ------------------------------------------------
>
> Key: WICKET-940
> URL: https://issues.apache.org/jira/browse/WICKET-940
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta3
> Reporter: Sam Hough
> Assignee: Igor Vaynberg
> Priority: Minor
>
> I'd like to override AjaxFallbackLink.onClick and have application code live there rather than in the Ajax specific method. Obviously I could have onMyClick but this seems rather ugly and wouldn't look/feel the same as just using a Link object.
> AjaxFallbackButton.onSubmit is not final so it also seems inconsistent.
> Thanks
> Sam
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-940) AjaxFallbackLink.onClick be helpful
if not final
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-940.
----------------------------------
Resolution: Won't Fix
Assignee: Igor Vaynberg
actually i just made ajaxfallbackbutton.onsubmit final, thanks for catching it :)
our idea with this is that you override onsubmit(ajaxrequesttarget t) and then your code looks like this:
onsubmit(ajaxrequesttarget t) {
do something here
if (t!=null) {
// we are in an ajax request, setup partial update
t.addcomponent(a);
t.addcomponent(b);
}
> AjaxFallbackLink.onClick be helpful if not final
> ------------------------------------------------
>
> Key: WICKET-940
> URL: https://issues.apache.org/jira/browse/WICKET-940
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta3
> Reporter: Sam Hough
> Assignee: Igor Vaynberg
> Priority: Minor
>
> I'd like to override AjaxFallbackLink.onClick and have application code live there rather than in the Ajax specific method. Obviously I could have onMyClick but this seems rather ugly and wouldn't look/feel the same as just using a Link object.
> AjaxFallbackButton.onSubmit is not final so it also seems inconsistent.
> Thanks
> Sam
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-940) AjaxFallbackLink.onClick be helpful
if not final
Posted by "Sam Hough (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12525853 ]
Sam Hough commented on WICKET-940:
----------------------------------
I liked
onSubmit() {
// my nice application code
}
and
onClick() {
// my nice application code
}
without low level implementation detail getting in the way
> AjaxFallbackLink.onClick be helpful if not final
> ------------------------------------------------
>
> Key: WICKET-940
> URL: https://issues.apache.org/jira/browse/WICKET-940
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta3
> Reporter: Sam Hough
> Assignee: Igor Vaynberg
> Priority: Minor
>
> I'd like to override AjaxFallbackLink.onClick and have application code live there rather than in the Ajax specific method. Obviously I could have onMyClick but this seems rather ugly and wouldn't look/feel the same as just using a Link object.
> AjaxFallbackButton.onSubmit is not final so it also seems inconsistent.
> Thanks
> Sam
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-940) AjaxFallbackLink.onClick be helpful
if not final
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12526168 ]
Igor Vaynberg commented on WICKET-940:
--------------------------------------
these comments belong on the list. here no one but me and you see them.
> AjaxFallbackLink.onClick be helpful if not final
> ------------------------------------------------
>
> Key: WICKET-940
> URL: https://issues.apache.org/jira/browse/WICKET-940
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta3
> Reporter: Sam Hough
> Assignee: Igor Vaynberg
> Priority: Minor
>
> I'd like to override AjaxFallbackLink.onClick and have application code live there rather than in the Ajax specific method. Obviously I could have onMyClick but this seems rather ugly and wouldn't look/feel the same as just using a Link object.
> AjaxFallbackButton.onSubmit is not final so it also seems inconsistent.
> Thanks
> Sam
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.