You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/07/20 20:06:31 UTC
[GitHub] [arrow] jorgecarleitao opened a new pull request #7811: ARROW-9534: [Rust] [DataFusion] Added support for lit to all supported rust types.
jorgecarleitao opened a new pull request #7811:
URL: https://github.com/apache/arrow/pull/7811
@andygrove fyi
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7811: ARROW-9534: [Rust] [DataFusion] Added support for lit to all supported rust types.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7811:
URL: https://github.com/apache/arrow/pull/7811#issuecomment-661311087
https://issues.apache.org/jira/browse/ARROW-9534
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #7811: ARROW-9534: [Rust] [DataFusion] Added support for lit to all supported rust types.
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #7811:
URL: https://github.com/apache/arrow/pull/7811#issuecomment-661659549
Note that I pushed two extra changes:
1. Added the implementation for `String`, since we are using it (and thus will likely be used)
2. Made calls throughout the code use `lit` instead of `Expr::Literal(ScalarValue::[]::new(...)))`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on a change in pull request #7811: ARROW-9534: [Rust] [DataFusion] Added support for lit to all supported rust types.
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on a change in pull request #7811:
URL: https://github.com/apache/arrow/pull/7811#discussion_r457663076
##########
File path: rust/datafusion/src/logicalplan.rs
##########
@@ -378,9 +378,44 @@ pub fn col(name: &str) -> Expr {
Expr::UnresolvedColumn(name.to_owned())
}
-/// Create a literal string expression
-pub fn lit_str(str: &str) -> Expr {
Review comment:
backward incompatible :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] andygrove closed pull request #7811: ARROW-9534: [Rust] [DataFusion] Added support for lit to all supported rust types.
Posted by GitBox <gi...@apache.org>.
andygrove closed pull request #7811:
URL: https://github.com/apache/arrow/pull/7811
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org