You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2018/07/25 19:59:00 UTC
[jira] [Commented] (WICKET-6148) Remove
AjaxEventBehavior#onCheckEvent() before Wicket 8.0.0
[ https://issues.apache.org/jira/browse/WICKET-6148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16556204#comment-16556204 ]
ASF subversion and git services commented on WICKET-6148:
---------------------------------------------------------
Commit 8ed292ffc6688ffdccfb48c5d58318171122effa in wicket's branch refs/heads/wicket-8.x from Martin Tzvetanov Grigorov
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=8ed292f ]
WICKET-6573 WicketTesterHelper ignores invalid Ajax-Event names starting with "on"
Do not cut the leading 'on' prefix for JS events.
Related-to: WICKET-6148
(cherry picked from commit 0f61308e6be84db9491b15117d371fa70ec82b01)
> Remove AjaxEventBehavior#onCheckEvent() before Wicket 8.0.0
> -----------------------------------------------------------
>
> Key: WICKET-6148
> URL: https://issues.apache.org/jira/browse/WICKET-6148
> Project: Wicket
> Issue Type: Task
> Components: wicket
> Reporter: Martin Grigorov
> Assignee: Martin Grigorov
> Priority: Minor
> Fix For: 8.0.0-M9
>
>
> org.apache.wicket.ajax.AjaxEventBehavior#onCheckEvent() will throw an exception if the event name starts with 'on', e.g. 'onclick'.
> Since version 6.0.0 Wicket uses JavaScript based event registration and the prefix 'on' is actually wrong. It has been used for pre-1.5 versions for the attribute names.
> There are valid use cases where applications may use custom JS events with names which start with 'on', so Wicket should not prevent them.
> During the milestone release org.apache.wicket.ajax.AjaxEventBehavior#onCheckEvent() will throw exception to really make developers fix the WARN message they have ignored in Wicket 7.x.
> The method has 'protected' visibility, so it could be overridden by applications which need to use custom events with 'on' prefix in their name.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)