Re: [PR] feat(bigquery): add GEOGRAPHY type support for BigQuery I/O [beam]

["liferoad (via GitHub)" <gi...@apache.org>]

liferoad commented on code in PR #36121:
URL: https://github.com/apache/beam/pull/36121#discussion_r2404505720


##########
sdks/python/apache_beam/typehints/schemas.py:
##########
@@ -552,8 +552,14 @@ def typing_from_runner_api(
       if fieldtype_proto.logical_type.urn == PYTHON_ANY_URN:
         return Any
       else:
-        return LogicalType.from_runner_api(
-            fieldtype_proto.logical_type).language_type()
+        logical_type_instance = LogicalType.from_runner_api(
+            fieldtype_proto.logical_type)
+        # Special case for GeographyType: return the logical type class itself

Review Comment:
   Removed GeographyType for now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org