[jira] Closed: (THRIFT-819) add Enumeration for protocol, transport and server types

["Roger Meier (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/THRIFT-819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Roger Meier closed THRIFT-819.
------------------------------

    Resolution: Not A Problem

I agree, it isn't realistic to align such enumerations across all languages.

The proposed registry approach seems to be a good way to go.

> add Enumeration for protocol, transport and server types
> --------------------------------------------------------
>
>                 Key: THRIFT-819
>                 URL: https://issues.apache.org/jira/browse/THRIFT-819
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Library (C++)
>            Reporter: Roger Meier
>            Priority: Minor
>         Attachments: THRIFT-819.patch
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> I would like to have Enumeration's for protocol, transport and server types.
> I'm doing some testing stuff, and using types for the different parameter's would make it much more comfortable to work with, e.g.
> {code}
>   // Dispatcher
>   shared_ptr<TProtocolFactory> protocolFactory;
>   if (protocol_type == PROTOCOL_JSON) {
>     shared_ptr<TProtocolFactory> jsonProtocolFactory(new TJSONProtocolFactory());
>     protocolFactory = jsonProtocolFactory;
>   } else
>   {
>     shared_ptr<TProtocolFactory> binaryProtocolFactory(new TBinaryProtocolFactory());
>     protocolFactory = binaryProtocolFactory;
>   }
> {code}
> aligning these enums across all languages might be another benefit.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.