[GitHub] [airflow] dstandish opened a new pull request #5421: [AIRFLOW-4799] don't mutate self.env in BashOperator execute method

[GitBox <gi...@apache.org>]

dstandish opened a new pull request #5421: [AIRFLOW-4799] don't mutate self.env in BashOperator execute method
URL: https://github.com/apache/airflow/pull/5421
 
 
   * in tests using bash operator repeatedly, env is populated with contents of environment.
   * on subsequent runs, render_templates will try to render contents of env.
   * this produces unpredictable behavior where missing template error may be thrown, or env paths may be replaced with "template file" contents
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses [AIRFLOW-4799] 
     - https://issues.apache.org/jira/browse/AIRFLOW-4799
   
   ### Description
   
   Bash operator mutates templated argument `self.env` in the execute.  This results in some flaky test failures if in task instance tests for example where the same TI is executed multiple times (the mutated `self.env` is re-rendered, so it looks at all `.sh` and `.bash` in your os env and tries to render them as templates. 
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:  small change
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
   ### Code Quality
   
   - [x] Passes `flake8`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services