You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by John Speidel <js...@hortonworks.com> on 2014/04/24 01:23:33 UTC
Review Request 20637: Add dependency related information to stacks in the
REST API
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20637/
-----------------------------------------------------------
Review request for Ambari, Sid Wagle and Tom Beerbower.
Bugs: AMBARI-5553
https://issues.apache.org/jira/browse/AMBARI-5553
Repository: ambari
Description
-------
Add dependency related information to stacks in the REST API.
Added dependency related information to stacks in the REST API. This information describes dependencies between components which are part of a stack.
A new dependencies resources will be added as a child to the stacksServices/serviceComponent (soon to be renamed to services/component) resource.
For example:
GET http://172.18.192.3:8080/api/v1/stacks/HDP/versions/1.3.3/stackServices/HBASE/serviceComponents/HBASE_MASTER?fields=dependencies/*
{
"href" : "http://172.18.192.3:8080/api/v1/stacks/HDP/versions/1.3.3/stackServices/HBASE/serviceComponents/HBASE_MASTER?fields=dependencies/*",
"StackServiceComponents" : {
"component_name" : "HBASE_MASTER",
"service_name" : "HBASE",
"stack_name" : "HDP",
"stack_version" : "1.3.3"
},
"dependencies" : [
{
"href" : "http://172.18.192.3:8080/api/v1/stacks/HDP/versions/1.3.3/stackServices/HBASE/serviceComponents/HBASE_MASTER/dependencies/HDFS_CLIENT",
"Dependencies" : {
"component_name" : "HDFS_CLIENT",
"dependent_component_name" : "HBASE_MASTER",
"dependent_service_name" : "HBASE",
"scope" : "host",
"service_name" : "HDFS",
"stack_name" : "HDP",
"stack_version" : "1.3.3"
},
"auto_deploy" : {
"enabled" : true
}
},
{
"href" : "http://172.18.192.3:8080/api/v1/stacks/HDP/versions/1.3.3/stackServices/HBASE/serviceComponents/HBASE_MASTER/dependencies/ZOOKEEPER_SERVER",
"Dependencies" : {
"component_name" : "ZOOKEEPER_SERVER",
"dependent_component_name" : "HBASE_MASTER",
"dependent_service_name" : "HBASE",
"scope" : "cluster",
"service_name" : "ZOOKEEPER",
"stack_name" : "HDP",
"stack_version" : "1.3.3"
},
"auto_deploy" : {
"enabled" : true,
"location" : "HBASE/HBASE_MASTER"
}
}
]
}
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 8275796
ambari-server/src/main/java/org/apache/ambari/server/api/resources/StackDependencyResourceDefinition.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/api/resources/StackServiceComponentResourceDefinition.java c38b1c7
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 659499e
ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java 104d2bc
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 034e877
ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceComponentResponse.java 51871a4
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java d536230
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java 18031d0
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java 4f25638
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDependencyResourceProvider.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceComponentResourceProvider.java fe570fe
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java 7792746
ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java f03bd8c
ambari-server/src/main/java/org/apache/ambari/server/state/DependencyInfo.java 305b98d
ambari-server/src/main/resources/key_properties.json 78c15c5
ambari-server/src/main/resources/properties.json ee7d87d
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 3a63b78
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java c9ac437
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDependencyResourceProviderTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/20637/diff/
Testing
-------
Functional Tests:
Extensive manual functional tests including getting of collections and instance resources as well as standard and dub queries on multiple fields.
Unit Tests:
Added new unit tests for new code
Successfully ran all existing unit tests
Results :
Tests run: 1550, Failures: 0, Errors: 0, Skipped: 9
...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18:58.894s
[INFO] Finished at: Wed Apr 23 18:54:35 EDT 2014
[INFO] Final Memory: 21M/123M
[INFO] ------------------------------------------------------------------------
Thanks,
John Speidel
Re: Review Request 20637: Add dependency related information to stacks in
the REST API
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20637/#review41267
-----------------------------------------------------------
Ship it!
Ship It!
- Sid Wagle
On April 23, 2014, 11:23 p.m., John Speidel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20637/
> -----------------------------------------------------------
>
> (Updated April 23, 2014, 11:23 p.m.)
>
>
> Review request for Ambari, Sid Wagle and Tom Beerbower.
>
>
> Bugs: AMBARI-5553
> https://issues.apache.org/jira/browse/AMBARI-5553
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add dependency related information to stacks in the REST API.
>
> Added dependency related information to stacks in the REST API. This information describes dependencies between components which are part of a stack.
> A new dependencies resources will be added as a child to the stacksServices/serviceComponent (soon to be renamed to services/component) resource.
> For example:
> GET http://172.18.192.3:8080/api/v1/stacks/HDP/versions/1.3.3/stackServices/HBASE/serviceComponents/HBASE_MASTER?fields=dependencies/*
> {
> "href" : "http://172.18.192.3:8080/api/v1/stacks/HDP/versions/1.3.3/stackServices/HBASE/serviceComponents/HBASE_MASTER?fields=dependencies/*",
> "StackServiceComponents" : {
> "component_name" : "HBASE_MASTER",
> "service_name" : "HBASE",
> "stack_name" : "HDP",
> "stack_version" : "1.3.3"
> },
> "dependencies" : [
> {
> "href" : "http://172.18.192.3:8080/api/v1/stacks/HDP/versions/1.3.3/stackServices/HBASE/serviceComponents/HBASE_MASTER/dependencies/HDFS_CLIENT",
> "Dependencies" : {
> "component_name" : "HDFS_CLIENT",
> "dependent_component_name" : "HBASE_MASTER",
> "dependent_service_name" : "HBASE",
> "scope" : "host",
> "service_name" : "HDFS",
> "stack_name" : "HDP",
> "stack_version" : "1.3.3"
> },
> "auto_deploy" : {
> "enabled" : true
> }
> },
> {
> "href" : "http://172.18.192.3:8080/api/v1/stacks/HDP/versions/1.3.3/stackServices/HBASE/serviceComponents/HBASE_MASTER/dependencies/ZOOKEEPER_SERVER",
> "Dependencies" : {
> "component_name" : "ZOOKEEPER_SERVER",
> "dependent_component_name" : "HBASE_MASTER",
> "dependent_service_name" : "HBASE",
> "scope" : "cluster",
> "service_name" : "ZOOKEEPER",
> "stack_name" : "HDP",
> "stack_version" : "1.3.3"
> },
> "auto_deploy" : {
> "enabled" : true,
> "location" : "HBASE/HBASE_MASTER"
> }
> }
> ]
> }
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 8275796
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/StackDependencyResourceDefinition.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/StackServiceComponentResourceDefinition.java c38b1c7
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 659499e
> ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java 104d2bc
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 034e877
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceComponentResponse.java 51871a4
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java d536230
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java 18031d0
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java 4f25638
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDependencyResourceProvider.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceComponentResourceProvider.java fe570fe
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java 7792746
> ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java f03bd8c
> ambari-server/src/main/java/org/apache/ambari/server/state/DependencyInfo.java 305b98d
> ambari-server/src/main/resources/key_properties.json 78c15c5
> ambari-server/src/main/resources/properties.json ee7d87d
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 3a63b78
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java c9ac437
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDependencyResourceProviderTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/20637/diff/
>
>
> Testing
> -------
>
> Functional Tests:
> Extensive manual functional tests including getting of collections and instance resources as well as standard and dub queries on multiple fields.
>
> Unit Tests:
> Added new unit tests for new code
> Successfully ran all existing unit tests
>
> Results :
>
> Tests run: 1550, Failures: 0, Errors: 0, Skipped: 9
>
> ...
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:58.894s
> [INFO] Finished at: Wed Apr 23 18:54:35 EDT 2014
> [INFO] Final Memory: 21M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> John Speidel
>
>
Re: Review Request 20637: Add dependency related information to stacks in
the REST API
Posted by Tom Beerbower <tb...@hortonworks.com>.
> On April 24, 2014, 12:49 p.m., Tom Beerbower wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java, lines 147-158
> > <https://reviews.apache.org/r/20637/diff/1/?file=566317#file566317line147>
> >
> > Should this method be static? It doesn't seem to be related to a specific instance.
Never mind... after looking at the rest of the patch, looks good how it is.
- Tom
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20637/#review41289
-----------------------------------------------------------
On April 23, 2014, 11:23 p.m., John Speidel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20637/
> -----------------------------------------------------------
>
> (Updated April 23, 2014, 11:23 p.m.)
>
>
> Review request for Ambari, Sid Wagle and Tom Beerbower.
>
>
> Bugs: AMBARI-5553
> https://issues.apache.org/jira/browse/AMBARI-5553
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add dependency related information to stacks in the REST API.
>
> Added dependency related information to stacks in the REST API. This information describes dependencies between components which are part of a stack.
> A new dependencies resources will be added as a child to the stacksServices/serviceComponent (soon to be renamed to services/component) resource.
> For example:
> GET http://172.18.192.3:8080/api/v1/stacks/HDP/versions/1.3.3/stackServices/HBASE/serviceComponents/HBASE_MASTER?fields=dependencies/*
> {
> "href" : "http://172.18.192.3:8080/api/v1/stacks/HDP/versions/1.3.3/stackServices/HBASE/serviceComponents/HBASE_MASTER?fields=dependencies/*",
> "StackServiceComponents" : {
> "component_name" : "HBASE_MASTER",
> "service_name" : "HBASE",
> "stack_name" : "HDP",
> "stack_version" : "1.3.3"
> },
> "dependencies" : [
> {
> "href" : "http://172.18.192.3:8080/api/v1/stacks/HDP/versions/1.3.3/stackServices/HBASE/serviceComponents/HBASE_MASTER/dependencies/HDFS_CLIENT",
> "Dependencies" : {
> "component_name" : "HDFS_CLIENT",
> "dependent_component_name" : "HBASE_MASTER",
> "dependent_service_name" : "HBASE",
> "scope" : "host",
> "service_name" : "HDFS",
> "stack_name" : "HDP",
> "stack_version" : "1.3.3"
> },
> "auto_deploy" : {
> "enabled" : true
> }
> },
> {
> "href" : "http://172.18.192.3:8080/api/v1/stacks/HDP/versions/1.3.3/stackServices/HBASE/serviceComponents/HBASE_MASTER/dependencies/ZOOKEEPER_SERVER",
> "Dependencies" : {
> "component_name" : "ZOOKEEPER_SERVER",
> "dependent_component_name" : "HBASE_MASTER",
> "dependent_service_name" : "HBASE",
> "scope" : "cluster",
> "service_name" : "ZOOKEEPER",
> "stack_name" : "HDP",
> "stack_version" : "1.3.3"
> },
> "auto_deploy" : {
> "enabled" : true,
> "location" : "HBASE/HBASE_MASTER"
> }
> }
> ]
> }
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 8275796
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/StackDependencyResourceDefinition.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/StackServiceComponentResourceDefinition.java c38b1c7
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 659499e
> ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java 104d2bc
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 034e877
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceComponentResponse.java 51871a4
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java d536230
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java 18031d0
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java 4f25638
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDependencyResourceProvider.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceComponentResourceProvider.java fe570fe
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java 7792746
> ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java f03bd8c
> ambari-server/src/main/java/org/apache/ambari/server/state/DependencyInfo.java 305b98d
> ambari-server/src/main/resources/key_properties.json 78c15c5
> ambari-server/src/main/resources/properties.json ee7d87d
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 3a63b78
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java c9ac437
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDependencyResourceProviderTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/20637/diff/
>
>
> Testing
> -------
>
> Functional Tests:
> Extensive manual functional tests including getting of collections and instance resources as well as standard and dub queries on multiple fields.
>
> Unit Tests:
> Added new unit tests for new code
> Successfully ran all existing unit tests
>
> Results :
>
> Tests run: 1550, Failures: 0, Errors: 0, Skipped: 9
>
> ...
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:58.894s
> [INFO] Finished at: Wed Apr 23 18:54:35 EDT 2014
> [INFO] Final Memory: 21M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> John Speidel
>
>
Re: Review Request 20637: Add dependency related information to stacks in
the REST API
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20637/#review41289
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
<https://reviews.apache.org/r/20637/#comment74721>
Should this method be static? It doesn't seem to be related to a specific instance.
- Tom Beerbower
On April 23, 2014, 11:23 p.m., John Speidel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20637/
> -----------------------------------------------------------
>
> (Updated April 23, 2014, 11:23 p.m.)
>
>
> Review request for Ambari, Sid Wagle and Tom Beerbower.
>
>
> Bugs: AMBARI-5553
> https://issues.apache.org/jira/browse/AMBARI-5553
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add dependency related information to stacks in the REST API.
>
> Added dependency related information to stacks in the REST API. This information describes dependencies between components which are part of a stack.
> A new dependencies resources will be added as a child to the stacksServices/serviceComponent (soon to be renamed to services/component) resource.
> For example:
> GET http://172.18.192.3:8080/api/v1/stacks/HDP/versions/1.3.3/stackServices/HBASE/serviceComponents/HBASE_MASTER?fields=dependencies/*
> {
> "href" : "http://172.18.192.3:8080/api/v1/stacks/HDP/versions/1.3.3/stackServices/HBASE/serviceComponents/HBASE_MASTER?fields=dependencies/*",
> "StackServiceComponents" : {
> "component_name" : "HBASE_MASTER",
> "service_name" : "HBASE",
> "stack_name" : "HDP",
> "stack_version" : "1.3.3"
> },
> "dependencies" : [
> {
> "href" : "http://172.18.192.3:8080/api/v1/stacks/HDP/versions/1.3.3/stackServices/HBASE/serviceComponents/HBASE_MASTER/dependencies/HDFS_CLIENT",
> "Dependencies" : {
> "component_name" : "HDFS_CLIENT",
> "dependent_component_name" : "HBASE_MASTER",
> "dependent_service_name" : "HBASE",
> "scope" : "host",
> "service_name" : "HDFS",
> "stack_name" : "HDP",
> "stack_version" : "1.3.3"
> },
> "auto_deploy" : {
> "enabled" : true
> }
> },
> {
> "href" : "http://172.18.192.3:8080/api/v1/stacks/HDP/versions/1.3.3/stackServices/HBASE/serviceComponents/HBASE_MASTER/dependencies/ZOOKEEPER_SERVER",
> "Dependencies" : {
> "component_name" : "ZOOKEEPER_SERVER",
> "dependent_component_name" : "HBASE_MASTER",
> "dependent_service_name" : "HBASE",
> "scope" : "cluster",
> "service_name" : "ZOOKEEPER",
> "stack_name" : "HDP",
> "stack_version" : "1.3.3"
> },
> "auto_deploy" : {
> "enabled" : true,
> "location" : "HBASE/HBASE_MASTER"
> }
> }
> ]
> }
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 8275796
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/StackDependencyResourceDefinition.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/StackServiceComponentResourceDefinition.java c38b1c7
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 659499e
> ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java 104d2bc
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 034e877
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceComponentResponse.java 51871a4
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java d536230
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java 18031d0
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java 4f25638
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDependencyResourceProvider.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceComponentResourceProvider.java fe570fe
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java 7792746
> ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java f03bd8c
> ambari-server/src/main/java/org/apache/ambari/server/state/DependencyInfo.java 305b98d
> ambari-server/src/main/resources/key_properties.json 78c15c5
> ambari-server/src/main/resources/properties.json ee7d87d
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 3a63b78
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java c9ac437
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDependencyResourceProviderTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/20637/diff/
>
>
> Testing
> -------
>
> Functional Tests:
> Extensive manual functional tests including getting of collections and instance resources as well as standard and dub queries on multiple fields.
>
> Unit Tests:
> Added new unit tests for new code
> Successfully ran all existing unit tests
>
> Results :
>
> Tests run: 1550, Failures: 0, Errors: 0, Skipped: 9
>
> ...
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:58.894s
> [INFO] Finished at: Wed Apr 23 18:54:35 EDT 2014
> [INFO] Final Memory: 21M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> John Speidel
>
>
Re: Review Request 20637: Add dependency related information to stacks in
the REST API
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20637/#review41292
-----------------------------------------------------------
Ship it!
Ship It!
- Tom Beerbower
On April 23, 2014, 11:23 p.m., John Speidel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20637/
> -----------------------------------------------------------
>
> (Updated April 23, 2014, 11:23 p.m.)
>
>
> Review request for Ambari, Sid Wagle and Tom Beerbower.
>
>
> Bugs: AMBARI-5553
> https://issues.apache.org/jira/browse/AMBARI-5553
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add dependency related information to stacks in the REST API.
>
> Added dependency related information to stacks in the REST API. This information describes dependencies between components which are part of a stack.
> A new dependencies resources will be added as a child to the stacksServices/serviceComponent (soon to be renamed to services/component) resource.
> For example:
> GET http://172.18.192.3:8080/api/v1/stacks/HDP/versions/1.3.3/stackServices/HBASE/serviceComponents/HBASE_MASTER?fields=dependencies/*
> {
> "href" : "http://172.18.192.3:8080/api/v1/stacks/HDP/versions/1.3.3/stackServices/HBASE/serviceComponents/HBASE_MASTER?fields=dependencies/*",
> "StackServiceComponents" : {
> "component_name" : "HBASE_MASTER",
> "service_name" : "HBASE",
> "stack_name" : "HDP",
> "stack_version" : "1.3.3"
> },
> "dependencies" : [
> {
> "href" : "http://172.18.192.3:8080/api/v1/stacks/HDP/versions/1.3.3/stackServices/HBASE/serviceComponents/HBASE_MASTER/dependencies/HDFS_CLIENT",
> "Dependencies" : {
> "component_name" : "HDFS_CLIENT",
> "dependent_component_name" : "HBASE_MASTER",
> "dependent_service_name" : "HBASE",
> "scope" : "host",
> "service_name" : "HDFS",
> "stack_name" : "HDP",
> "stack_version" : "1.3.3"
> },
> "auto_deploy" : {
> "enabled" : true
> }
> },
> {
> "href" : "http://172.18.192.3:8080/api/v1/stacks/HDP/versions/1.3.3/stackServices/HBASE/serviceComponents/HBASE_MASTER/dependencies/ZOOKEEPER_SERVER",
> "Dependencies" : {
> "component_name" : "ZOOKEEPER_SERVER",
> "dependent_component_name" : "HBASE_MASTER",
> "dependent_service_name" : "HBASE",
> "scope" : "cluster",
> "service_name" : "ZOOKEEPER",
> "stack_name" : "HDP",
> "stack_version" : "1.3.3"
> },
> "auto_deploy" : {
> "enabled" : true,
> "location" : "HBASE/HBASE_MASTER"
> }
> }
> ]
> }
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 8275796
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/StackDependencyResourceDefinition.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/StackServiceComponentResourceDefinition.java c38b1c7
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 659499e
> ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java 104d2bc
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 034e877
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceComponentResponse.java 51871a4
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java d536230
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java 18031d0
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java 4f25638
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDependencyResourceProvider.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceComponentResourceProvider.java fe570fe
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java 7792746
> ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java f03bd8c
> ambari-server/src/main/java/org/apache/ambari/server/state/DependencyInfo.java 305b98d
> ambari-server/src/main/resources/key_properties.json 78c15c5
> ambari-server/src/main/resources/properties.json ee7d87d
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 3a63b78
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java c9ac437
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDependencyResourceProviderTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/20637/diff/
>
>
> Testing
> -------
>
> Functional Tests:
> Extensive manual functional tests including getting of collections and instance resources as well as standard and dub queries on multiple fields.
>
> Unit Tests:
> Added new unit tests for new code
> Successfully ran all existing unit tests
>
> Results :
>
> Tests run: 1550, Failures: 0, Errors: 0, Skipped: 9
>
> ...
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:58.894s
> [INFO] Finished at: Wed Apr 23 18:54:35 EDT 2014
> [INFO] Final Memory: 21M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> John Speidel
>
>