You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hop.apache.org by ha...@apache.org on 2026/01/07 10:57:27 UTC
(hop) branch main updated: Fix bug in the graphs with over name when there is a note behind it #6309 (#6310)
This is an automated email from the ASF dual-hosted git repository.
hansva pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/hop.git
The following commit(s) were added to refs/heads/main by this push:
new f113ef3c3e Fix bug in the graphs with over name when there is a note behind it #6309 (#6310)
f113ef3c3e is described below
commit f113ef3c3e43556cb0a0a276a47faa02d2a4461f
Author: Nicolas Adment <39...@users.noreply.github.com>
AuthorDate: Wed Jan 7 11:57:22 2026 +0100
Fix bug in the graphs with over name when there is a note behind it #6309 (#6310)
---
.../hop/ui/hopgui/file/pipeline/HopGuiPipelineGraph.java | 14 ++++++++++----
.../hop/ui/hopgui/file/workflow/HopGuiWorkflowGraph.java | 15 ++++++++++-----
2 files changed, 20 insertions(+), 9 deletions(-)
diff --git a/ui/src/main/java/org/apache/hop/ui/hopgui/file/pipeline/HopGuiPipelineGraph.java b/ui/src/main/java/org/apache/hop/ui/hopgui/file/pipeline/HopGuiPipelineGraph.java
index 659afb1431..1ce78d8b3c 100644
--- a/ui/src/main/java/org/apache/hop/ui/hopgui/file/pipeline/HopGuiPipelineGraph.java
+++ b/ui/src/main/java/org/apache/hop/ui/hopgui/file/pipeline/HopGuiPipelineGraph.java
@@ -1478,8 +1478,8 @@ public class HopGuiPipelineGraph extends HopGuiAbstractGraph
&& !dragSelection) {
// Mouse over the name of the transform
//
- if (!PropsUi.getInstance().useDoubleClick()) {
- if (areaOwner.getAreaType() == AreaType.TRANSFORM_NAME) {
+ if (areaOwner.getAreaType() == AreaType.TRANSFORM_NAME) {
+ if (!PropsUi.getInstance().useDoubleClick()) {
if (mouseOverName == null) {
doRedraw = true;
}
@@ -1488,15 +1488,21 @@ public class HopGuiPipelineGraph extends HopGuiAbstractGraph
}
// Mouse over a note
- if (areaOwner.getAreaType() == AreaOwner.AreaType.NOTE) {
+ else if (areaOwner.getAreaType() == AreaOwner.AreaType.NOTE) {
// Check if the mouse hovers over the border to resize
resizeOver = this.getResize(areaOwner.getArea(), real);
+
+ // Remove over name (note behind a transform)
+ if (mouseOverName != null) {
+ mouseOverName = null;
+ doRedraw = true;
+ }
}
} else {
if (mouseOverName != null) {
+ mouseOverName = null;
doRedraw = true;
}
- mouseOverName = null;
}
//
diff --git a/ui/src/main/java/org/apache/hop/ui/hopgui/file/workflow/HopGuiWorkflowGraph.java b/ui/src/main/java/org/apache/hop/ui/hopgui/file/workflow/HopGuiWorkflowGraph.java
index 303e340d40..fc9cbfe573 100644
--- a/ui/src/main/java/org/apache/hop/ui/hopgui/file/workflow/HopGuiWorkflowGraph.java
+++ b/ui/src/main/java/org/apache/hop/ui/hopgui/file/workflow/HopGuiWorkflowGraph.java
@@ -1213,25 +1213,30 @@ public class HopGuiWorkflowGraph extends HopGuiAbstractGraph
&& !dragSelection) {
// Mouse over the name of the action
//
- if (!PropsUi.getInstance().useDoubleClick()) {
- if (areaOwner.getAreaType() == AreaOwner.AreaType.ACTION_NAME) {
+ if (areaOwner.getAreaType() == AreaOwner.AreaType.ACTION_NAME) {
+ if (!PropsUi.getInstance().useDoubleClick()) {
if (mouseOverName == null) {
doRedraw = true;
}
mouseOverName = (String) areaOwner.getOwner();
}
}
-
// Mouse over note
- if (areaOwner.getAreaType() == AreaOwner.AreaType.NOTE) {
+ else if (areaOwner.getAreaType() == AreaOwner.AreaType.NOTE) {
// Check if the mouse is over the border to activate a resize cursor
resizeOver = this.getResize(areaOwner.getArea(), real);
+
+ // Remove over name (note behind an action)
+ if (mouseOverName != null) {
+ mouseOverName = null;
+ doRedraw = true;
+ }
}
} else {
if (mouseOverName != null) {
+ mouseOverName = null;
doRedraw = true;
}
- mouseOverName = null;
}
//