You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/06/05 04:56:33 UTC
[GitHub] [bookkeeper] michaeljmarshall opened a new pull request, #3310: [Client] Switch to rely on Netty for Hostname Verification
michaeljmarshall opened a new pull request, #3310:
URL: https://github.com/apache/bookkeeper/pull/3310
### Motivation
Currently, we initiate hostname verification for the Bookkeeper Client in the `PerChannelBookieClient` class. In order to simplify the code, I propose that we refactor the client so it relies on Netty, its SslHandler, and the JVM, to perform the hostname verification.
When HTTPS is configured as the endpoint verification algorithm, it uses [RFC 2818](https://datatracker.ietf.org/doc/html/rfc2818) to perform hostname verification. This is defined by the Java Security Standard Algorithm Names documentation for JDK versions 8, 11, and 17. Here are the official docs:
https://docs.oracle.com/javase/8/docs/technotes/guides/security/StandardNames.html
https://docs.oracle.com/en/java/javase/11/docs/specs/security/standard-names.html
https://docs.oracle.com/en/java/javase/17/docs/specs/security/standard-names.html
### Changes
* Rely on Netty and the SslEngine to perform hostname verification. With this change, CN matching is now deprecated, which brings the bookkeeper client in alignment with RFC 2818.
* Add new method to the `SecurityHandlerFactory` interface. It is named `newTLSHandler` and takes the `host` and `port` of the remote peer when creating a new SslEngine. To ensure backwards compatibility, the default implementation will call the original method. Note that the remote host and port are only needed when a client is using them for hostname verification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] michaeljmarshall commented on pull request #3310: [Client] Switch to rely on SslEngine for Hostname Verification
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on PR #3310:
URL: https://github.com/apache/bookkeeper/pull/3310#issuecomment-1146746663
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Shoothzj merged pull request #3310: [Client] Switch to rely on SslEngine for Hostname Verification
Posted by GitBox <gi...@apache.org>.
Shoothzj merged PR #3310:
URL: https://github.com/apache/bookkeeper/pull/3310
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org