You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by GitBox <gi...@apache.org> on 2022/02/23 09:34:32 UTC

[GitHub] [incubator-brpc] zhangzhiming865 opened a new issue #1700: RDMA分支socket.cpp _read_buf.copy_to(tmp, rdma::HELLO_LENGTH)会越界，buf长度不够

zhangzhiming865 opened a new issue #1700:
URL: https://github.com/apache/incubator-brpc/issues/1700


   **Describe the bug (描述bug)**
   
   
   **To Reproduce (复现方法)**
   
   
   **Expected behavior (期望行为)**
   
   
   **Versions (各种版本)**
   OS:
   Compiler:
   brpc:
   protobuf:
   
   **Additional context/screenshots (更多上下文/截图)**
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org

[GitHub] [incubator-brpc] zhangzhiming865 commented on issue #1700: RDMA分支socket.cpp _read_buf.copy_to(tmp, rdma::HELLO_LENGTH)会越界，buf长度不够

Posted by GitBox <gi...@apache.org>.
zhangzhiming865 commented on issue #1700:
URL: https://github.com/apache/incubator-brpc/issues/1700#issuecomment-1050578634


   > 
   
   https://github.com/apache/incubator-brpc/issues/1699 这个issue看一下？


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org

[GitHub] [incubator-brpc] serverglen edited a comment on issue #1700: RDMA分支socket.cpp _read_buf.copy_to(tmp, rdma::HELLO_LENGTH)会越界，buf长度不够

Posted by GitBox <gi...@apache.org>.
serverglen edited a comment on issue #1700:
URL: https://github.com/apache/incubator-brpc/issues/1700#issuecomment-1049934942


   > **Describe the bug (描述bug)**
   > 
   > **To Reproduce (复现方法)**
   > 
   > **Expected behavior (期望行为)**
   > 
   > **Versions (各种版本)** OS: Compiler: brpc: protobuf:
   > 
   > **Additional context/screenshots (更多上下文/截图)**
   
   多谢反馈，应该改成
   ```c++
     char tmp[rdma::MAGIC_LENGTH];
     _read_buf.copy_to(tmp, rdma::MAGIC_LENGTH);
   ```
   有兴趣的话可以提个PR，修下这个问题。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org

[GitHub] [incubator-brpc] serverglen commented on issue #1700: RDMA分支socket.cpp _read_buf.copy_to(tmp, rdma::HELLO_LENGTH)会越界，buf长度不够

Posted by GitBox <gi...@apache.org>.
serverglen commented on issue #1700:
URL: https://github.com/apache/incubator-brpc/issues/1700#issuecomment-1049937015


   多谢反馈，应该改成这样：
   ```c++
     char tmp[rdma::MAGIC_LENGTH];
     _read_buf.copy_to(tmp, rdma::MAGIC_LENGTH);
   ```
   有兴趣的话可以提个PR修下这个问题。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org

[GitHub] [incubator-brpc] serverglen removed a comment on issue #1700: RDMA分支socket.cpp _read_buf.copy_to(tmp, rdma::HELLO_LENGTH)会越界，buf长度不够

Posted by GitBox <gi...@apache.org>.
serverglen removed a comment on issue #1700:
URL: https://github.com/apache/incubator-brpc/issues/1700#issuecomment-1049934942


   > **Describe the bug (描述bug)**
   > 
   > **To Reproduce (复现方法)**
   > 
   > **Expected behavior (期望行为)**
   > 
   > **Versions (各种版本)** OS: Compiler: brpc: protobuf:
   > 
   > **Additional context/screenshots (更多上下文/截图)**
   
   多谢反馈，应该改成
   ```c++
     char tmp[rdma::MAGIC_LENGTH];
     _read_buf.copy_to(tmp, rdma::MAGIC_LENGTH);
   ```
   有兴趣的话可以提个PR，修下这个问题。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org

[GitHub] [incubator-brpc] serverglen commented on issue #1700: RDMA分支socket.cpp _read_buf.copy_to(tmp, rdma::HELLO_LENGTH)会越界，buf长度不够

Posted by GitBox <gi...@apache.org>.
serverglen commented on issue #1700:
URL: https://github.com/apache/incubator-brpc/issues/1700#issuecomment-1049934942


   > **Describe the bug (描述bug)**
   > 
   > **To Reproduce (复现方法)**
   > 
   > **Expected behavior (期望行为)**
   > 
   > **Versions (各种版本)** OS: Compiler: brpc: protobuf:
   > 
   > **Additional context/screenshots (更多上下文/截图)**
   
   多谢反馈，应该改成
   `
     char tmp[rdma::MAGIC_LENGTH];
     _read_buf.copy_to(tmp, rdma::MAGIC_LENGTH);
   `
   有兴趣的话可以提个PR，修下这个问题。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org

[GitHub] [incubator-brpc] serverglen commented on issue #1700: RDMA分支socket.cpp _read_buf.copy_to(tmp, rdma::HELLO_LENGTH)会越界，buf长度不够

Posted by GitBox <gi...@apache.org>.
serverglen commented on issue #1700:
URL: https://github.com/apache/incubator-brpc/issues/1700#issuecomment-1053856172


   > > 
   > 
   > #1699 这个issue看一下？
   
   这个我研究下。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org