You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by "Nick Williams (JIRA)" <ji...@apache.org> on 2013/04/19 18:19:20 UTC
[jira] [Closed] (LOG4J2-211) "entry" and "exit" messages prepended
with extra space, spaces not consistent between entry and exit
[ https://issues.apache.org/jira/browse/LOG4J2-211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nick Williams closed LOG4J2-211.
--------------------------------
Verified. Much better. I have also updated the unit test patch on LOG4J2-187 (since it has not yet been applied) to resolve the unit tests broken by this change.
> "entry" and "exit" messages prepended with extra space, spaces not consistent between entry and exit
> ----------------------------------------------------------------------------------------------------
>
> Key: LOG4J2-211
> URL: https://issues.apache.org/jira/browse/LOG4J2-211
> Project: Log4j 2
> Issue Type: Bug
> Components: API
> Affects Versions: 2.0-beta5
> Reporter: Nick Williams
> Assignee: Ralph Goers
> Priority: Minor
> Fix For: 2.0-beta5
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> Lines 386 and 388 of AbstractLogger introduce an unnecessary space before the entry message (e.g., " entry"). Lines 1407 and 1409 of AbstractLogger introduce an unnecessary space before the exit message (e.g., " exit"). These spaces need to be removed. The "catching" and "throwing" messages do not contain a space before them, nor would one normally log a message starting with a space.
> Line 388 DOES NOT have a space between "parms" and the opening parenthesis, but line 1409 DOES have a space between "with" and the opening parenthesis. This is inconsistent. I would argue for removing the space on line 1409 between "with" and the opening parenthesis ... looks better.
> (NOTE: A patch proposed on LOG4J2-187 tonight adds unit tests, a handful of which will fail if the above proposed changes are made. Keep that in mind when making this change after committing those tests, or when committing those tests after making this change.)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org