[GitHub] fhueske opened a new pull request #6569: [FLINK-10116] [types] Fix getTotalFields() implementation of multiple TypeInformation.

[GitBox <gi...@apache.org>]

fhueske opened a new pull request #6569: [FLINK-10116] [types] Fix getTotalFields() implementation of multiple TypeInformation.
URL: https://github.com/apache/flink/pull/6569
 
 
   ## What is the purpose of the change
   
   Fixes the implementation of `TypeInformation.getTotalFields()` of several type informations. The method is used to determine the number of flattened fields to skip when determining key positions. Since a type info needs to be skipped even if it does not have nested fields, the method must return at least `1`.
   
   ## Brief change log
   
   * fixed all incorrect `TypeInformation` implementations
   * extended the JavaDoc of `TypeInformation.getTotalFields()`
   
   ## Verifying this change
   
   * added a new method to `TypeInformationTestBase` validating that the number of fields is at least 1.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **yes**
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? n/a
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services