You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/01/09 14:28:23 UTC
[GitHub] [incubator-shardingsphere] SteNicholas opened a new pull request
#3918: Alter table metadata refresh logic and actual table metadata
SteNicholas opened a new pull request #3918: Alter table metadata refresh logic and actual table metadata
URL: https://github.com/apache/incubator-shardingsphere/pull/3918
Fixes #3905.
`ShardingSchema` executes `AlterTableStatement` with logic table metadata refresh, but acutal table metadata doesn't refresh. This cause than after executing alter table add column operation, the operation for proxy that select * from table exists actual table metadata inconsistency.
Changes proposed in this pull request:
- Modify method `refreshTableMetaDataForAlterTable` of `ShardingSchema` to refresh logic and actual table metadata.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] cherrylzhao merged pull request #3918:
QueryHeader load logic table metadata
Posted by GitBox <gi...@apache.org>.
cherrylzhao merged pull request #3918: QueryHeader load logic table metadata
URL: https://github.com/apache/incubator-shardingsphere/pull/3918
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#3918: QueryHeader load logic table metadata
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #3918: QueryHeader load logic table metadata
URL: https://github.com/apache/incubator-shardingsphere/pull/3918#issuecomment-572603130
## Pull Request Test Coverage Report for [Build 1327](https://coveralls.io/builds/28019681)
* **16** of **18** **(88.89%)** changed or added relevant lines in **1** file are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage increased (+**0.004%**) to **65.715%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/response/query/QueryHeader.java](https://coveralls.io/builds/28019681/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fresponse%2Fquery%2FQueryHeader.java#L79) | 16 | 18 | 88.89%
<!-- | **Total:** | **16** | **18** | **88.89%** | -->
| Totals | [](https://coveralls.io/builds/28019681) |
| :-- | --: |
| Change from base [Build 663](https://coveralls.io/builds/28000463): | 0.004% |
| Covered Lines: | 10726 |
| Relevant Lines: | 16322 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3918:
Alter table metadata refresh logic and actual table metadata
Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #3918: Alter table metadata refresh logic and actual table metadata
URL: https://github.com/apache/incubator-shardingsphere/pull/3918#issuecomment-572603898
We need to make sure first, the key of table meta should be `logic table`, not `actual table`, is it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] dongzl commented on issue #3918:
QueryHeader load logic table metadata
Posted by GitBox <gi...@apache.org>.
dongzl commented on issue #3918: QueryHeader load logic table metadata
URL: https://github.com/apache/incubator-shardingsphere/pull/3918#issuecomment-572830814
The `QueryHeader`'s primarykey info is for this issue #3005 .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#3918: QueryHeader load logic table metadata
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #3918: QueryHeader load logic table metadata
URL: https://github.com/apache/incubator-shardingsphere/pull/3918#issuecomment-572603130
## Pull Request Test Coverage Report for [Build 1323](https://coveralls.io/builds/28009995)
* **15** of **17** **(88.24%)** changed or added relevant lines in **1** file are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage increased (+**0.002%**) to **65.713%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/response/query/QueryHeader.java](https://coveralls.io/builds/28009995/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fresponse%2Fquery%2FQueryHeader.java#L77) | 15 | 17 | 88.24%
<!-- | **Total:** | **15** | **17** | **88.24%** | -->
| Totals | [](https://coveralls.io/builds/28009995) |
| :-- | --: |
| Change from base [Build 663](https://coveralls.io/builds/28000463): | 0.002% |
| Covered Lines: | 10725 |
| Relevant Lines: | 16321 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #3918:
Alter table metadata refresh logic and actual table metadata
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #3918: Alter table metadata refresh logic and actual table metadata
URL: https://github.com/apache/incubator-shardingsphere/pull/3918#issuecomment-572603130
## Pull Request Test Coverage Report for [Build 1313](https://coveralls.io/builds/28005607)
* **0** of **10** **(0.0%)** changed or added relevant lines in **2** files are covered.
* **1** unchanged line in **1** file lost coverage.
* Overall coverage decreased (**-0.04%**) to **65.675%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/impl/ShardingSchema.java](https://coveralls.io/builds/28005607/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2Fimpl%2FShardingSchema.java#L149) | 0 | 3 | 0.0%
| [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/rule/ShardingRule.java](https://coveralls.io/builds/28005607/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Frule%2FShardingRule.java#L407) | 0 | 7 | 0.0%
<!-- | **Total:** | **0** | **10** | **0.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/impl/ShardingSchema.java](https://coveralls.io/builds/28005607/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2Fimpl%2FShardingSchema.java#L152) | 1 | 0.0% |
<!-- | **Total:** | **1** | | -->
| Totals | [](https://coveralls.io/builds/28005607) |
| :-- | --: |
| Change from base [Build 663](https://coveralls.io/builds/28000463): | -0.04% |
| Covered Lines: | 10726 |
| Relevant Lines: | 16332 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#3918: QueryHeader load logic table metadata
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #3918: QueryHeader load logic table metadata
URL: https://github.com/apache/incubator-shardingsphere/pull/3918#issuecomment-572603130
## Pull Request Test Coverage Report for [Build 1322](https://coveralls.io/builds/28009501)
* **15** of **17** **(88.24%)** changed or added relevant lines in **1** file are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage increased (+**0.002%**) to **65.713%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/response/query/QueryHeader.java](https://coveralls.io/builds/28009501/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fresponse%2Fquery%2FQueryHeader.java#L77) | 15 | 17 | 88.24%
<!-- | **Total:** | **15** | **17** | **88.24%** | -->
| Totals | [](https://coveralls.io/builds/28009501) |
| :-- | --: |
| Change from base [Build 663](https://coveralls.io/builds/28000463): | 0.002% |
| Covered Lines: | 10725 |
| Relevant Lines: | 16321 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services